-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add additional properties on eks job definition #40019
Conversation
Community NoteVoting for Prioritization
For Submitters
|
1153ac1
to
7b4bc58
Compare
8501c5a
to
6343a75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=batch TESTS="TestAccBatchJobDefinition_|TestAccBatchJobDefinitionDataSource_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/batch/... -v -count 1 -parallel 20 -run='TestAccBatchJobDefinition_|TestAccBatchJobDefinitionDataSource_' -timeout 360m
2024/11/06 09:56:13 Initializing Terraform AWS Provider...
--- PASS: TestAccBatchJobDefinitionDataSource_basicARN_EKSProperties (25.45s)
=== CONT TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccBatchJobDefinitionDataSource_basicARN_NodeProperties (26.74s)
=== CONT TestAccBatchJobDefinitionDataSource_basicName
--- PASS: TestAccBatchJobDefinition_propagateTags (29.45s)
=== CONT TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccBatchJobDefinition_disappears (32.06s)
=== CONT TestAccBatchJobDefinition_PlatformCapabilities_fargate
--- PASS: TestAccBatchJobDefinition_ContainerProperties_EmptyField (32.35s)
=== CONT TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_ec2 (36.94s)
=== CONT TestAccBatchJobDefinition_EKSProperties_multiContainers
--- PASS: TestAccBatchJobDefinition_basic (37.49s)
=== CONT TestAccBatchJobDefinition_ECSProperties_update
=== CONT TestAccBatchJobDefinition_emptyRetryStrategy
--- PASS: TestAccBatchJobDefinitionDataSource_tags (39.94s)
--- PASS: TestAccBatchJobDefinition_tags_ComputedTag_OnCreate (51.74s)
=== CONT TestAccBatchJobDefinition_schedulingPriority
--- PASS: TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag (34.26s)
=== CONT TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties
--- PASS: TestAccBatchJobDefinition_tags_null (62.67s)
=== CONT TestAccBatchJobDefinition_createTypeContainerWithNodeProperties
--- PASS: TestAccBatchJobDefinition_tags_EmptyMap (62.95s)
=== CONT TestAccBatchJobDefinitionDataSource_tags_EmptyMap
--- PASS: TestAccBatchJobDefinition_updateWithTags (69.20s)
=== CONT TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping
--- PASS: TestAccBatchJobDefinitionDataSource_basicARN (70.99s)
=== CONT TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties (11.85s)
=== CONT TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag (43.94s)
=== CONT TestAccBatchJobDefinition_EKSProperties_basic
--- PASS: TestAccBatchJobDefinition_createTypeContainerWithNodeProperties (11.39s)
=== CONT TestAccBatchJobDefinition_EKSProperties_imagePullSecrets
--- PASS: TestAccBatchJobDefinition_tags_AddOnUpdate (75.86s)
=== CONT TestAccBatchJobDefinition_EKSProperties_update
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_fargate (44.25s)
=== CONT TestAccBatchJobDefinition_NodeProperties_advanced
--- PASS: TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults (43.98s)
=== CONT TestAccBatchJobDefinition_NodeProperties_basic
--- PASS: TestAccBatchJobDefinition_EKSProperties_multiContainers (41.81s)
=== CONT TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccBatchJobDefinition_emptyRetryStrategy (39.32s)
=== CONT TestAccBatchJobDefinition_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Add (79.33s)
=== CONT TestAccBatchJobDefinition_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccBatchJobDefinitionDataSource_basicName (56.82s)
=== CONT TestAccBatchJobDefinition_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccBatchJobDefinition_tags_EmptyTag_OnCreate (83.62s)
=== CONT TestAccBatchJobDefinition_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccBatchJobDefinition_schedulingPriority (40.62s)
=== CONT TestAccBatchJobDefinition_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccBatchJobDefinitionDataSource_tags_EmptyMap (30.92s)
=== CONT TestAccBatchJobDefinition_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccBatchJobDefinition_ECSProperties_update (60.93s)
=== CONT TestAccBatchJobDefinition_tags_DefaultTags_providerOnly
--- PASS: TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping (31.36s)
=== CONT TestAccBatchJobDefinition_tags_DefaultTags_overlapping
--- PASS: TestAccBatchJobDefinition_EKSProperties_imagePullSecrets (37.45s)
=== CONT TestAccBatchJobDefinitionDataSource_tags_NullMap
--- PASS: TestAccBatchJobDefinition_EKSProperties_basic (38.24s)
=== CONT TestAccBatchJobDefinition_tags_DefaultTags_nonOverlapping
--- PASS: TestAccBatchJobDefinition_attributes (113.62s)
=== CONT TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccBatchJobDefinition_NodeProperties_basic (39.57s)
=== CONT TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_nullNonOverlappingResourceTag (45.15s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_emptyProviderOnlyTag (43.04s)
--- PASS: TestAccBatchJobDefinition_ContainerProperties_minorUpdate (128.22s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_nullOverlappingResourceTag (44.66s)
--- PASS: TestAccBatchJobDefinition_NodeProperties_advanced (60.17s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_emptyResourceTag (44.12s)
--- PASS: TestAccBatchJobDefinition_EKSProperties_update (61.09s)
--- PASS: TestAccBatchJobDefinitionDataSource_tags_NullMap (26.57s)
--- PASS: TestAccBatchJobDefinition_tags (147.37s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_updateToProviderOnly (68.24s)
--- PASS: TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Replace (69.72s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_updateToResourceOnly (55.47s)
--- PASS: TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_DefaultTag (78.98s)
--- PASS: TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_ResourceTag (86.46s)
--- PASS: TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Replace (44.50s)
--- PASS: TestAccBatchJobDefinition_ContainerProperties_advanced (161.19s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_overlapping (70.87s)
--- PASS: TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Add (59.67s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_nonOverlapping (63.03s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_providerOnly (84.76s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/batch 189.664s
Thanks for your contribution, @danquack! 👍 |
This functionality has been released in v5.75.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
initContainers
shareProcessNamespace
on resource/data sourceimagePullSecrets
on data source.Relations
Closes #38606
References
Output from Acceptance Testing