Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add additional properties on eks job definition #40019

Merged
merged 7 commits into from
Nov 6, 2024

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Nov 5, 2024

Description

  • ✨ Adds support for initContainers shareProcessNamespace on resource/data source
  • ✨ Adds support for imagePullSecrets on data source.
  • 🔧 Increases max containers/init Containers to 10, as defined in docs.
  • 📝 Adds doc support for metadata (pre-existing attribute)

Relations

Closes #38606

References

Output from Acceptance Testing

% TF_ACC=1 make testacc TESTS=TestAccBatchJobDefinitionDataSource_ PKG=batch                                                                                                              <aws:provider> <region:us-east-2>
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/batch/... -v -count 1 -parallel 20 -run='TestAccBatchJobDefinitionDataSource_'  -timeout 360m
2024/11/05 17:43:35 Initializing Terraform AWS Provider...
=== RUN   TestAccBatchJobDefinitionDataSource_tags
=== PAUSE TestAccBatchJobDefinitionDataSource_tags
=== RUN   TestAccBatchJobDefinitionDataSource_tags_NullMap
=== PAUSE TestAccBatchJobDefinitionDataSource_tags_NullMap
=== RUN   TestAccBatchJobDefinitionDataSource_tags_EmptyMap
=== PAUSE TestAccBatchJobDefinitionDataSource_tags_EmptyMap
=== RUN   TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping
=== RUN   TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccBatchJobDefinitionDataSource_basicName
=== PAUSE TestAccBatchJobDefinitionDataSource_basicName
=== RUN   TestAccBatchJobDefinitionDataSource_basicARN
=== PAUSE TestAccBatchJobDefinitionDataSource_basicARN
=== RUN   TestAccBatchJobDefinitionDataSource_basicARN_NodeProperties
=== PAUSE TestAccBatchJobDefinitionDataSource_basicARN_NodeProperties
=== RUN   TestAccBatchJobDefinitionDataSource_basicARN_EKSProperties
=== PAUSE TestAccBatchJobDefinitionDataSource_basicARN_EKSProperties
=== CONT  TestAccBatchJobDefinitionDataSource_tags
=== CONT  TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccBatchJobDefinitionDataSource_basicARN_NodeProperties
=== CONT  TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping
=== CONT  TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== CONT  TestAccBatchJobDefinitionDataSource_basicARN
=== CONT  TestAccBatchJobDefinitionDataSource_basicARN_EKSProperties
=== CONT  TestAccBatchJobDefinitionDataSource_tags_EmptyMap
=== CONT  TestAccBatchJobDefinitionDataSource_basicName
=== CONT  TestAccBatchJobDefinitionDataSource_tags_NullMap
--- PASS: TestAccBatchJobDefinitionDataSource_basicARN_NodeProperties (15.37s)
--- PASS: TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag (15.58s)
--- PASS: TestAccBatchJobDefinitionDataSource_basicARN_EKSProperties (15.80s)
--- PASS: TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping (16.54s)
--- PASS: TestAccBatchJobDefinitionDataSource_tags_NullMap (17.72s)
--- PASS: TestAccBatchJobDefinitionDataSource_tags_EmptyMap (18.12s)
--- PASS: TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag (18.49s)
--- PASS: TestAccBatchJobDefinitionDataSource_tags (20.32s)
--- PASS: TestAccBatchJobDefinitionDataSource_basicName (25.11s)
--- PASS: TestAccBatchJobDefinitionDataSource_basicARN (29.74s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/batch      37.646s

% TF_ACC=1 make testacc TESTS=TestAccBatchJobDefinition_ PKG=batch                                                                                                                        <aws:provider> <region:us-east-2>
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/batch/... -v -count 1 -parallel 20 -run='TestAccBatchJobDefinition_'  -timeout 360m
2024/11/05 17:44:23 Initializing Terraform AWS Provider...
=== RUN   TestAccBatchJobDefinition_tags
=== PAUSE TestAccBatchJobDefinition_tags
=== RUN   TestAccBatchJobDefinition_tags_null
=== PAUSE TestAccBatchJobDefinition_tags_null
=== RUN   TestAccBatchJobDefinition_tags_EmptyMap
=== PAUSE TestAccBatchJobDefinition_tags_EmptyMap
=== RUN   TestAccBatchJobDefinition_tags_AddOnUpdate
=== PAUSE TestAccBatchJobDefinition_tags_AddOnUpdate
=== RUN   TestAccBatchJobDefinition_tags_EmptyTag_OnCreate
=== PAUSE TestAccBatchJobDefinition_tags_EmptyTag_OnCreate
=== RUN   TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccBatchJobDefinition_tags_DefaultTags_providerOnly
=== PAUSE TestAccBatchJobDefinition_tags_DefaultTags_providerOnly
=== RUN   TestAccBatchJobDefinition_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccBatchJobDefinition_tags_DefaultTags_nonOverlapping
=== RUN   TestAccBatchJobDefinition_tags_DefaultTags_overlapping
=== PAUSE TestAccBatchJobDefinition_tags_DefaultTags_overlapping
=== RUN   TestAccBatchJobDefinition_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccBatchJobDefinition_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccBatchJobDefinition_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccBatchJobDefinition_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccBatchJobDefinition_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccBatchJobDefinition_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccBatchJobDefinition_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccBatchJobDefinition_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccBatchJobDefinition_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccBatchJobDefinition_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccBatchJobDefinition_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccBatchJobDefinition_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccBatchJobDefinition_tags_ComputedTag_OnCreate
=== PAUSE TestAccBatchJobDefinition_tags_ComputedTag_OnCreate
=== RUN   TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccBatchJobDefinition_basic
=== PAUSE TestAccBatchJobDefinition_basic
=== RUN   TestAccBatchJobDefinition_attributes
=== PAUSE TestAccBatchJobDefinition_attributes
=== RUN   TestAccBatchJobDefinition_disappears
=== PAUSE TestAccBatchJobDefinition_disappears
=== RUN   TestAccBatchJobDefinition_PlatformCapabilities_ec2
=== PAUSE TestAccBatchJobDefinition_PlatformCapabilities_ec2
=== RUN   TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults
=== PAUSE TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults
=== RUN   TestAccBatchJobDefinition_PlatformCapabilities_fargate
=== PAUSE TestAccBatchJobDefinition_PlatformCapabilities_fargate
=== RUN   TestAccBatchJobDefinition_ContainerProperties_advanced
=== PAUSE TestAccBatchJobDefinition_ContainerProperties_advanced
=== RUN   TestAccBatchJobDefinition_ContainerProperties_minorUpdate
=== PAUSE TestAccBatchJobDefinition_ContainerProperties_minorUpdate
=== RUN   TestAccBatchJobDefinition_propagateTags
=== PAUSE TestAccBatchJobDefinition_propagateTags
=== RUN   TestAccBatchJobDefinition_ContainerProperties_EmptyField
=== PAUSE TestAccBatchJobDefinition_ContainerProperties_EmptyField
=== RUN   TestAccBatchJobDefinition_NodeProperties_basic
=== PAUSE TestAccBatchJobDefinition_NodeProperties_basic
=== RUN   TestAccBatchJobDefinition_NodeProperties_advanced
=== PAUSE TestAccBatchJobDefinition_NodeProperties_advanced
=== RUN   TestAccBatchJobDefinition_EKSProperties_basic
=== PAUSE TestAccBatchJobDefinition_EKSProperties_basic
=== RUN   TestAccBatchJobDefinition_EKSProperties_update
=== PAUSE TestAccBatchJobDefinition_EKSProperties_update
=== RUN   TestAccBatchJobDefinition_EKSProperties_imagePullSecrets
=== PAUSE TestAccBatchJobDefinition_EKSProperties_imagePullSecrets
=== RUN   TestAccBatchJobDefinition_createTypeContainerWithNodeProperties
=== PAUSE TestAccBatchJobDefinition_createTypeContainerWithNodeProperties
=== RUN   TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties
=== PAUSE TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties
=== RUN   TestAccBatchJobDefinition_schedulingPriority
=== PAUSE TestAccBatchJobDefinition_schedulingPriority
=== RUN   TestAccBatchJobDefinition_emptyRetryStrategy
=== PAUSE TestAccBatchJobDefinition_emptyRetryStrategy
=== RUN   TestAccBatchJobDefinition_ECSProperties_update
=== PAUSE TestAccBatchJobDefinition_ECSProperties_update
=== RUN   TestAccBatchJobDefinition_updateWithTags
=== PAUSE TestAccBatchJobDefinition_updateWithTags
=== CONT  TestAccBatchJobDefinition_tags
=== CONT  TestAccBatchJobDefinition_basic
=== CONT  TestAccBatchJobDefinition_EKSProperties_basic
=== CONT  TestAccBatchJobDefinition_ContainerProperties_advanced
=== CONT  TestAccBatchJobDefinition_PlatformCapabilities_ec2
=== CONT  TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccBatchJobDefinition_disappears
=== CONT  TestAccBatchJobDefinition_updateWithTags
=== CONT  TestAccBatchJobDefinition_ECSProperties_update
=== CONT  TestAccBatchJobDefinition_emptyRetryStrategy
=== CONT  TestAccBatchJobDefinition_schedulingPriority
=== CONT  TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties
=== CONT  TestAccBatchJobDefinition_createTypeContainerWithNodeProperties
=== CONT  TestAccBatchJobDefinition_EKSProperties_imagePullSecrets
=== CONT  TestAccBatchJobDefinition_PlatformCapabilities_fargate
=== CONT  TestAccBatchJobDefinition_attributes
=== CONT  TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccBatchJobDefinition_NodeProperties_advanced
=== CONT  TestAccBatchJobDefinition_EKSProperties_update
--- PASS: TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties (8.54s)
=== CONT  TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccBatchJobDefinition_createTypeContainerWithNodeProperties (8.98s)
=== CONT  TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccBatchJobDefinition_disappears (24.92s)
=== CONT  TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccBatchJobDefinition_schedulingPriority (26.48s)
=== CONT  TestAccBatchJobDefinition_tags_ComputedTag_OnCreate
--- PASS: TestAccBatchJobDefinition_emptyRetryStrategy (27.32s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccBatchJobDefinition_EKSProperties_basic (29.66s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_ec2 (29.88s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccBatchJobDefinition_EKSProperties_imagePullSecrets (30.26s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults (30.78s)
=== CONT  TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccBatchJobDefinition_basic (30.98s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_fargate (32.33s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_overlapping
--- PASS: TestAccBatchJobDefinition_ECSProperties_update (43.08s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_nonOverlapping
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_updateToResourceOnly (43.45s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_providerOnly
--- PASS: TestAccBatchJobDefinition_updateWithTags (45.73s)
=== CONT  TestAccBatchJobDefinition_ContainerProperties_EmptyField
--- PASS: TestAccBatchJobDefinition_NodeProperties_advanced (46.06s)
=== CONT  TestAccBatchJobDefinition_NodeProperties_basic
--- PASS: TestAccBatchJobDefinition_EKSProperties_update (47.07s)
=== CONT  TestAccBatchJobDefinition_tags_AddOnUpdate
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_nullNonOverlappingResourceTag (32.32s)
=== CONT  TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_nullOverlappingResourceTag (31.60s)
=== CONT  TestAccBatchJobDefinition_tags_EmptyTag_OnCreate
--- PASS: TestAccBatchJobDefinition_tags_ComputedTag_OnCreate (35.21s)
=== CONT  TestAccBatchJobDefinition_propagateTags
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_emptyProviderOnlyTag (32.86s)
=== CONT  TestAccBatchJobDefinition_tags_EmptyMap
--- PASS: TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Replace (54.02s)
=== CONT  TestAccBatchJobDefinition_tags_null
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_emptyResourceTag (33.30s)
=== CONT  TestAccBatchJobDefinition_ContainerProperties_minorUpdate
--- PASS: TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_DefaultTag (61.68s)
--- PASS: TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_ResourceTag (74.14s)
--- PASS: TestAccBatchJobDefinition_NodeProperties_basic (29.48s)
--- PASS: TestAccBatchJobDefinition_ContainerProperties_EmptyField (30.90s)
--- PASS: TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Add (52.62s)
--- PASS: TestAccBatchJobDefinition_attributes (79.41s)
--- PASS: TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Replace (49.18s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_updateToProviderOnly (50.16s)
--- PASS: TestAccBatchJobDefinition_propagateTags (19.65s)
--- PASS: TestAccBatchJobDefinition_tags_AddOnUpdate (42.02s)
--- PASS: TestAccBatchJobDefinition_tags_EmptyMap (28.54s)
--- PASS: TestAccBatchJobDefinition_tags_null (28.51s)
--- PASS: TestAccBatchJobDefinition_tags (92.94s)
--- PASS: TestAccBatchJobDefinition_tags_EmptyTag_OnCreate (37.65s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_overlapping (67.48s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_nonOverlapping (60.34s)
--- PASS: TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Add (48.89s)
--- PASS: TestAccBatchJobDefinition_ContainerProperties_advanced (110.19s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_providerOnly (74.40s)
--- PASS: TestAccBatchJobDefinition_ContainerProperties_minorUpdate (76.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/batch      144.776s

@danquack danquack requested a review from a team as a code owner November 5, 2024 22:53
Copy link

github-actions bot commented Nov 5, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/batch Issues and PRs that pertain to the batch service. needs-triage Waiting for first response or review from a maintainer. labels Nov 5, 2024
@danquack danquack force-pushed the 38606/job-def-additional-props branch from 1153ac1 to 7b4bc58 Compare November 5, 2024 22:56
@danquack danquack force-pushed the 38606/job-def-additional-props branch from 8501c5a to 6343a75 Compare November 5, 2024 23:12
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Nov 6, 2024
@jar-b jar-b self-assigned this Nov 6, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 6, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=batch TESTS="TestAccBatchJobDefinition_|TestAccBatchJobDefinitionDataSource_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/batch/... -v -count 1 -parallel 20 -run='TestAccBatchJobDefinition_|TestAccBatchJobDefinitionDataSource_'  -timeout 360m
2024/11/06 09:56:13 Initializing Terraform AWS Provider...

--- PASS: TestAccBatchJobDefinitionDataSource_basicARN_EKSProperties (25.45s)
=== CONT  TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccBatchJobDefinitionDataSource_basicARN_NodeProperties (26.74s)
=== CONT  TestAccBatchJobDefinitionDataSource_basicName
--- PASS: TestAccBatchJobDefinition_propagateTags (29.45s)
=== CONT  TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccBatchJobDefinition_disappears (32.06s)
=== CONT  TestAccBatchJobDefinition_PlatformCapabilities_fargate
--- PASS: TestAccBatchJobDefinition_ContainerProperties_EmptyField (32.35s)
=== CONT  TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_ec2 (36.94s)
=== CONT  TestAccBatchJobDefinition_EKSProperties_multiContainers
--- PASS: TestAccBatchJobDefinition_basic (37.49s)
=== CONT  TestAccBatchJobDefinition_ECSProperties_update
=== CONT  TestAccBatchJobDefinition_emptyRetryStrategy
--- PASS: TestAccBatchJobDefinitionDataSource_tags (39.94s)
--- PASS: TestAccBatchJobDefinition_tags_ComputedTag_OnCreate (51.74s)
=== CONT  TestAccBatchJobDefinition_schedulingPriority
--- PASS: TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag (34.26s)
=== CONT  TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties
--- PASS: TestAccBatchJobDefinition_tags_null (62.67s)
=== CONT  TestAccBatchJobDefinition_createTypeContainerWithNodeProperties
--- PASS: TestAccBatchJobDefinition_tags_EmptyMap (62.95s)
=== CONT  TestAccBatchJobDefinitionDataSource_tags_EmptyMap
--- PASS: TestAccBatchJobDefinition_updateWithTags (69.20s)
=== CONT  TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping
--- PASS: TestAccBatchJobDefinitionDataSource_basicARN (70.99s)
=== CONT  TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties (11.85s)
=== CONT  TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag (43.94s)
=== CONT  TestAccBatchJobDefinition_EKSProperties_basic
--- PASS: TestAccBatchJobDefinition_createTypeContainerWithNodeProperties (11.39s)
=== CONT  TestAccBatchJobDefinition_EKSProperties_imagePullSecrets
--- PASS: TestAccBatchJobDefinition_tags_AddOnUpdate (75.86s)
=== CONT  TestAccBatchJobDefinition_EKSProperties_update
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_fargate (44.25s)
=== CONT  TestAccBatchJobDefinition_NodeProperties_advanced
--- PASS: TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults (43.98s)
=== CONT  TestAccBatchJobDefinition_NodeProperties_basic
--- PASS: TestAccBatchJobDefinition_EKSProperties_multiContainers (41.81s)
=== CONT  TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccBatchJobDefinition_emptyRetryStrategy (39.32s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Add (79.33s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccBatchJobDefinitionDataSource_basicName (56.82s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccBatchJobDefinition_tags_EmptyTag_OnCreate (83.62s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccBatchJobDefinition_schedulingPriority (40.62s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccBatchJobDefinitionDataSource_tags_EmptyMap (30.92s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccBatchJobDefinition_ECSProperties_update (60.93s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_providerOnly
--- PASS: TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping (31.36s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_overlapping
--- PASS: TestAccBatchJobDefinition_EKSProperties_imagePullSecrets (37.45s)
=== CONT  TestAccBatchJobDefinitionDataSource_tags_NullMap
--- PASS: TestAccBatchJobDefinition_EKSProperties_basic (38.24s)
=== CONT  TestAccBatchJobDefinition_tags_DefaultTags_nonOverlapping
--- PASS: TestAccBatchJobDefinition_attributes (113.62s)
=== CONT  TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccBatchJobDefinition_NodeProperties_basic (39.57s)
=== CONT  TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_nullNonOverlappingResourceTag (45.15s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_emptyProviderOnlyTag (43.04s)
--- PASS: TestAccBatchJobDefinition_ContainerProperties_minorUpdate (128.22s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_nullOverlappingResourceTag (44.66s)
--- PASS: TestAccBatchJobDefinition_NodeProperties_advanced (60.17s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_emptyResourceTag (44.12s)
--- PASS: TestAccBatchJobDefinition_EKSProperties_update (61.09s)
--- PASS: TestAccBatchJobDefinitionDataSource_tags_NullMap (26.57s)
--- PASS: TestAccBatchJobDefinition_tags (147.37s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_updateToProviderOnly (68.24s)
--- PASS: TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Replace (69.72s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_updateToResourceOnly (55.47s)
--- PASS: TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_DefaultTag (78.98s)
--- PASS: TestAccBatchJobDefinition_tags_IgnoreTags_Overlap_ResourceTag (86.46s)
--- PASS: TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Replace (44.50s)
--- PASS: TestAccBatchJobDefinition_ContainerProperties_advanced (161.19s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_overlapping (70.87s)
--- PASS: TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Add (59.67s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_nonOverlapping (63.03s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_providerOnly (84.76s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/batch      189.664s

@jar-b
Copy link
Member

jar-b commented Nov 6, 2024

Thanks for your contribution, @danquack! 👍

@jar-b jar-b merged commit c8de897 into hashicorp:main Nov 6, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.75.0 milestone Nov 6, 2024
Copy link

This functionality has been released in v5.75.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/batch Issues and PRs that pertain to the batch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for additional Batch EKS Pod Properties
2 participants