Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/wafv2_web_acl: fix rule_json error when unmarshalling #39878

Merged
merged 6 commits into from
Oct 25, 2024
Merged

r/wafv2_web_acl: fix rule_json error when unmarshalling #39878

merged 6 commits into from
Oct 25, 2024
+215 −4

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Oct 24, 2024 •
edited
Loading

Description

the AWS object contains fields with []byte as the type. The json.Unmarshal function expects the input values of this type to be base64 encoded. Strings that are not encoded throw an error: decoding JSON: illegal base64 data

% make testacc TESTARGS='-run=TestAccWAFV2WebACL_ruleJSON' PKG=wafv2

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/wafv2/... -v -count 1 -parallel 20  -run=TestAccWAFV2WebACL_ruleJSON -timeout 360m
2024/10/24 11:31:49 Initializing Terraform AWS Provider...
=== RUN   TestAccWAFV2WebACL_ruleJSON
=== PAUSE TestAccWAFV2WebACL_ruleJSON
=== CONT  TestAccWAFV2WebACL_ruleJSON
    web_acl_test.go:3056: Step 3/3 error: Error running apply: exit status 1

        Error: expanding WAFv2 WebACL JSON rule (317b1855-c0bd-41e2-b2a5-34b7f3289c9a): decoding JSON: illegal base64 data at input byte 7

          with aws_wafv2_web_acl.test,
          on terraform_plugin_test.tf line 12, in resource "aws_wafv2_web_acl" "test":
          12: resource "aws_wafv2_web_acl" "test" {

--- FAIL: TestAccWAFV2WebACL_ruleJSON (22.98s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/wafv2	29.464s
FAIL
make: *** [testacc] Error 1

Relations

Closes #39787

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccWAFV2WebACL_ruleJSON' PKG=wafv2

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/wafv2/... -v -count 1 -parallel 20  -run=TestAccWAFV2WebACL_ruleJSON -timeout 360m
2024/10/24 11:49:09 Initializing Terraform AWS Provider...
=== RUN   TestAccWAFV2WebACL_ruleJSON
=== PAUSE TestAccWAFV2WebACL_ruleJSON
=== CONT  TestAccWAFV2WebACL_ruleJSON
--- PASS: TestAccWAFV2WebACL_ruleJSON (28.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafv2	35.287s
% make testacc TESTARGS='-run=TestAccWAFV2WebACL_' PKG=wafv2 AWS_DEFAULT_REGION=us-east-1

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/wafv2/... -v -count 1 -parallel 20  -run=TestAccWAFV2WebACL_ -timeout 360m
2024/10/24 15:07:40 Initializing Terraform AWS Provider...
--- PASS: TestAccWAFV2WebACL_minimal (30.82s)
--- PASS: TestAccWAFV2WebACL_basic (38.50s)
--- PASS: TestAccWAFV2WebACL_tokenDomains (40.21s)
--- PASS: TestAccWAFV2WebACL_associationConfigRegional (43.92s)
--- PASS: TestAccWAFV2WebACL_RateBased_maxNested (47.54s)
--- PASS: TestAccWAFV2WebACL_Operators_maxNested (66.39s)
--- PASS: TestAccWAFV2WebACL_CloudFrontScope (66.45s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion (87.44s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_BotControl (48.12s)
--- PASS: TestAccWAFV2WebACL_RateBased_basic (89.89s)
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_jsonBody (90.57s)
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_headerOrder (91.27s)
--- PASS: TestAccWAFV2WebACL_GeoMatch_forwardedIP (95.50s)
--- PASS: TestAccWAFV2WebACL_ruleJSON (101.17s)
--- PASS: TestAccWAFV2WebACL_GeoMatch_basic (104.08s)
--- PASS: TestAccWAFV2WebACL_RateBased_forwardedIP (104.39s)
--- PASS: TestAccWAFV2WebACL_LabelMatchStatement (123.60s)
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_ja3fingerprint (123.96s)
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_basic (133.77s)
--- PASS: TestAccWAFV2WebACL_disappears (46.41s)
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_body (134.04s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ACFPRuleSet (94.13s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ATPRuleSet (100.23s)
--- PASS: TestAccWAFV2WebACL_associationConfigCloudFront (54.37s)
--- PASS: TestAccWAFV2WebACL_Update_nameForceNew (86.33s)
--- PASS: TestAccWAFV2WebACL_Custom_response (156.45s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig (91.45s)
--- PASS: TestAccWAFV2WebACL_tags (128.60s)
--- PASS: TestAccWAFV2WebACL_IPSetReference_basic (45.02s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_basic (140.73s)
--- PASS: TestAccWAFV2WebACL_RuleLabels (63.87s)
--- PASS: TestAccWAFV2WebACL_RuleGroupReference_basic (86.86s)
--- PASS: TestAccWAFV2WebACL_Update_rule (58.78s)
--- PASS: TestAccWAFV2WebACL_RuleGroupReference_shieldMitigation (102.73s)
--- PASS: TestAccWAFV2WebACL_RuleGroupReference_manageShieldMitigationRule (106.65s)
--- PASS: TestAccWAFV2WebACL_Update_ruleProperties (93.58s)
--- PASS: TestAccWAFV2WebACL_Custom_requestHandling (115.04s)
--- PASS: TestAccWAFV2WebACL_IPSetReference_forwardedIP (110.34s)
--- PASS: TestAccWAFV2WebACL_RateBased_customKeys (160.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafv2	268.299s
% go test -count=1 -v ./internal/service/wafv2/... -run=Test_expandWebACLRulesJSON

2024/10/25 11:13:57 Initializing Terraform AWS Provider...
=== RUN   Test_expandWebACLRulesJSON
=== PAUSE Test_expandWebACLRulesJSON
=== CONT  Test_expandWebACLRulesJSON
=== RUN   Test_expandWebACLRulesJSON/single_null_object
=== PAUSE Test_expandWebACLRulesJSON/single_null_object
=== RUN   Test_expandWebACLRulesJSON/valid_and_empty_object
=== PAUSE Test_expandWebACLRulesJSON/valid_and_empty_object
=== RUN   Test_expandWebACLRulesJSON/empty_array
=== PAUSE Test_expandWebACLRulesJSON/empty_array
=== RUN   Test_expandWebACLRulesJSON/valid_object
=== PAUSE Test_expandWebACLRulesJSON/valid_object
=== RUN   Test_expandWebACLRulesJSON/valid_object_SearchString
=== PAUSE Test_expandWebACLRulesJSON/valid_object_SearchString
=== RUN   Test_expandWebACLRulesJSON/empty_string
=== PAUSE Test_expandWebACLRulesJSON/empty_string
=== RUN   Test_expandWebACLRulesJSON/single_empty_object
=== PAUSE Test_expandWebACLRulesJSON/single_empty_object
=== CONT  Test_expandWebACLRulesJSON/single_null_object
=== CONT  Test_expandWebACLRulesJSON/valid_object_SearchString
=== CONT  Test_expandWebACLRulesJSON/empty_array
=== CONT  Test_expandWebACLRulesJSON/single_empty_object
=== CONT  Test_expandWebACLRulesJSON/empty_string
=== CONT  Test_expandWebACLRulesJSON/valid_and_empty_object
=== CONT  Test_expandWebACLRulesJSON/valid_object
--- PASS: Test_expandWebACLRulesJSON (0.00s)
    --- PASS: Test_expandWebACLRulesJSON/single_null_object (0.00s)
    --- PASS: Test_expandWebACLRulesJSON/empty_string (0.00s)
    --- PASS: Test_expandWebACLRulesJSON/empty_array (0.00s)
    --- PASS: Test_expandWebACLRulesJSON/valid_and_empty_object (0.00s)
    --- PASS: Test_expandWebACLRulesJSON/valid_object (0.00s)
    --- PASS: Test_expandWebACLRulesJSON/single_empty_object (0.00s)
    --- PASS: Test_expandWebACLRulesJSON/valid_object_SearchString (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafv2	6.321s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/wafv2 Issues and PRs that pertain to the wafv2 service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 24, 2024
@johnsonaj johnsonaj added the bug Addresses a defect in current functionality. label Oct 24, 2024
@johnsonaj johnsonaj marked this pull request as ready for review October 24, 2024 20:45
@johnsonaj johnsonaj requested a review from a team as a code owner October 24, 2024 20:45
ewbankkit
ewbankkit approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccWAFV2WebACL_' PKG=wafv2 ACCTEST_PARALLELISM=4             
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/wafv2/... -v -count 1 -parallel 4  -run=TestAccWAFV2WebACL_ -timeout 360m
2024/10/25 09:08:39 Initializing Terraform AWS Provider...
=== RUN   TestAccWAFV2WebACL_basic
=== PAUSE TestAccWAFV2WebACL_basic
=== RUN   TestAccWAFV2WebACL_Update_rule
=== PAUSE TestAccWAFV2WebACL_Update_rule
=== RUN   TestAccWAFV2WebACL_Update_ruleProperties
=== PAUSE TestAccWAFV2WebACL_Update_ruleProperties
=== RUN   TestAccWAFV2WebACL_Update_nameForceNew
=== PAUSE TestAccWAFV2WebACL_Update_nameForceNew
=== RUN   TestAccWAFV2WebACL_disappears
=== PAUSE TestAccWAFV2WebACL_disappears
=== RUN   TestAccWAFV2WebACL_ManagedRuleGroup_basic
=== PAUSE TestAccWAFV2WebACL_ManagedRuleGroup_basic
=== RUN   TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig
=== PAUSE TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig
=== RUN   TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ACFPRuleSet
=== PAUSE TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ACFPRuleSet
=== RUN   TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ATPRuleSet
=== PAUSE TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ATPRuleSet
=== RUN   TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_BotControl
=== PAUSE TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_BotControl
=== RUN   TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion
=== PAUSE TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion
=== RUN   TestAccWAFV2WebACL_minimal
=== PAUSE TestAccWAFV2WebACL_minimal
=== RUN   TestAccWAFV2WebACL_RateBased_basic
=== PAUSE TestAccWAFV2WebACL_RateBased_basic
=== RUN   TestAccWAFV2WebACL_ByteMatchStatement_basic
=== PAUSE TestAccWAFV2WebACL_ByteMatchStatement_basic
=== RUN   TestAccWAFV2WebACL_ByteMatchStatement_ja3fingerprint
=== PAUSE TestAccWAFV2WebACL_ByteMatchStatement_ja3fingerprint
=== RUN   TestAccWAFV2WebACL_ByteMatchStatement_jsonBody
=== PAUSE TestAccWAFV2WebACL_ByteMatchStatement_jsonBody
=== RUN   TestAccWAFV2WebACL_ByteMatchStatement_body
=== PAUSE TestAccWAFV2WebACL_ByteMatchStatement_body
=== RUN   TestAccWAFV2WebACL_ByteMatchStatement_headerOrder
=== PAUSE TestAccWAFV2WebACL_ByteMatchStatement_headerOrder
=== RUN   TestAccWAFV2WebACL_GeoMatch_basic
=== PAUSE TestAccWAFV2WebACL_GeoMatch_basic
=== RUN   TestAccWAFV2WebACL_GeoMatch_forwardedIP
=== PAUSE TestAccWAFV2WebACL_GeoMatch_forwardedIP
=== RUN   TestAccWAFV2WebACL_LabelMatchStatement
=== PAUSE TestAccWAFV2WebACL_LabelMatchStatement
=== RUN   TestAccWAFV2WebACL_RuleLabels
=== PAUSE TestAccWAFV2WebACL_RuleLabels
=== RUN   TestAccWAFV2WebACL_IPSetReference_basic
=== PAUSE TestAccWAFV2WebACL_IPSetReference_basic
=== RUN   TestAccWAFV2WebACL_IPSetReference_forwardedIP
=== PAUSE TestAccWAFV2WebACL_IPSetReference_forwardedIP
=== RUN   TestAccWAFV2WebACL_RateBased_customKeys
=== PAUSE TestAccWAFV2WebACL_RateBased_customKeys
=== RUN   TestAccWAFV2WebACL_RateBased_forwardedIP
=== PAUSE TestAccWAFV2WebACL_RateBased_forwardedIP
=== RUN   TestAccWAFV2WebACL_RuleGroupReference_basic
=== PAUSE TestAccWAFV2WebACL_RuleGroupReference_basic
=== RUN   TestAccWAFV2WebACL_RuleGroupReference_shieldMitigation
=== PAUSE TestAccWAFV2WebACL_RuleGroupReference_shieldMitigation
=== RUN   TestAccWAFV2WebACL_RuleGroupReference_manageShieldMitigationRule
=== PAUSE TestAccWAFV2WebACL_RuleGroupReference_manageShieldMitigationRule
=== RUN   TestAccWAFV2WebACL_Custom_requestHandling
=== PAUSE TestAccWAFV2WebACL_Custom_requestHandling
=== RUN   TestAccWAFV2WebACL_Custom_response
=== PAUSE TestAccWAFV2WebACL_Custom_response
=== RUN   TestAccWAFV2WebACL_tags
=== PAUSE TestAccWAFV2WebACL_tags
=== RUN   TestAccWAFV2WebACL_RateBased_maxNested
=== PAUSE TestAccWAFV2WebACL_RateBased_maxNested
=== RUN   TestAccWAFV2WebACL_Operators_maxNested
=== PAUSE TestAccWAFV2WebACL_Operators_maxNested
=== RUN   TestAccWAFV2WebACL_tokenDomains
=== PAUSE TestAccWAFV2WebACL_tokenDomains
=== RUN   TestAccWAFV2WebACL_associationConfigCloudFront
=== PAUSE TestAccWAFV2WebACL_associationConfigCloudFront
=== RUN   TestAccWAFV2WebACL_associationConfigRegional
=== PAUSE TestAccWAFV2WebACL_associationConfigRegional
=== RUN   TestAccWAFV2WebACL_CloudFrontScope
=== PAUSE TestAccWAFV2WebACL_CloudFrontScope
=== RUN   TestAccWAFV2WebACL_ruleJSON
=== PAUSE TestAccWAFV2WebACL_ruleJSON
=== CONT  TestAccWAFV2WebACL_basic
=== CONT  TestAccWAFV2WebACL_LabelMatchStatement
=== CONT  TestAccWAFV2WebACL_Custom_response
=== CONT  TestAccWAFV2WebACL_ruleJSON
--- PASS: TestAccWAFV2WebACL_basic (16.73s)
=== CONT  TestAccWAFV2WebACL_CloudFrontScope
    web_acl_test.go:3004: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccWAFV2WebACL_CloudFrontScope (0.00s)
=== CONT  TestAccWAFV2WebACL_associationConfigRegional
--- PASS: TestAccWAFV2WebACL_ruleJSON (27.64s)
=== CONT  TestAccWAFV2WebACL_associationConfigCloudFront
    web_acl_test.go:2907: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccWAFV2WebACL_associationConfigCloudFront (0.00s)
=== CONT  TestAccWAFV2WebACL_tokenDomains
--- PASS: TestAccWAFV2WebACL_associationConfigRegional (15.64s)
=== CONT  TestAccWAFV2WebACL_Operators_maxNested
--- PASS: TestAccWAFV2WebACL_LabelMatchStatement (34.23s)
=== CONT  TestAccWAFV2WebACL_RateBased_maxNested
--- PASS: TestAccWAFV2WebACL_Custom_response (39.32s)
=== CONT  TestAccWAFV2WebACL_tags
--- PASS: TestAccWAFV2WebACL_tokenDomains (15.73s)
=== CONT  TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion
--- PASS: TestAccWAFV2WebACL_Operators_maxNested (17.60s)
=== CONT  TestAccWAFV2WebACL_GeoMatch_forwardedIP
--- PASS: TestAccWAFV2WebACL_RateBased_maxNested (17.62s)
=== CONT  TestAccWAFV2WebACL_GeoMatch_basic
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion (27.60s)
=== CONT  TestAccWAFV2WebACL_ByteMatchStatement_headerOrder
--- PASS: TestAccWAFV2WebACL_tags (36.13s)
=== CONT  TestAccWAFV2WebACL_ByteMatchStatement_body
--- PASS: TestAccWAFV2WebACL_GeoMatch_forwardedIP (27.97s)
=== CONT  TestAccWAFV2WebACL_ByteMatchStatement_jsonBody
--- PASS: TestAccWAFV2WebACL_GeoMatch_basic (27.71s)
=== CONT  TestAccWAFV2WebACL_ByteMatchStatement_ja3fingerprint
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_headerOrder (27.41s)
=== CONT  TestAccWAFV2WebACL_ByteMatchStatement_basic
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_body (27.53s)
=== CONT  TestAccWAFV2WebACL_RateBased_basic
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_jsonBody (27.44s)
=== CONT  TestAccWAFV2WebACL_minimal
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_ja3fingerprint (27.53s)
=== CONT  TestAccWAFV2WebACL_IPSetReference_forwardedIP
--- PASS: TestAccWAFV2WebACL_minimal (13.05s)
=== CONT  TestAccWAFV2WebACL_RateBased_customKeys
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_basic (27.62s)
=== CONT  TestAccWAFV2WebACL_RuleGroupReference_manageShieldMitigationRule
--- PASS: TestAccWAFV2WebACL_RateBased_basic (27.51s)
=== CONT  TestAccWAFV2WebACL_RateBased_forwardedIP
=== CONT  TestAccWAFV2WebACL_Custom_requestHandling
--- PASS: TestAccWAFV2WebACL_RateBased_forwardedIP (28.60s)
--- PASS: TestAccWAFV2WebACL_IPSetReference_forwardedIP (52.20s)
=== CONT  TestAccWAFV2WebACL_RuleGroupReference_shieldMitigation
--- PASS: TestAccWAFV2WebACL_RuleGroupReference_manageShieldMitigationRule (42.59s)
=== CONT  TestAccWAFV2WebACL_RuleGroupReference_basic
--- PASS: TestAccWAFV2WebACL_RuleGroupReference_basic (35.45s)
=== CONT  TestAccWAFV2WebACL_IPSetReference_basic
--- PASS: TestAccWAFV2WebACL_Custom_requestHandling (48.93s)
=== CONT  TestAccWAFV2WebACL_RuleLabels
--- PASS: TestAccWAFV2WebACL_RuleGroupReference_shieldMitigation (50.77s)
=== CONT  TestAccWAFV2WebACL_ManagedRuleGroup_basic
--- PASS: TestAccWAFV2WebACL_IPSetReference_basic (17.50s)
=== CONT  TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_BotControl
--- PASS: TestAccWAFV2WebACL_RateBased_customKeys (106.55s)
=== CONT  TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_BotControl (13.82s)
=== CONT  TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ACFPRuleSet
--- PASS: TestAccWAFV2WebACL_RuleLabels (28.39s)
=== CONT  TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ATPRuleSet
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig (28.18s)
=== CONT  TestAccWAFV2WebACL_Update_nameForceNew
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_basic (47.65s)
=== CONT  TestAccWAFV2WebACL_disappears
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ACFPRuleSet (28.25s)
=== CONT  TestAccWAFV2WebACL_Update_ruleProperties
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ATPRuleSet (28.12s)
=== CONT  TestAccWAFV2WebACL_Update_rule
--- PASS: TestAccWAFV2WebACL_disappears (13.42s)
--- PASS: TestAccWAFV2WebACL_Update_nameForceNew (26.67s)
--- PASS: TestAccWAFV2WebACL_Update_rule (28.49s)
--- PASS: TestAccWAFV2WebACL_Update_ruleProperties (41.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafv2	310.059s

@johnsonaj johnsonaj merged commit 7eaac40 into main Oct 25, 2024
40 checks passed
@johnsonaj johnsonaj deleted the b-wafv2-rule_json_error branch October 25, 2024 16:35
@github-actions github-actions bot added this to the v5.74.0 milestone Oct 25, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 25, 2024
Update CHANGELOG.md for #39878
c39647b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/wafv2 Issues and PRs that pertain to the wafv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.74.0
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_wafv2_web_acl rule_json throwing errors for specific json rules
2 participants
@johnsonaj @ewbankkit