Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aws_apprunner_auto_scaling_configuration_version should not validate max_size constraint #39830

Closed
ohookins opened this issue Oct 22, 2024 · 4 comments · Fixed by #39843
Labels
bug Addresses a defect in current functionality. service/apprunner Issues and PRs that pertain to the apprunner service.
Milestone

Comments

@ohookins
Copy link
Contributor

Terraform Core Version

1.9.7

AWS Provider Version

5.68.0

Affected Resource(s)

  • aws_apprunner_auto_scaling_configuration_version

Expected Behavior

The attribute max_size does have a default limit of 25, and the provider enforces this with a validation. However, it is possible to have this limit raised by AWS Support to an arbitrary limit, and the provider should not constrain that.

In our case, we had the limit raised to 100 and this is possible to set via the API.

Actual Behavior

│ Error: expected max_size to be in the range (1 - 25), got 100
│ 
│   with module.screenshot_worker.aws_apprunner_auto_scaling_configuration_version.this,
│   on ../../../../../module/infra/aws_apprunner_service/0.0.1/apprunner-autoscaling-configuration.tf line 6, in resource "aws_apprunner_auto_scaling_configuration_version" "this":
│    6:   max_size        = var.max_size

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

N/A

Steps to Reproduce

It's literally here:

Debug Output

N/A

Panic Output

N/A

Important Factoids

References

Would you like to implement a fix?

No

@ohookins ohookins added the bug Addresses a defect in current functionality. label Oct 22, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/apprunner Issues and PRs that pertain to the apprunner service. needs-triage Waiting for first response or review from a maintainer. labels Oct 22, 2024
@ohookins
Copy link
Contributor Author

Fixed by #39843

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 23, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.73.0 milestone Oct 23, 2024
Copy link

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/apprunner Issues and PRs that pertain to the apprunner service.
Projects
None yet
2 participants