Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_space - support app lifecycle management #39800

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 18, 2024

Description

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccSageMaker_serial/Space/jupyterLabAppSettingsLifecycle  PKG=sagemaker

--- PASS: TestAccSageMaker_serial/Space/basic (248.37s)
--- PASS: TestAccSageMaker_serial/Space/jupyterLabAppSettingsLifecycle (278.43s)
--- PASS: TestAccSageMaker_serial/Space/jupyterLabAppSettings (280.42s)

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Oct 18, 2024
Signed-off-by: drfaust92 <[email protected]>
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 18, 2024
@DrFaust92 DrFaust92 marked this pull request as ready for review October 18, 2024 19:03
@DrFaust92 DrFaust92 requested a review from a team as a code owner October 18, 2024 19:03
@ewbankkit
Copy link
Contributor

@DrFaust92 Could you add a CHANGELOG entry please?

@DrFaust92
Copy link
Collaborator Author

@ewbankkit Whoops, missed that. Will do

@DrFaust92
Copy link
Collaborator Author

@ewbankkit seems i did it already but forgot to push 😊

@ewbankkit ewbankkit self-assigned this Oct 21, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 21, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMaker_serial/^Space$$' PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/sagemaker/... -v -count 1 -parallel 20  -run=TestAccSageMaker_serial/^Space$ -timeout 360m
2024/10/21 08:24:31 Initializing Terraform AWS Provider...
=== RUN   TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT  TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/Space
=== RUN   TestAccSageMaker_serial/Space/disappears
=== RUN   TestAccSageMaker_serial/Space/jupyterServerAppSettings
=== RUN   TestAccSageMaker_serial/Space/jupyterLabAppSettings
=== RUN   TestAccSageMaker_serial/Space/jupyterLabAppSettingsLifecycle
=== RUN   TestAccSageMaker_serial/Space/basic
=== RUN   TestAccSageMaker_serial/Space/tags
=== RUN   TestAccSageMaker_serial/Space/kernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/Space/kernelGatewayAppSettings_lifecycleConfig
=== RUN   TestAccSageMaker_serial/Space/kernelGatewayAppSettings_imageConfig
    space_test.go:203: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/Space/codeEditorAppSettings
=== RUN   TestAccSageMaker_serial/Space/storageSettings
=== RUN   TestAccSageMaker_serial/Space/customFileSystem
--- PASS: TestAccSageMaker_serial (2855.65s)
    --- PASS: TestAccSageMaker_serial/Space (2855.65s)
        --- PASS: TestAccSageMaker_serial/Space/disappears (276.56s)
        --- PASS: TestAccSageMaker_serial/Space/jupyterServerAppSettings (255.28s)
        --- PASS: TestAccSageMaker_serial/Space/jupyterLabAppSettings (272.39s)
        --- PASS: TestAccSageMaker_serial/Space/jupyterLabAppSettingsLifecycle (275.14s)
        --- PASS: TestAccSageMaker_serial/Space/basic (255.02s)
        --- PASS: TestAccSageMaker_serial/Space/tags (252.81s)
        --- PASS: TestAccSageMaker_serial/Space/kernelGatewayAppSettings (214.71s)
        --- PASS: TestAccSageMaker_serial/Space/kernelGatewayAppSettings_lifecycleConfig (215.95s)
        --- SKIP: TestAccSageMaker_serial/Space/kernelGatewayAppSettings_imageConfig (0.00s)
        --- PASS: TestAccSageMaker_serial/Space/codeEditorAppSettings (216.87s)
        --- PASS: TestAccSageMaker_serial/Space/storageSettings (255.37s)
        --- PASS: TestAccSageMaker_serial/Space/customFileSystem (365.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	2860.767s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2415c47 into hashicorp:main Oct 21, 2024
47 checks passed
@github-actions github-actions bot added this to the v5.73.0 milestone Oct 21, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 24, 2024
Copy link

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants