-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_amplify_app: fix removal of environment_variables
#39397
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Previously existing `environment_variables` were removed by sending a map with an empty key/value pair. The `UpdateApp` API appears to have added restrictions around keys with empty values, so this approach began to fail the corresponding acceptance test. After reporting the issue to the AWS Go SDK V2, the new method for removing environment variables is to pass a key containing a single space character and an empty string value. ```console % make testacc PKG=amplify TESTS=TestAccAmplify_serial/App/EnvironmentVariables make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.7 test ./internal/service/amplify/... -v -count 1 -parallel 20 -run='TestAccAmplify_serial/App/EnvironmentVariables' -timeout 360m --- PASS: TestAccAmplify_serial (301.10s) --- PASS: TestAccAmplify_serial/App (301.10s) --- PASS: TestAccAmplify_serial/App/EnvironmentVariables (301.10s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/amplify 307.329s ```
f895243
to
ab739ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Previously existing
environment_variables
were removed by sending a map with an empty key/value pair. TheUpdateApp
API appears to have added restrictions around keys with empty values, so this approach began to fail the corresponding acceptance test. After reporting the issue to the AWS Go SDK V2, the new method for removing environment variables is to pass a key containing a single space character and an empty string value.Relations
Closes #39327
Relates aws/aws-sdk-go-v2#2788
References
Output from Acceptance Testing