Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_amplify_app: fix removal of environment_variables #39397

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Sep 19, 2024

Description

Previously existing environment_variables were removed by sending a map with an empty key/value pair. The UpdateApp API appears to have added restrictions around keys with empty values, so this approach began to fail the corresponding acceptance test. After reporting the issue to the AWS Go SDK V2, the new method for removing environment variables is to pass a key containing a single space character and an empty string value.

Relations

Closes #39327
Relates aws/aws-sdk-go-v2#2788

References

Output from Acceptance Testing

% make testacc PKG=amplify TESTS=TestAccAmplify_serial/App/EnvironmentVariables
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/amplify/... -v -count 1 -parallel 20 -run='TestAccAmplify_serial/App/EnvironmentVariables'  -timeout 360m

--- PASS: TestAccAmplify_serial (301.10s)
    --- PASS: TestAccAmplify_serial/App (301.10s)
        --- PASS: TestAccAmplify_serial/App/EnvironmentVariables (301.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/amplify    307.329s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/amplify Issues and PRs that pertain to the amplify service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 19, 2024
Previously existing `environment_variables` were removed by sending a map with an empty key/value pair. The `UpdateApp` API appears to have added restrictions around keys with empty values, so this approach began to fail the corresponding acceptance test. After reporting the issue to the AWS Go SDK V2, the new method for removing environment variables is to pass a key containing a single space character and an empty string value.

```console
% make testacc PKG=amplify TESTS=TestAccAmplify_serial/App/EnvironmentVariables
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/amplify/... -v -count 1 -parallel 20 -run='TestAccAmplify_serial/App/EnvironmentVariables'  -timeout 360m

--- PASS: TestAccAmplify_serial (301.10s)
    --- PASS: TestAccAmplify_serial/App (301.10s)
        --- PASS: TestAccAmplify_serial/App/EnvironmentVariables (301.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/amplify    307.329s
```
@jar-b jar-b added the bug Addresses a defect in current functionality. label Sep 19, 2024
@jar-b jar-b marked this pull request as ready for review September 19, 2024 14:55
@jar-b jar-b requested a review from a team as a code owner September 19, 2024 14:55
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit 8be8181 into main Sep 19, 2024
44 checks passed
@jar-b jar-b deleted the b-amplify-envvar branch September 19, 2024 17:12
@github-actions github-actions bot added this to the v5.68.0 milestone Sep 19, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Sep 19, 2024
Copy link

This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 20, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/amplify Issues and PRs that pertain to the amplify service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: r/aws_amplify_app: environment_variables cannot be unset once configured
2 participants