Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_sesv2_account_suppression_attributes: New resource #39325

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

ewbankkit
Copy link
Contributor

Description

Adds the aws_sesv2_account_suppression_attributes resource.

Relations

Closes #22655.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSESV2AccountSuppressionAttributes_serial' PKG=sesv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/sesv2/... -v -count 1 -parallel 20  -run=TestAccSESV2AccountSuppressionAttributes_serial -timeout 360m
=== RUN   TestAccSESV2AccountSuppressionAttributes_serial
=== PAUSE TestAccSESV2AccountSuppressionAttributes_serial
=== CONT  TestAccSESV2AccountSuppressionAttributes_serial
=== RUN   TestAccSESV2AccountSuppressionAttributes_serial/basic
=== RUN   TestAccSESV2AccountSuppressionAttributes_serial/update
--- PASS: TestAccSESV2AccountSuppressionAttributes_serial (38.54s)
    --- PASS: TestAccSESV2AccountSuppressionAttributes_serial/basic (17.75s)
    --- PASS: TestAccSESV2AccountSuppressionAttributes_serial/update (20.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	43.995s

@ewbankkit ewbankkit requested a review from a team as a code owner September 13, 2024 18:11
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sesv2 Issues and PRs that pertain to the sesv2 service. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 13, 2024
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Sep 13, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=sesv2 TESTS=TestAccSESV2AccountSuppressionAttributes_serial
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2AccountSuppressionAttributes_serial'  -timeout 360m
=== RUN   TestAccSESV2AccountSuppressionAttributes_serial
=== PAUSE TestAccSESV2AccountSuppressionAttributes_serial
=== CONT  TestAccSESV2AccountSuppressionAttributes_serial
=== RUN   TestAccSESV2AccountSuppressionAttributes_serial/basic
=== RUN   TestAccSESV2AccountSuppressionAttributes_serial/update
--- PASS: TestAccSESV2AccountSuppressionAttributes_serial (33.52s)
    --- PASS: TestAccSESV2AccountSuppressionAttributes_serial/basic (14.31s)
    --- PASS: TestAccSESV2AccountSuppressionAttributes_serial/update (19.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      39.748s

@ewbankkit ewbankkit merged commit 58d9fb8 into main Sep 16, 2024
41 checks passed
@ewbankkit ewbankkit deleted the f-aws_sesv2_account_suppression_attributes branch September 16, 2024 17:12
@github-actions github-actions bot added this to the v5.68.0 milestone Sep 16, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 20, 2024
Copy link

This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/sesv2 Issues and PRs that pertain to the sesv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SES account level suppression list support
2 participants