Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare agent after knowledge base association #38799

Merged

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Aug 9, 2024

Description

After associating a knowledge base we need to prepare the agent again before we can use it.

Relations

Closes #38660

Output from Acceptance Testing

% make testacc TESTS=TestAccBedrockAgentAgentKnowledgeBaseAssociation_ PKG=bedrockagent
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgentAgentKnowledgeBaseAssociation_'  -timeout 360m
=== RUN   TestAccBedrockAgentAgentKnowledgeBaseAssociation_basic
=== PAUSE TestAccBedrockAgentAgentKnowledgeBaseAssociation_basic
=== RUN   TestAccBedrockAgentAgentKnowledgeBaseAssociation_update
=== PAUSE TestAccBedrockAgentAgentKnowledgeBaseAssociation_update
=== RUN   TestAccBedrockAgentAgentKnowledgeBaseAssociation_disappears
=== PAUSE TestAccBedrockAgentAgentKnowledgeBaseAssociation_disappears
=== CONT  TestAccBedrockAgentAgentKnowledgeBaseAssociation_basic
=== CONT  TestAccBedrockAgentAgentKnowledgeBaseAssociation_disappears
=== CONT  TestAccBedrockAgentAgentKnowledgeBaseAssociation_update
--- PASS: TestAccBedrockAgentAgentKnowledgeBaseAssociation_basic (1521.07s)
--- PASS: TestAccBedrockAgentAgentKnowledgeBaseAssociation_disappears (1580.96s)
--- PASS: TestAccBedrockAgentAgentKnowledgeBaseAssociation_update (1642.55s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       1647.296s

Copy link

github-actions bot commented Aug 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Aug 9, 2024
@drewtul drewtul marked this pull request as ready for review August 9, 2024 15:51
@drewtul drewtul requested a review from a team as a code owner August 9, 2024 15:52
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Aug 9, 2024
@jar-b jar-b self-assigned this Aug 9, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 9, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=bedrockagent TESTS=TestAccBedrockAgentAgentKnowledgeBaseAssociation_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgentAgentKnowledgeBaseAssociation_'  -timeout 360m

--- PASS: TestAccBedrockAgentAgentKnowledgeBaseAssociation_basic (1425.55s)
--- PASS: TestAccBedrockAgentAgentKnowledgeBaseAssociation_disappears (1670.10s)
--- PASS: TestAccBedrockAgentAgentKnowledgeBaseAssociation_update (1772.30s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       1778.216s

@jar-b
Copy link
Member

jar-b commented Aug 9, 2024

Thanks for your contribution, @drewtul! 👍

@jar-b jar-b merged commit 3a6086c into hashicorp:main Aug 9, 2024
38 checks passed
@github-actions github-actions bot added this to the v5.63.0 milestone Aug 9, 2024
@drewtul drewtul deleted the bug-prepare-agent-after-kb-association branch August 9, 2024 20:44
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 15, 2024
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/bedrockagent Issues and PRs that pertain to the bedrockagent service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Bedrock agent association has no knowledgebase attached
2 participants