-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add domain validation options parameter to aws_acm_certificate #3851
Comments
I had the same problem so I made a pull request to fix this: #3853. |
The addition of validation options for validation method EMAIL would be very appreciated! |
No idea, not sure why this is getting ignored |
Okay, thanks for your response @scottwinkler . Looking through this ticket submission I noticed that @bflad (member of Terraform) added some tags like 27 days ago. I think your pull request to add this capability will hopefully not be ignored. |
For those people looking for a temporary workaround, I have open sourced a solution I developed for my company to solve this problem a few months ago. https://github.com/scottwinkler/terraform-acm-quick_certificate. You use is like the following:
you can get the arn of the certificate: |
The maintainers do not actively ignore PRs. Generally its based on 👍 upvotes on the original issue/PR comment or some other factors including whether its a bug/crash fix, which will take priority. #3853 as currently written will break backwards compatibility for a lot of people. It will need to be reworked if it is to get merged. |
Is there any update to this? This issue is affecting us as well. |
Same problem here! |
Same problem here. Still broken, it seems. |
+1 still missing the --domain-validation-options DomainName=www.domain.com,ValidationDomain=domain.com from CLI :/ |
work around for those who need this (only for email): Create ACM cert and Validate through emailresource "aws_acm_certificate" "main" { lifecycle { resource "aws_acm_certificate_validation" "main" { Force ACM to resend email correctly.resource "null_resource" "certificate" { |
I noticed that the acm resource has been redesigned in aws provider 3.0.0, but this still is not implemented. |
@bflad What's the status of resolving this issue? |
I noticed a lot of people chasing for updates on this, it's a shame nothing has progressed as we have just run into this exact same issue as well. @bflad should anyone be doing anything to get this moving? |
Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon! |
This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Terraform Version
Terraform v0.10.4
Affected Resource(s)
Terraform Configuration Files
Expected Behavior
The certificate is requested and email validations are sent out to the email adresses in whois and some generic adresses.
Actual Behavior
AWS sometimes uses the correct mail adresses from whois and derived from the second level domain, and sometimes only the mail adresses derived from the third level domain (e.g. "[email protected]" instead of something like "[email protected]"). This can vary between additional names for one certificate, so that some subdomains can be validated, others not.
This can be avoided by setting the ValidationDomain option for each DomainName to the second level domain. By doing this, all validation mails are sent to the domain owner configured in whois.
Steps to Reproduce
Important Factoids
I want to request a certificate for several subdomains, but I need to set the validation domain parameter.
See https://docs.aws.amazon.com/cli/latest/reference/acm/request-certificate.html and https://docs.aws.amazon.com/acm/latest/APIReference/API_DomainValidationOption.html
I have no control over the DNS for the domains, therefore I cannot use DNS validation or make whois entries.
I need to request these certificates and notify the domain owner so he can do the validations.
The text was updated successfully, but these errors were encountered: