Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_elasticache_replication_group: Validation fixes #38396

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Jul 17, 2024

Description

Fixes the following validations in aws_elasticache_replication_group:

Relations

Closes #38360
Closes #27116

References

Output from Acceptance Testing

% make testacc PKG=elasticache TESTS=TestAccElastiCacheReplicationGroup_

--- PASS: TestAccElastiCacheReplicationGroup_clusteringAndCacheNodesCausesError (5.53s)
--- PASS: TestAccElastiCacheReplicationGroup_autoFailoverEnabled_validateNumberCacheClusters (6.27s)
--- PASS: TestAccElastiCacheReplicationGroup_dataTiering (735.20s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzNotInVPC_repeated (822.25s)
--- PASS: TestAccElastiCacheReplicationGroup_cacheClustersConflictsWithReplicasPerNodeGroup (0.96s)
--- PASS: TestAccElastiCacheReplicationGroup_enableSnapshotting (858.28s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterModeValidation_numNodeGroupsOnSecondary (1124.16s)
--- PASS: TestAccElastiCacheReplicationGroup_basic (1271.39s)
--- PASS: TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Enabled (1410.62s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_noChange (1506.26s)
--- PASS: TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Disabled (1520.49s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic (1648.18s)
--- PASS: TestAccElastiCacheReplicationGroup_transitEncryptionWithAuthToken (1751.25s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_scaleDown (2370.56s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic (2423.89s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp (2436.61s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_atTargetSize (1720.09s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_multiAZEnabled (2536.15s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_addMemberCluster (1875.23s)
--- PASS: TestAccElastiCacheReplicationGroup_tags (1007.08s)
--- PASS: TestAccElastiCacheReplicationGroup_Validation_noNodeType (4.62s)
--- PASS: TestAccElastiCacheReplicationGroup_ValidationMultiAz_noAutomaticFailover (1.21s)
--- PASS: TestAccElastiCacheReplicationGroup_ipDiscovery (1131.08s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_autoFailoverEnabled (2927.24s)
--- PASS: TestAccElastiCacheReplicationGroup_transitEncryption5x (3139.08s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_disappears (3138.80s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_singleNode (2290.98s)
--- PASS: TestAccElastiCacheReplicationGroup_useCMKKMSKeyID (868.32s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_autoFailoverDisabled (3406.56s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown (1942.47s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_basic (1057.49s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_nonClusteredParameterGroup (1253.65s)
--- PASS: TestAccElastiCacheReplicationGroup_Validation_globalReplicationGroupIdAndNodeType (861.66s)
--- PASS: TestAccElastiCacheReplicationGroup_deprecatedAvailabilityZones_multiAzInVPC (1023.74s)
--- PASS: TestAccElastiCacheReplicationGroup_transitEncryption7x (3866.58s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzNotInVPC (956.40s)
--- PASS: TestAccElastiCacheReplicationGroup_networkType (1570.86s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp (2600.76s)
--- PASS: TestAccElastiCacheReplicationGroup_updateDescription (1071.46s)
--- PASS: TestAccElastiCacheReplicationGroup_stateUpgrade5270 (899.91s)
--- PASS: TestAccElastiCacheReplicationGroup_vpc (1205.83s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown (3275.59s)
--- PASS: TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade (815.62s)
--- PASS: TestAccElastiCacheReplicationGroup_updateUserGroups (1066.82s)
--- PASS: TestAccElastiCacheReplicationGroup_uppercase (744.38s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_full (3760.58s)
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion (1612.47s)
--- PASS: TestAccElastiCacheReplicationGroup_updateParameterGroup (1492.96s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup (3724.94s)
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_v7 (1056.64s)
--- PASS: TestAccElastiCacheReplicationGroup_finalSnapshot (1145.17s)
--- PASS: TestAccElastiCacheReplicationGroup_updateNodeSize (1696.52s)
--- PASS: TestAccElastiCacheReplicationGroup_authToken (2126.85s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzInVPC (1747.81s)
--- PASS: TestAccElastiCacheReplicationGroup_enableAtRestEncryption (1317.13s)
--- PASS: TestAccElastiCacheReplicationGroup_disappears (2373.47s)
--- PASS: TestAccElastiCacheReplicationGroup_updateMaintenanceWindow (3283.69s)
--- PASS: TestAccElastiCacheReplicationGroup_basic_v5 (1956.02s)
--- PASS: TestAccElastiCacheReplicationGroup_tagWithOtherModification (4229.08s)
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_update (8229.94s)

@gdavison gdavison requested a review from a team as a code owner July 17, 2024 17:15
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elasticache Issues and PRs that pertain to the elasticache service. size/M Managed by automation to categorize the size of a PR. labels Jul 17, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@gdavison gdavison force-pushed the b-elasticache-replicationgroup-replica-count-0 branch from 7d701be to 3f985ce Compare July 17, 2024 17:31
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccElastiCacheReplicationGroup_cacheClustersConflictsWithReplicasPerNodeGroup\|TestAccElastiCacheReplicationGroup_basic\|TestAccElastiCacheReplicationGroup_autoFailoverEnabled_validateNumberCacheClusters' PKG=elasticache ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/elasticache/... -v -count 1 -parallel 3  -run=TestAccElastiCacheReplicationGroup_cacheClustersConflictsWithReplicasPerNodeGroup\|TestAccElastiCacheReplicationGroup_basic\|TestAccElastiCacheReplicationGroup_autoFailoverEnabled_validateNumberCacheClusters -timeout 720m
=== RUN   TestAccElastiCacheReplicationGroup_basic
=== PAUSE TestAccElastiCacheReplicationGroup_basic
=== RUN   TestAccElastiCacheReplicationGroup_basic_v5
=== PAUSE TestAccElastiCacheReplicationGroup_basic_v5
=== RUN   TestAccElastiCacheReplicationGroup_cacheClustersConflictsWithReplicasPerNodeGroup
=== PAUSE TestAccElastiCacheReplicationGroup_cacheClustersConflictsWithReplicasPerNodeGroup
=== RUN   TestAccElastiCacheReplicationGroup_autoFailoverEnabled_validateNumberCacheClusters
=== PAUSE TestAccElastiCacheReplicationGroup_autoFailoverEnabled_validateNumberCacheClusters
=== CONT  TestAccElastiCacheReplicationGroup_basic
=== CONT  TestAccElastiCacheReplicationGroup_cacheClustersConflictsWithReplicasPerNodeGroup
=== CONT  TestAccElastiCacheReplicationGroup_basic_v5
--- PASS: TestAccElastiCacheReplicationGroup_cacheClustersConflictsWithReplicasPerNodeGroup (1.56s)
=== CONT  TestAccElastiCacheReplicationGroup_autoFailoverEnabled_validateNumberCacheClusters
--- PASS: TestAccElastiCacheReplicationGroup_autoFailoverEnabled_validateNumberCacheClusters (1.54s)
--- PASS: TestAccElastiCacheReplicationGroup_basic_v5 (723.32s)
--- PASS: TestAccElastiCacheReplicationGroup_basic (807.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	812.191s

@terraform-aws-provider terraform-aws-provider bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jul 17, 2024
@gdavison gdavison merged commit 5153fcf into main Jul 17, 2024
47 checks passed
@gdavison gdavison deleted the b-elasticache-replicationgroup-replica-count-0 branch July 17, 2024 23:22
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 17, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Jul 17, 2024
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants