Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: add unhealthy draining interval attribute in aws_lb_target_group #38393

Closed
antonincms opened this issue Jul 17, 2024 · 6 comments · Fixed by #38654
Closed

[Enhancement]: add unhealthy draining interval attribute in aws_lb_target_group #38393

antonincms opened this issue Jul 17, 2024 · 6 comments · Fixed by #38654
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Milestone

Comments

@antonincms
Copy link

antonincms commented Jul 17, 2024

Description

Currently in an aws_lb_target_group resource, it is possible to specify whether AWS should terminate unhealthy connections by setting in the block target_health_state the variable enable_unhealthy_connection_termination.

It would be interesting to also expose the corresponding target_health_state.unhealthy.draining_interval_seconds attribute (probably in the same block as unhealthy_draining_interval) to allow specifying how long AWS should wait for in-flight requests to complete when a target becomes unhealthy.

Affected Resource(s) and/or Data Source(s)

  • aws_lb_target_group

Potential Terraform Configuration

resource "aws_lb_target_group" "rtmp" {
  // [...]

  target_health_state {
    enable_unhealthy_connection_termination = true
    unhealthy_draining_interval = "3600"
  }
}

References

Would you like to implement a fix?

None

@antonincms antonincms added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 17, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/elbv2 Issues and PRs that pertain to the elbv2 service. label Jul 17, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 17, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jul 17, 2024
@Siddarthyuvaraj
Copy link
Contributor

I will work on this and raise a PR later

@Siddarthyuvaraj
Copy link
Contributor

Siddarthyuvaraj commented Aug 1, 2024

PR has been created
#38654

Copy link

github-actions bot commented Aug 2, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.62.0 milestone Aug 2, 2024
Copy link

github-actions bot commented Aug 9, 2024

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Sep 9, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Projects
None yet
3 participants