Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_backup_plan: add rule attribute to data source #37890

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

nikhil-goenka
Copy link
Contributor

Description

Relations

Closes #28228

References

Output from Acceptance Testing

% make testacc TESTS=TestAccBackupPlanDataSource_basic PKG=backup
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/backup/... -v -count 1 -parallel 20 -run='TestAccBackupPlanDataSource_basic'  -timeout 360m
=== RUN   TestAccBackupPlanDataSource_basic
=== PAUSE TestAccBackupPlanDataSource_basic
=== CONT  TestAccBackupPlanDataSource_basic
--- PASS: TestAccBackupPlanDataSource_basic (23.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	44.531s

...

Copy link

github-actions bot commented Jun 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/backup Issues and PRs that pertain to the backup service. labels Jun 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 8, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 11, 2024
@johnsonaj johnsonaj requested a review from a team as a code owner July 2, 2024 16:54
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTS=TestAccBackupPlanDataSource_basic PKG=backup

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/backup/... -v -count 1 -parallel 20 -run='TestAccBackupPlanDataSource_basic'  -timeout 360m
=== RUN   TestAccBackupPlanDataSource_basic
=== PAUSE TestAccBackupPlanDataSource_basic
=== CONT  TestAccBackupPlanDataSource_basic
--- PASS: TestAccBackupPlanDataSource_basic (12.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	18.516s

@johnsonaj johnsonaj changed the title aws_backup_plan r/aws_backup_plan: add rule attribute to data source Jul 2, 2024
@johnsonaj
Copy link
Contributor

@nikhil-goenka thank you for the contribution! 🎉

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jul 2, 2024
@johnsonaj johnsonaj merged commit eecc7c9 into hashicorp:main Jul 2, 2024
53 checks passed
@github-actions github-actions bot added this to the v5.57.0 milestone Jul 2, 2024
Copy link

github-actions bot commented Jul 5, 2024

This functionality has been released in v5.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@nikhil-goenka nikhil-goenka deleted the d/aws_backup_plan branch July 16, 2024 16:59
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/backup Issues and PRs that pertain to the backup service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for Rules in data resource aws_backup_plan
3 participants