Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate transfer resources to AWS Go SDKv2 #37548

Merged
merged 31 commits into from
Jun 5, 2024
Merged

Migrate transfer resources to AWS Go SDKv2 #37548

merged 31 commits into from
Jun 5, 2024

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented May 15, 2024 •
edited
Loading

Description

This PR migrates the transfer resources to AWS SDKv2.

Relations

Closes #36216

References

Output from Acceptance Testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial -timeout 360m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Agreement
=== RUN   TestAccTransfer_serial/Agreement/basic
=== RUN   TestAccTransfer_serial/Agreement/disappears
=== RUN   TestAccTransfer_serial/Agreement/tags
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/SecurityPolicy
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCToPublic
=== RUN   TestAccTransfer_serial/Server/DataSourceBasic
=== RUN   TestAccTransfer_serial/Server/ForceDestroy
=== RUN   TestAccTransfer_serial/Server/LambdaFunction
=== RUN   TestAccTransfer_serial/Server/ProtocolDetails
=== RUN   TestAccTransfer_serial/Server/SecurityPolicyFIPS
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPC
=== RUN   TestAccTransfer_serial/Server/VPC
=== RUN   TestAccTransfer_serial/Server/VPCEndpointID
=== RUN   TestAccTransfer_serial/Server/APIGatewayForceDestroy
=== RUN   TestAccTransfer_serial/Server/DataSourceServiceManaged
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/Workflow
=== RUN   TestAccTransfer_serial/Server/disappears
=== RUN   TestAccTransfer_serial/Server/AuthenticationLoginBanners
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC
=== RUN   TestAccTransfer_serial/Server/StructuredLogDestinations
=== RUN   TestAccTransfer_serial/Server/Protocols
=== RUN   TestAccTransfer_serial/Server/SftpAuthenticationMethods
=== RUN   TestAccTransfer_serial/Server/S3StorageOptions
=== RUN   TestAccTransfer_serial/Server/UpdateSftpAuthenticationMethods
=== RUN   TestAccTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/VPCSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/tags
=== RUN   TestAccTransfer_serial/Server/HostKey
=== RUN   TestAccTransfer_serial/Server/DataSourceAPIGateway
=== RUN   TestAccTransfer_serial/Server/DirectoryService
=== RUN   TestAccTransfer_serial/Server/Domain
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/VPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/basic
=== RUN   TestAccTransfer_serial/Server/APIGateway
=== RUN   TestAccTransfer_serial/SSHKey
=== RUN   TestAccTransfer_serial/SSHKey/basic
=== RUN   TestAccTransfer_serial/Tag
=== RUN   TestAccTransfer_serial/Tag/Value
=== RUN   TestAccTransfer_serial/Tag/System
=== RUN   TestAccTransfer_serial/Tag/basic
=== RUN   TestAccTransfer_serial/Tag/disappears
=== RUN   TestAccTransfer_serial/User
=== RUN   TestAccTransfer_serial/User/basic
=== RUN   TestAccTransfer_serial/User/disappears
=== RUN   TestAccTransfer_serial/User/tags
=== RUN   TestAccTransfer_serial/User/HomeDirectoryMappings
=== RUN   TestAccTransfer_serial/User/ModifyWithOptions
=== RUN   TestAccTransfer_serial/User/Posix
=== RUN   TestAccTransfer_serial/User/UserNameValidation
=== RUN   TestAccTransfer_serial/Access
=== RUN   TestAccTransfer_serial/Access/disappears
=== RUN   TestAccTransfer_serial/Access/EFSBasic
=== RUN   TestAccTransfer_serial/Access/S3Basic
=== RUN   TestAccTransfer_serial/Access/S3Policy
--- PASS: TestAccTransfer_serial (14378.13s)
    --- PASS: TestAccTransfer_serial/Agreement (633.41s)
        --- PASS: TestAccTransfer_serial/Agreement/basic (250.73s)
        --- PASS: TestAccTransfer_serial/Agreement/disappears (193.58s)
        --- PASS: TestAccTransfer_serial/Agreement/tags (189.09s)
    --- PASS: TestAccTransfer_serial/Server (7584.95s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicy (246.91s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs (213.97s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCToPublic (228.87s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceBasic (191.90s)
        --- PASS: TestAccTransfer_serial/Server/ForceDestroy (197.41s)
        --- PASS: TestAccTransfer_serial/Server/LambdaFunction (216.58s)
        --- PASS: TestAccTransfer_serial/Server/ProtocolDetails (165.26s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicyFIPS (205.35s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPC (297.47s)
        --- PASS: TestAccTransfer_serial/Server/VPC (141.85s)
        --- PASS: TestAccTransfer_serial/Server/VPCEndpointID (75.60s)
        --- PASS: TestAccTransfer_serial/Server/APIGatewayForceDestroy (170.99s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceServiceManaged (194.32s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs (104.57s)
        --- PASS: TestAccTransfer_serial/Server/Workflow (341.31s)
        --- PASS: TestAccTransfer_serial/Server/disappears (183.19s)
        --- PASS: TestAccTransfer_serial/Server/AuthenticationLoginBanners (195.13s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC (75.85s)
        --- PASS: TestAccTransfer_serial/Server/StructuredLogDestinations (210.05s)
        --- PASS: TestAccTransfer_serial/Server/Protocols (231.21s)
        --- PASS: TestAccTransfer_serial/Server/SftpAuthenticationMethods (201.98s)
        --- PASS: TestAccTransfer_serial/Server/S3StorageOptions (209.01s)
        --- PASS: TestAccTransfer_serial/Server/UpdateSftpAuthenticationMethods (185.92s)
        --- PASS: TestAccTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs (221.12s)
        --- PASS: TestAccTransfer_serial/Server/VPCSecurityGroupIDs (65.81s)
        --- PASS: TestAccTransfer_serial/Server/tags (185.11s)
        --- PASS: TestAccTransfer_serial/Server/HostKey (163.72s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceAPIGateway (196.56s)
        --- PASS: TestAccTransfer_serial/Server/DirectoryService (956.11s)
        --- PASS: TestAccTransfer_serial/Server/Domain (195.42s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs (414.71s)
        --- PASS: TestAccTransfer_serial/Server/VPCAddressAllocationIDs (290.04s)
        --- PASS: TestAccTransfer_serial/Server/basic (207.72s)
        --- PASS: TestAccTransfer_serial/Server/APIGateway (203.91s)
    --- PASS: TestAccTransfer_serial/SSHKey (167.35s)
        --- PASS: TestAccTransfer_serial/SSHKey/basic (167.35s)
    --- PASS: TestAccTransfer_serial/Tag (782.45s)
        --- PASS: TestAccTransfer_serial/Tag/Value (206.42s)
        --- PASS: TestAccTransfer_serial/Tag/System (187.01s)
        --- PASS: TestAccTransfer_serial/Tag/basic (195.72s)
        --- PASS: TestAccTransfer_serial/Tag/disappears (193.30s)
    --- PASS: TestAccTransfer_serial/User (1210.37s)
        --- PASS: TestAccTransfer_serial/User/basic (166.56s)
        --- PASS: TestAccTransfer_serial/User/disappears (193.59s)
        --- PASS: TestAccTransfer_serial/User/tags (219.60s)
        --- PASS: TestAccTransfer_serial/User/HomeDirectoryMappings (220.31s)
        --- PASS: TestAccTransfer_serial/User/ModifyWithOptions (218.69s)
        --- PASS: TestAccTransfer_serial/User/Posix (177.51s)
        --- PASS: TestAccTransfer_serial/User/UserNameValidation (14.11s)
    --- PASS: TestAccTransfer_serial/Access (3999.60s)
        --- PASS: TestAccTransfer_serial/Access/disappears (966.53s)
        --- PASS: TestAccTransfer_serial/Access/EFSBasic (1149.75s)
        --- PASS: TestAccTransfer_serial/Access/S3Basic (937.55s)
        --- PASS: TestAccTransfer_serial/Access/S3Policy (945.78s)
PASS
ok	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	14382.252s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/transfer Issues and PRs that pertain to the transfer service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. flex Pertains to FLatteners and EXpanders. generators Relates to code generators. labels May 15, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 15, 2024
@ewbankkit ewbankkit added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label May 15, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label May 16, 2024
@ewbankkit ewbankkit self-assigned this May 22, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 22, 2024
@aristosvo aristosvo mentioned this pull request May 28, 2024
Closed
ewbankkit added 13 commits June 4, 2024 11:16
@ewbankkit
r/aws_transfer_ssh_key: Reduce visibility.
80a7f65
@ewbankkit
r/aws_transfer_server: Reduce visibility.
2cfd8b1
@ewbankkit
r/aws_transfer_user: Reduce visibility.
591cdd3
@ewbankkit
r/aws_transfer_workflow: Reduce visibility.
3738713
@ewbankkit
transfer: Fix semgrep errors.
3a236d2
@ewbankkit
transfer: Tidy up sweepers.
30c99d7
@ewbankkit
Merge branch 'main' into HEAD
a41b5b5
@ewbankkit
r/aws_transfer_connector: Fix acceptance test names.
663bd55
@ewbankkit
r/aws_transfer_ssh_key: Set 'ssh_key_id' on Create.
f78795e
@ewbankkit
Add 'testAccSSHKey_disappears'.
7c70a3e 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccTransfer_serial/SSHKey/disappears' PKG=transfer
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial/SSHKey/disappears -timeout 360m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/SSHKey
=== RUN   TestAccTransfer_serial/SSHKey/disappears
--- PASS: TestAccTransfer_serial (157.37s)
    --- PASS: TestAccTransfer_serial/SSHKey (157.37s)
        --- PASS: TestAccTransfer_serial/SSHKey/disappears (157.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	161.703s
@ewbankkit
transfer: Correct tagging code generation.
8ed772b
@ewbankkit
Merge branch 'main' into HEAD
d1e76d9 
# Conflicts:
#	internal/service/ec2/exports.go
#	internal/service/ec2/vpc_endpoint.go
@ewbankkit
Fix 'TestAccTransferWorkflow_allSteps'.
8cc5526
ewbankkit
ewbankkit approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccTransfer_serial' PKG=transfer
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial -timeout 720m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Access
=== RUN   TestAccTransfer_serial/Access/disappears
=== RUN   TestAccTransfer_serial/Access/EFSBasic
=== RUN   TestAccTransfer_serial/Access/S3Basic
=== RUN   TestAccTransfer_serial/Access/S3Policy
=== RUN   TestAccTransfer_serial/Agreement
=== RUN   TestAccTransfer_serial/Agreement/basic
=== RUN   TestAccTransfer_serial/Agreement/disappears
=== RUN   TestAccTransfer_serial/Agreement/tags
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/LambdaFunction
=== RUN   TestAccTransfer_serial/Server/Protocols
=== RUN   TestAccTransfer_serial/Server/ProtocolDetails
=== RUN   TestAccTransfer_serial/Server/SecurityPolicy
=== RUN   TestAccTransfer_serial/Server/Workflow
=== RUN   TestAccTransfer_serial/Server/ForceDestroy
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/APIGatewayForceDestroy
=== RUN   TestAccTransfer_serial/Server/DataSourceAPIGateway
=== RUN   TestAccTransfer_serial/Server/DirectoryService
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC
=== RUN   TestAccTransfer_serial/Server/APIGateway
=== RUN   TestAccTransfer_serial/Server/DataSourceBasic
=== RUN   TestAccTransfer_serial/Server/Domain
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPC
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/disappears
=== RUN   TestAccTransfer_serial/Server/SecurityPolicyFIPS
=== RUN   TestAccTransfer_serial/Server/VPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/tags
=== RUN   TestAccTransfer_serial/Server/DataSourceServiceManaged
=== RUN   TestAccTransfer_serial/Server/HostKey
=== RUN   TestAccTransfer_serial/Server/S3StorageOptions
=== RUN   TestAccTransfer_serial/Server/SftpAuthenticationMethods
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCToPublic
=== RUN   TestAccTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/AuthenticationLoginBanners
=== RUN   TestAccTransfer_serial/Server/VPCEndpointID
=== RUN   TestAccTransfer_serial/Server/UpdateSftpAuthenticationMethods
=== RUN   TestAccTransfer_serial/Server/StructuredLogDestinations
=== RUN   TestAccTransfer_serial/Server/VPC
=== RUN   TestAccTransfer_serial/Server/VPCSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/basic
=== RUN   TestAccTransfer_serial/SSHKey
=== RUN   TestAccTransfer_serial/SSHKey/basic
=== RUN   TestAccTransfer_serial/Tag
=== RUN   TestAccTransfer_serial/Tag/Value
=== RUN   TestAccTransfer_serial/Tag/System
=== RUN   TestAccTransfer_serial/Tag/basic
=== RUN   TestAccTransfer_serial/Tag/disappears
=== RUN   TestAccTransfer_serial/User
=== RUN   TestAccTransfer_serial/User/Posix
=== RUN   TestAccTransfer_serial/User/UserNameValidation
=== RUN   TestAccTransfer_serial/User/basic
=== RUN   TestAccTransfer_serial/User/disappears
=== RUN   TestAccTransfer_serial/User/tags
=== RUN   TestAccTransfer_serial/User/HomeDirectoryMappings
=== RUN   TestAccTransfer_serial/User/ModifyWithOptions
--- PASS: TestAccTransfer_serial (12534.59s)
    --- PASS: TestAccTransfer_serial/Access (3315.31s)
        --- PASS: TestAccTransfer_serial/Access/disappears (782.78s)
        --- PASS: TestAccTransfer_serial/Access/EFSBasic (853.35s)
        --- PASS: TestAccTransfer_serial/Access/S3Basic (842.40s)
        --- PASS: TestAccTransfer_serial/Access/S3Policy (836.77s)
    --- PASS: TestAccTransfer_serial/Agreement (545.15s)
        --- PASS: TestAccTransfer_serial/Agreement/basic (165.71s)
        --- PASS: TestAccTransfer_serial/Agreement/disappears (187.10s)
        --- PASS: TestAccTransfer_serial/Agreement/tags (173.98s)
    --- PASS: TestAccTransfer_serial/Server (6627.91s)
        --- PASS: TestAccTransfer_serial/Server/LambdaFunction (207.89s)
        --- PASS: TestAccTransfer_serial/Server/Protocols (212.55s)
        --- PASS: TestAccTransfer_serial/Server/ProtocolDetails (195.40s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicy (224.33s)
        --- PASS: TestAccTransfer_serial/Server/Workflow (204.09s)
        --- PASS: TestAccTransfer_serial/Server/ForceDestroy (190.58s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs (437.17s)
        --- PASS: TestAccTransfer_serial/Server/APIGatewayForceDestroy (192.84s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceAPIGateway (189.54s)
        --- PASS: TestAccTransfer_serial/Server/DirectoryService (827.60s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC (101.68s)
        --- PASS: TestAccTransfer_serial/Server/APIGateway (162.14s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceBasic (186.21s)
        --- PASS: TestAccTransfer_serial/Server/Domain (187.55s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPC (281.76s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs (200.06s)
        --- PASS: TestAccTransfer_serial/Server/disappears (186.34s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicyFIPS (195.09s)
        --- PASS: TestAccTransfer_serial/Server/VPCAddressAllocationIDs (254.84s)
        --- PASS: TestAccTransfer_serial/Server/tags (201.93s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceServiceManaged (187.89s)
        --- PASS: TestAccTransfer_serial/Server/HostKey (157.95s)
        --- PASS: TestAccTransfer_serial/Server/S3StorageOptions (198.20s)
        --- PASS: TestAccTransfer_serial/Server/SftpAuthenticationMethods (194.13s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs (80.43s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCToPublic (216.67s)
        --- PASS: TestAccTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs (185.31s)
        --- PASS: TestAccTransfer_serial/Server/AuthenticationLoginBanners (188.97s)
        --- PASS: TestAccTransfer_serial/Server/VPCEndpointID (60.40s)
        --- PASS: TestAccTransfer_serial/Server/UpdateSftpAuthenticationMethods (205.44s)
        --- PASS: TestAccTransfer_serial/Server/StructuredLogDestinations (199.33s)
        --- PASS: TestAccTransfer_serial/Server/VPC (128.26s)
        --- PASS: TestAccTransfer_serial/Server/VPCSecurityGroupIDs (52.61s)
        --- PASS: TestAccTransfer_serial/Server/basic (198.51s)
    --- PASS: TestAccTransfer_serial/SSHKey (188.97s)
        --- PASS: TestAccTransfer_serial/SSHKey/basic (188.97s)
    --- PASS: TestAccTransfer_serial/Tag (760.76s)
        --- PASS: TestAccTransfer_serial/Tag/Value (196.57s)
        --- PASS: TestAccTransfer_serial/Tag/System (188.55s)
        --- PASS: TestAccTransfer_serial/Tag/basic (188.37s)
        --- PASS: TestAccTransfer_serial/Tag/disappears (187.27s)
    --- PASS: TestAccTransfer_serial/User (1101.93s)
        --- PASS: TestAccTransfer_serial/User/Posix (166.96s)
        --- PASS: TestAccTransfer_serial/User/UserNameValidation (10.74s)
        --- PASS: TestAccTransfer_serial/User/basic (188.97s)
        --- PASS: TestAccTransfer_serial/User/disappears (157.55s)
        --- PASS: TestAccTransfer_serial/User/tags (203.54s)
        --- PASS: TestAccTransfer_serial/User/HomeDirectoryMappings (218.09s)
        --- PASS: TestAccTransfer_serial/User/ModifyWithOptions (201.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	12539.143s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccTransferCertificate_\|TestAccTransferConnector_\|TestAccTransferProfile_\|TestAccTransferWorkflow_' PKG=transfer ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/transfer/... -v -count 1 -parallel 4  -run=TestAccTransferCertificate_\|TestAccTransferConnector_\|TestAccTransferProfile_\|TestAccTransferWorkflow_ -timeout 720m
=== RUN   TestAccTransferCertificate_basic
=== PAUSE TestAccTransferCertificate_basic
=== RUN   TestAccTransferCertificate_certificate
=== PAUSE TestAccTransferCertificate_certificate
=== RUN   TestAccTransferCertificate_certificateChain
=== PAUSE TestAccTransferCertificate_certificateChain
=== RUN   TestAccTransferCertificate_certificateKey
=== PAUSE TestAccTransferCertificate_certificateKey
=== RUN   TestAccTransferCertificate_disappears
=== PAUSE TestAccTransferCertificate_disappears
=== RUN   TestAccTransferCertificate_tags
=== PAUSE TestAccTransferCertificate_tags
=== RUN   TestAccTransferCertificate_description
=== PAUSE TestAccTransferCertificate_description
=== RUN   TestAccTransferConnector_basic
--- PASS: TestAccTransferConnector_basic (25.23s)
=== RUN   TestAccTransferConnector_sftpConfig
--- PASS: TestAccTransferConnector_sftpConfig (14.84s)
=== RUN   TestAccTransferConnector_securityPolicyName
--- PASS: TestAccTransferConnector_securityPolicyName (17.73s)
=== RUN   TestAccTransferConnector_disappears
--- PASS: TestAccTransferConnector_disappears (10.67s)
=== RUN   TestAccTransferConnector_tags
--- PASS: TestAccTransferConnector_tags (27.57s)
=== RUN   TestAccTransferProfile_basic
=== PAUSE TestAccTransferProfile_basic
=== RUN   TestAccTransferProfile_certificateIDs
=== PAUSE TestAccTransferProfile_certificateIDs
=== RUN   TestAccTransferProfile_disappears
=== PAUSE TestAccTransferProfile_disappears
=== RUN   TestAccTransferProfile_tags
=== PAUSE TestAccTransferProfile_tags
=== RUN   TestAccTransferWorkflow_basic
--- PASS: TestAccTransferWorkflow_basic (11.65s)
=== RUN   TestAccTransferWorkflow_onExceptionSteps
--- PASS: TestAccTransferWorkflow_onExceptionSteps (11.69s)
=== RUN   TestAccTransferWorkflow_description
--- PASS: TestAccTransferWorkflow_description (11.89s)
=== RUN   TestAccTransferWorkflow_tags
--- PASS: TestAccTransferWorkflow_tags (26.28s)
=== RUN   TestAccTransferWorkflow_disappears
--- PASS: TestAccTransferWorkflow_disappears (10.00s)
=== RUN   TestAccTransferWorkflow_allSteps
--- PASS: TestAccTransferWorkflow_allSteps (40.80s)
=== CONT  TestAccTransferCertificate_basic
=== CONT  TestAccTransferProfile_certificateIDs
=== CONT  TestAccTransferProfile_tags
=== CONT  TestAccTransferCertificate_disappears
--- PASS: TestAccTransferCertificate_disappears (10.65s)
=== CONT  TestAccTransferCertificate_description
--- PASS: TestAccTransferCertificate_basic (12.81s)
=== CONT  TestAccTransferProfile_basic
--- PASS: TestAccTransferProfile_certificateIDs (13.08s)
=== CONT  TestAccTransferCertificate_certificateChain
--- PASS: TestAccTransferProfile_basic (12.21s)
=== CONT  TestAccTransferCertificate_certificateKey
--- PASS: TestAccTransferCertificate_certificateChain (12.23s)
=== CONT  TestAccTransferProfile_disappears
--- PASS: TestAccTransferProfile_tags (27.46s)
=== CONT  TestAccTransferCertificate_tags
--- PASS: TestAccTransferCertificate_description (19.51s)
=== CONT  TestAccTransferCertificate_certificate
--- PASS: TestAccTransferProfile_disappears (10.19s)
--- PASS: TestAccTransferCertificate_certificateKey (12.06s)
--- PASS: TestAccTransferCertificate_certificate (11.95s)
--- PASS: TestAccTransferCertificate_tags (26.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	257.974s

@ewbankkit ewbankkit merged commit e5b4b69 into hashicorp:main Jun 5, 2024
38 checks passed
@github-actions github-actions bot added this to the v5.53.0 milestone Jun 5, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

This functionality has been released in v5.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. flex Pertains to FLatteners and EXpanders. generators Relates to code generators. service/transfer Issues and PRs that pertain to the transfer service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.53.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Transfer Family Service
3 participants
@DanielRieske @ewbankkit @justinretzolk