-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the data source for a Slack Workspace #37218
Added the data source for a Slack Workspace #37218
Conversation
Community NoteVoting for Prioritization
For Submitters
|
c2b9fbe
to
a3d45a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! LGTM 🎉
data.SlackTeamID = flex.StringToFramework(ctx, out.SlackTeamId) | ||
data.SlackTeamName = flex.StringToFramework(ctx, out.SlackTeamName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data.SlackTeamID = flex.StringToFramework(ctx, out.SlackTeamId) | |
data.SlackTeamName = flex.StringToFramework(ctx, out.SlackTeamName) | |
resp.Diagnostics.Append(flex.Flatten(ctx, out, &data)...) |
Since I can't readily test this, I won't make this change. However, I would encourage you to try it and, if it works, submit a PR to update this later. This simplifies code and should help make things more future proof. If it doesn't work, let us know so we can work on a fix.
This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Added a new data source Slack Workspace for the service AWS Chatbot
Relations
Relates #12304
or
Closes #37123
References
https://awscli.amazonaws.com/v2/documentation/api/latest/reference/chatbot/delete-slack-workspace-authorization.html
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/chatbot#Client.DescribeSlackWorkspaces
Output from Acceptance Testing