Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_devopsguru_notification_channel: new data source #36656

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Mar 29, 2024

Description

This data source will allow practitioners to read AWS DevOps Guru notification channel data with Terraform.

Relations

References

Output from Acceptance Testing

% make testacc PKG=devopsguru TESTS=TestAccDevOpsGuru_serial/NotificationChannelDataSource/
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/devopsguru/... -v -count 1 -parallel 20 -run='TestAccDevOpsGuru_serial/NotificationChannelDataSource/'  -timeout 360m
=== RUN   TestAccDevOpsGuru_serial
=== PAUSE TestAccDevOpsGuru_serial
=== CONT  TestAccDevOpsGuru_serial
=== RUN   TestAccDevOpsGuru_serial/NotificationChannelDataSource
=== RUN   TestAccDevOpsGuru_serial/NotificationChannelDataSource/basic
--- PASS: TestAccDevOpsGuru_serial (12.09s)
    --- PASS: TestAccDevOpsGuru_serial/NotificationChannelDataSource (12.09s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannelDataSource/basic (12.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/devopsguru 17.651s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/devopsguru Issues and PRs that pertain to the devopsguru service. labels Mar 29, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 29, 2024
This data source will allow practitioners to read AWS DevOps Guru notification channel data with Terraform.

```console
% make testacc PKG=devopsguru TESTS=TestAccDevOpsGuru_serial/NotificationChannelDataSource/
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/devopsguru/... -v -count 1 -parallel 20 -run='TestAccDevOpsGuru_serial/NotificationChannelDataSource/'  -timeout 360m
=== RUN   TestAccDevOpsGuru_serial
=== PAUSE TestAccDevOpsGuru_serial
=== CONT  TestAccDevOpsGuru_serial
=== RUN   TestAccDevOpsGuru_serial/NotificationChannelDataSource
=== RUN   TestAccDevOpsGuru_serial/NotificationChannelDataSource/basic
--- PASS: TestAccDevOpsGuru_serial (12.09s)
    --- PASS: TestAccDevOpsGuru_serial/NotificationChannelDataSource (12.09s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannelDataSource/basic (12.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/devopsguru 17.651s
```
@jar-b jar-b force-pushed the f-devopsguru_notification_channel-ds branch from c91f613 to 67026cf Compare March 29, 2024 18:17
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDevOpsGuru_serial/NotificationChannelDataSource' PKG=devopsguru
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/devopsguru/... -v -count 1 -parallel 20  -run=TestAccDevOpsGuru_serial/NotificationChannelDataSource -timeout 360m
=== RUN   TestAccDevOpsGuru_serial
=== PAUSE TestAccDevOpsGuru_serial
=== CONT  TestAccDevOpsGuru_serial
=== RUN   TestAccDevOpsGuru_serial/NotificationChannelDataSource
=== RUN   TestAccDevOpsGuru_serial/NotificationChannelDataSource/basic
--- PASS: TestAccDevOpsGuru_serial (18.25s)
    --- PASS: TestAccDevOpsGuru_serial/NotificationChannelDataSource (18.25s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannelDataSource/basic (18.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/devopsguru	29.208s

@jar-b jar-b merged commit 591d177 into main Mar 29, 2024
44 checks passed
@jar-b jar-b deleted the f-devopsguru_notification_channel-ds branch March 29, 2024 20:25
@github-actions github-actions bot added this to the v5.44.0 milestone Mar 29, 2024
github-actions bot pushed a commit that referenced this pull request Mar 29, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented May 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/devopsguru Issues and PRs that pertain to the devopsguru service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: aws_devopsguru_notification_channels
2 participants