Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add UpgradeStorageConfig to CreateDBInstanceReadReplica #36617

Closed
bruno opened this issue Mar 27, 2024 · 5 comments · Fixed by #36904
Closed

[Enhancement]: Add UpgradeStorageConfig to CreateDBInstanceReadReplica #36617

bruno opened this issue Mar 27, 2024 · 5 comments · Fixed by #36904
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@bruno
Copy link

bruno commented Mar 27, 2024

Description

In the aws-sdk-go-v2 there's the UpgradeStorageConfig boolean attribute that controls if, when creating a read-replica, one wants the filesystem on the instance to be upgraded to the newer version. That attribute does not appear to be yet supported in the AWS provider for RDS.

Affected Resource(s) and/or Data Source(s)

  • aws_db_instance

Potential Terraform Configuration

resource "aws_db_instance" "primary" {
  allocated_storage    = 10
  db_name              = "example-primary"
  engine               = "postgres"
  engine_version       = "16"
  instance_class       = "db.t3.micro"
  username             = "foo"
  password             = var.db_password
  parameter_group_name = var.parameter_group_name
  skip_final_snapshot  = true
}

resource "aws_db_instance" "replica" {
  count                         = var.replica_count
  allocated_storage             = 10
  db_name                       = "example-replica"
  engine                        = "postgres"
  engine_version                = "16"
  instance_class                = "db.t3.micro"
  username                      = "foo"
  password                      = var.db_password
  parameter_group_name          = var.parameter_group_name
  skip_final_snapshot           = true
  upgrade_storage_config        = true
  source_db_instance_identifier = aws_db_instance.primary.id
}

References

AWS SDK Go v2: https://github.com/aws/aws-sdk-go-v2/blob/5a6b2c00c974396bf1d726e1a7acb3312a34c1e7/service/rds/api_op_CreateDBInstanceReadReplica.go#L429

Would you like to implement a fix?

None

@bruno bruno added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 27, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/rds Issues and PRs that pertain to the rds service. label Mar 27, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 27, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Apr 1, 2024
@justinretzolk
Copy link
Member

Related #36200

Copy link

github-actions bot commented Aug 1, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.61.0 milestone Aug 1, 2024
Copy link

github-actions bot commented Aug 2, 2024

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Sep 1, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants