-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tier
argument to aws_vpc_ipam
resource
#36504
Add tier
argument to aws_vpc_ipam
resource
#36504
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening this PR! A few small requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read function should include a
d.Set("tier", ipam.Tier)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thanks for your contribution @mmourick 👏🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccIPAM_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccIPAM_ -timeout 360m
=== RUN TestAccIPAM_byoipIPv6
ipam_byoip_test.go:26: Environment variable IPAM_BYOIP_IPV6_MESSAGE, IPAM_BYOIP_IPV6_SIGNATURE, or IPAM_BYOIP_IPV6_PROVISIONED_CIDR is not set
--- SKIP: TestAccIPAM_byoipIPv6 (0.00s)
=== RUN TestAccIPAM_basic
=== PAUSE TestAccIPAM_basic
=== RUN TestAccIPAM_disappears
=== PAUSE TestAccIPAM_disappears
=== RUN TestAccIPAM_description
=== PAUSE TestAccIPAM_description
=== RUN TestAccIPAM_operatingRegions
=== PAUSE TestAccIPAM_operatingRegions
=== RUN TestAccIPAM_cascade
=== PAUSE TestAccIPAM_cascade
=== RUN TestAccIPAM_tier
=== PAUSE TestAccIPAM_tier
=== RUN TestAccIPAM_tags
=== PAUSE TestAccIPAM_tags
=== CONT TestAccIPAM_basic
=== CONT TestAccIPAM_tags
--- PASS: TestAccIPAM_basic (48.47s)
=== CONT TestAccIPAM_description
--- PASS: TestAccIPAM_tags (77.43s)
=== CONT TestAccIPAM_operatingRegions
--- PASS: TestAccIPAM_description (57.67s)
=== CONT TestAccIPAM_tier
--- PASS: TestAccIPAM_operatingRegions (109.37s)
=== CONT TestAccIPAM_disappears
--- PASS: TestAccIPAM_tier (80.92s)
=== CONT TestAccIPAM_cascade
--- PASS: TestAccIPAM_disappears (41.27s)
--- PASS: TestAccIPAM_cascade (66.46s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 257.318s
@mmourick Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds the
tier
argument to theaws_vpc_ipam
resource.Relations
Closes #34616.
Relates #35747.
References
Output from Acceptance Testing