-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add attributes for manage password to aws redshiftserverless namespace #35965
feat: add attributes for manage password to aws redshiftserverless namespace #35965
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @noel-phelt 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
This reverts commit d44e350.
…redshiftserverless_namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=redshiftserverless TESTS="TestAccRedshiftServerlessNamespace_|TestAccRedshiftServerlessNamespaceDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftserverless/... -v -count 1 -parallel 20 -run='TestAccRedshiftServerlessNamespace_|TestAccRedshiftServerlessNamespaceDataSource_' -timeout 360m
--- PASS: TestAccRedshiftServerlessNamespace_disappears (15.17s)
--- PASS: TestAccRedshiftServerlessNamespaceDataSource_user (15.37s)
--- PASS: TestAccRedshiftServerlessNamespaceDataSource_basic (15.77s)
--- PASS: TestAccRedshiftServerlessNamespaceDataSource_logExports (15.79s)
--- PASS: TestAccRedshiftServerlessNamespace_manageAdminPassword (15.89s)
--- PASS: TestAccRedshiftServerlessNamespaceDataSource_iamRole (16.15s)
--- PASS: TestAccRedshiftServerlessNamespace_defaultIAMRole (18.57s)
--- PASS: TestAccRedshiftServerlessNamespace_basic (24.97s)
--- PASS: TestAccRedshiftServerlessNamespace_user (27.84s)
--- PASS: TestAccRedshiftServerlessNamespace_tags (32.81s)
--- PASS: TestAccRedshiftServerlessNamespace_withWorkgroup (283.96s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless 291.287s
Thanks for your contribution, @noel-phelt! 👍 |
This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
admin_password_secret_kms_key_id
andmanage_admin_password
toaws_redshiftserverless_namespace
TestAccRedshiftServerlessNamespace_manageAdminPassword
to check whether namespace can be created manage admin passwordTestAccRedshiftServerlessNamespaceDataSource_iamRole
Relations
Relates #35135
References
Output from Acceptance Testing