Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate/tagresource: Generate code for AWS SDK for Go v2 #35675

Closed
ewbankkit opened this issue Feb 6, 2024 · 3 comments · Fixed by #35700
Closed

generate/tagresource: Generate code for AWS SDK for Go v2 #35675

ewbankkit opened this issue Feb 6, 2024 · 3 comments · Fixed by #35700
Labels
tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Feb 6, 2024

generate/tagresource emits code for AWS SDK for Go v1.
Update to emit code for AWS SDK for Go v2.

% grep tagresource internal/service/*/generate.go
internal/service/dynamodb/generate.go://go:generate go run ../../generate/tagresource/main.go
internal/service/ec2/generate.go://go:generate go run ../../generate/tagresource/main.go -IDAttribName=resource_id
internal/service/ecs/generate.go://go:generate go run ../../generate/tagresource/main.go
internal/service/transfer/generate.go://go:generate go run ../../generate/tagresource/main.go -UpdateTagsFunc=updateTagsNoIgnoreSystem

Relates #32976.

Copy link

github-actions bot commented Feb 6, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ewbankkit ewbankkit added technical-debt Addresses areas of the codebase that need refactoring or redesign. tags Pertains to resource tagging. labels Feb 7, 2024
@github-actions github-actions bot added this to the v5.36.0 milestone Feb 7, 2024
Copy link

github-actions bot commented Feb 8, 2024

This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant