Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support for new direct to Snowflake streaming for aws_kinesis_firehose_delivery_stream #35647

Closed
davidzajac1 opened this issue Feb 5, 2024 · 6 comments · Fixed by #36646
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Milestone

Comments

@davidzajac1
Copy link

davidzajac1 commented Feb 5, 2024

Description

AWS released a new feature of Kinesis Firehose on January 19 2024 adding Snowflake as a new destination for a Kinesis Firehose stream. Snowflake as a destination comes with its own unique configuration that is not supported by the current aws_kinesis_firehose_delivery_stream Terraform object.

Affected Resource(s) and/or Data Source(s)

aws_kinesis_firehose_delivery_stream

Potential Terraform Configuration

resource "aws_kinesis_firehose_delivery_stream" "example_snowflake_destination" {
  name        = "example-snowflake-destination"
  destination = "snowflake"

  snowflake_destination_configuration {
    account_url    = "string"
    private_key    = "string"
    key_passphrase = "string"
    user           = "string"
    database       = "string"
    schema         = "string"
    table          = "string"
    snowflake_role_configuration {
      enabled        = true
      snowflake_role = "string"
    }
    data_loading_option   = "JSON_MAPPING"
    meta_data_column_name = "string"
    content_column_name   = "string"
    snowflake_vpc_configuration {
      private_link_vpce_id = "string"
    }
    cloud_watch_logging_options {
      enabled         = true
      log_group_name  = "string"
      log_stream_name = "string"
    }
    processing_configuration {
      enabled = true
      processors = [
        {
          type = "RecordDeAggregation"
          parameters = [
            {
              parameter_name  = "LambdaArn"
              parameter_value = "string"
            }
            # Add more parameters as needed
          ]
        }
        # Add more processors as needed
      ]
    }
    role_arn = "string"
    retry_options {
      duration_in_seconds = 123
    }
    s3_backup_mode = "FailedDataOnly"
    s3_configuration {
      role_arn            = "string"
      bucket_arn          = "string"
      prefix              = "string"
      error_output_prefix = "string"
      buffering_hints {
        size_in_mbs         = 123
        interval_in_seconds = 456
      }
      compression_format = "UNCOMPRESSED"
      encryption_configuration {
        no_encryption_config = "NoEncryption"
        kms_encryption_config {
          aws_kms_key_arn = "string"
        }
      }
      cloud_watch_logging_options {
        enabled         = true
        log_group_name  = "string"
        log_stream_name = "string"
      }
    }
  }
}

References

Release notes for Kinesis Firehose direct to Snowflake streaming: https://aws.amazon.com/about-aws/whats-new/2024/01/stream-data-snowflake-kinesis-data-firehose-snowpipe-streaming-preview/

See the --snowflake-destination-configuration flag in the AWS CLI Docs here: https://docs.aws.amazon.com/cli/latest/reference/firehose/create-delivery-stream.html

Would you like to implement a fix?

No

@davidzajac1 davidzajac1 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/firehose Issues and PRs that pertain to the firehose service. label Feb 5, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 5, 2024
@jmprovencher
Copy link

+1 on this :D

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Feb 15, 2024
@i-ate-a-vm
Copy link

Having this available in TF would be greatly helpful for us too!

@ewbankkit ewbankkit self-assigned this Apr 19, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 19, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.47.0 milestone Apr 22, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 26, 2024
Copy link

This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Projects
None yet
5 participants