-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws_s3_bucket_metric): add support for access_point configuration in s3 bucket metric filter #35590
feat(aws_s3_bucket_metric): add support for access_point configuration in s3 bucket metric filter #35590
Conversation
…tion in s3 bucket metric filter
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @amartin-isp 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Hi @ewbankkit, I think I was able to address the failures in Acceptance Test Linting / terrafmt with my last commit. I'm not sure how to address the ones in ProviderLint Checks / providerlint though. |
My last commit should address the ProviderLint Checks / providerlint failures as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccS3BucketMetric_' PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3 -run=TestAccS3BucketMetric_ -timeout 360m
=== RUN TestAccS3BucketMetric_basic
=== PAUSE TestAccS3BucketMetric_basic
=== RUN TestAccS3BucketMetric_withEmptyFilter
=== PAUSE TestAccS3BucketMetric_withEmptyFilter
=== RUN TestAccS3BucketMetric_withFilterAccessPoint
=== PAUSE TestAccS3BucketMetric_withFilterAccessPoint
=== RUN TestAccS3BucketMetric_withFilterAccessPointAndPrefixAndMultiTags
=== PAUSE TestAccS3BucketMetric_withFilterAccessPointAndPrefixAndMultiTags
=== RUN TestAccS3BucketMetric_withFilterAccessPointAndPrefixAndSingleTag
=== PAUSE TestAccS3BucketMetric_withFilterAccessPointAndPrefixAndSingleTag
=== RUN TestAccS3BucketMetric_withFilterAccessPointAndPrefix
=== PAUSE TestAccS3BucketMetric_withFilterAccessPointAndPrefix
=== RUN TestAccS3BucketMetric_withFilterAccessPointAndMultipleTags
=== PAUSE TestAccS3BucketMetric_withFilterAccessPointAndMultipleTags
=== RUN TestAccS3BucketMetric_withFilterAccessPointAndSingleTag
=== PAUSE TestAccS3BucketMetric_withFilterAccessPointAndSingleTag
=== RUN TestAccS3BucketMetric_withFilterPrefix
=== PAUSE TestAccS3BucketMetric_withFilterPrefix
=== RUN TestAccS3BucketMetric_withFilterPrefixAndMultipleTags
=== PAUSE TestAccS3BucketMetric_withFilterPrefixAndMultipleTags
=== RUN TestAccS3BucketMetric_withFilterPrefixAndSingleTag
=== PAUSE TestAccS3BucketMetric_withFilterPrefixAndSingleTag
=== RUN TestAccS3BucketMetric_withFilterMultipleTags
=== PAUSE TestAccS3BucketMetric_withFilterMultipleTags
=== RUN TestAccS3BucketMetric_withFilterSingleTag
=== PAUSE TestAccS3BucketMetric_withFilterSingleTag
=== RUN TestAccS3BucketMetric_directoryBucket
=== PAUSE TestAccS3BucketMetric_directoryBucket
=== CONT TestAccS3BucketMetric_basic
=== CONT TestAccS3BucketMetric_withFilterAccessPointAndSingleTag
=== CONT TestAccS3BucketMetric_withFilterMultipleTags
--- PASS: TestAccS3BucketMetric_basic (27.57s)
=== CONT TestAccS3BucketMetric_directoryBucket
--- PASS: TestAccS3BucketMetric_directoryBucket (12.06s)
=== CONT TestAccS3BucketMetric_withFilterSingleTag
--- PASS: TestAccS3BucketMetric_withFilterMultipleTags (44.50s)
=== CONT TestAccS3BucketMetric_withFilterAccessPointAndPrefixAndSingleTag
--- PASS: TestAccS3BucketMetric_withFilterAccessPointAndSingleTag (44.59s)
=== CONT TestAccS3BucketMetric_withFilterAccessPointAndMultipleTags
--- PASS: TestAccS3BucketMetric_withFilterSingleTag (43.37s)
=== CONT TestAccS3BucketMetric_withFilterAccessPointAndPrefix
--- PASS: TestAccS3BucketMetric_withFilterAccessPointAndPrefixAndSingleTag (45.64s)
=== CONT TestAccS3BucketMetric_withFilterAccessPoint
--- PASS: TestAccS3BucketMetric_withFilterAccessPointAndMultipleTags (45.59s)
=== CONT TestAccS3BucketMetric_withFilterAccessPointAndPrefixAndMultiTags
--- PASS: TestAccS3BucketMetric_withFilterAccessPointAndPrefix (43.30s)
=== CONT TestAccS3BucketMetric_withEmptyFilter
--- PASS: TestAccS3BucketMetric_withEmptyFilter (2.67s)
=== CONT TestAccS3BucketMetric_withFilterPrefixAndMultipleTags
--- PASS: TestAccS3BucketMetric_withFilterAccessPointAndPrefixAndMultiTags (45.42s)
=== CONT TestAccS3BucketMetric_withFilterPrefixAndSingleTag
--- PASS: TestAccS3BucketMetric_withFilterAccessPoint (45.48s)
=== CONT TestAccS3BucketMetric_withFilterPrefix
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndMultipleTags (43.55s)
--- PASS: TestAccS3BucketMetric_withFilterPrefix (44.07s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndSingleTag (44.13s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 190.884s
This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add support for filtering by
access_point
for S3 bucket metric configurationRelations
References
Output from Acceptance Testing