Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix: Loosen restrictions on max argument length #35581

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

kavan-aws
Copy link
Contributor

@kavan-aws kavan-aws commented Jan 31, 2024

Description

This minor change increases the upper limit on command line argument key/value length from 50 to 1024, in accordance with a model change on our side. It also increases the upper limit on s3_object_version length to 1024 to match our model (and the maximum length this string can be as defined by s3, though it's usually much shorter). We perform validation on these on our side as well, so this change is just to match that validation rather than being further restrictive when creating through Terraform.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/finspace Issues and PRs that pertain to the finspace service. size/XS Managed by automation to categorize the size of a PR. and removed service/finspace Issues and PRs that pertain to the finspace service. labels Jan 31, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Jan 31, 2024
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 31, 2024
@kavan-aws kavan-aws changed the title Quick fix: Loosen restriction on command line argument length Quick fix: Loosen restrictions on max argument length Jan 31, 2024
@github-actions github-actions bot added the service/finspace Issues and PRs that pertain to the finspace service. label Jan 31, 2024
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @kavan-aws!

@breathingdust breathingdust merged commit 97c16f2 into hashicorp:main Feb 1, 2024
51 checks passed
@github-actions github-actions bot added this to the v5.35.0 milestone Feb 1, 2024
Copy link

github-actions bot commented Feb 2, 2024

This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Mar 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/finspace Issues and PRs that pertain to the finspace service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants