[Bug]: make source_ids optional in aws_dms_event_subscription again

[jcourteauupgrade]

Terraform Core Version

1.5.6

AWS Provider Version

5.33.0

Affected Resource(s)

• aws_dms_event_subscription

Expected Behavior

source_ids should be optional; the default behaviour creates an event subscription for all sources. When a value is provided, the subscriptions apply only to those sources.

See the AWS docs on this - https://docs.aws.amazon.com/dms/latest/APIReference/API_CreateEventSubscription.html#API_CreateEventSubscription_RequestSyntax

Actual Behavior

In #33731, the source_ids field was made mandatory, in an effort to reflect the docs. However, in that case, the docs were wrong, and the docs should have been fixed instead.

With the aboce change, you have to provide source_ids = [] to apply a subscription to all resources, which is very counterintuitive and wouldn't be something you'd know unless you read the AWS API docs carefully and did some experimentation.

I'd recommend reverting part of the previous changeset (the source_type change is still fine and should be preserved), and updating the docs to make it clear how source_ids works, using the AWS API docs as a guide.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

n/a

Steps to Reproduce

n/a

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[github-actions]

This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.