[Bug]: make source_ids
optional in aws_dms_event_subscription
again
#35430
Labels
bug
Addresses a defect in current functionality.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
regression
Pertains to a degraded workflow resulting from an upstream patch or internal enhancement.
service/dms
Issues and PRs that pertain to the dms service.
Milestone
Terraform Core Version
1.5.6
AWS Provider Version
5.33.0
Affected Resource(s)
Expected Behavior
source_ids
should be optional; the default behaviour creates an event subscription for all sources. When a value is provided, the subscriptions apply only to those sources.See the AWS docs on this - https://docs.aws.amazon.com/dms/latest/APIReference/API_CreateEventSubscription.html#API_CreateEventSubscription_RequestSyntax
Actual Behavior
In #33731, the
source_ids
field was made mandatory, in an effort to reflect the docs. However, in that case, the docs were wrong, and the docs should have been fixed instead.With the aboce change, you have to provide
source_ids = []
to apply a subscription to all resources, which is very counterintuitive and wouldn't be something you'd know unless you read the AWS API docs carefully and did some experimentation.I'd recommend reverting part of the previous changeset (the
source_type
change is still fine and should be preserved), and updating the docs to make it clear howsource_ids
works, using the AWS API docs as a guide.Relevant Error/Panic Output Snippet
No response
Terraform Configuration Files
n/a
Steps to Reproduce
n/a
Debug Output
No response
Panic Output
No response
Important Factoids
No response
References
No response
Would you like to implement a fix?
None
The text was updated successfully, but these errors were encountered: