Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_prometheus_scraper export "roleArn" attribute #35322

Closed
xdrus opened this issue Jan 16, 2024 · 3 comments · Fixed by #35453
Closed

[Enhancement]: aws_prometheus_scraper export "roleArn" attribute #35322

xdrus opened this issue Jan 16, 2024 · 3 comments · Fixed by #35453
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/amp Issues and PRs that pertain to the amp service.
Milestone

Comments

@xdrus
Copy link

xdrus commented Jan 16, 2024

Description

The new resource for AMP managed collector - aws_prometheus_scraper currently export only ARN of the new scraper and it's status. However, managed scrapper also creates IAM role that it uses for EKS authentication (see points 3-5 in doc).

This roleArn is required in order to create additional aws-auth ConfigMap entries (or in order to use a new EKS access entries API.

As of now I've had to implement a nasty workaround:

# Have to use provisioner as aws_prometheus_scraper resource doesn't return role ARN
resource "terraform_data" "map-amp-scrapper-role" {
   triggers_replace = [
    aws_prometheus_scraper.eks-to-amp-scrapper.id
  ]

  provisioner "local-exec" {
    command = <<EOT
        ROLE=$(aws amp describe-scraper --scraper-id ${aws_prometheus_scraper.eks-to-amp-scrapper.id} --query "scraper.roleArn" --output text | sed -e "s+/aws-service-role/scraper.aps.amazonaws.com/+/+g") &&
        eksctl create iamidentitymapping  \
             --cluster ${module.eks.cluster_name} \
             --region ${local.region} \
             --arn $ROLE \
             --username aps-collector-user
      EOT
  }
}

Affected Resource(s) and/or Data Source(s)

  • aws_prometheus_scraper

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

No

@xdrus xdrus added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 16, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/amp Issues and PRs that pertain to the amp service. label Jan 16, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 16, 2024
@justinretzolk justinretzolk added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 16, 2024
@github-actions github-actions bot added this to the v5.34.0 milestone Jan 24, 2024
Copy link

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/amp Issues and PRs that pertain to the amp service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants