Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target_file_size field to AppFlow #35215

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Conversation

mikhail-zhadanov
Copy link
Contributor

@mikhail-zhadanov mikhail-zhadanov commented Jan 10, 2024

Description

This pull request adds the target_file_size field to the resourceFlow function and the AppFlow flow configuration. The target_file_size field is an optional property that specifies the desired file size, in MB, for each output file that Amazon AppFlow writes to the flow destination.

Relations

closes #34635

References

https://docs.aws.amazon.com/appflow/1.0/APIReference/API_AggregationConfig.html

Output from Acceptance Testing

n/a - test passed on private account

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/appflow Issues and PRs that pertain to the appflow service. labels Jan 10, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 10, 2024
@mikhail-zhadanov mikhail-zhadanov marked this pull request as ready for review January 10, 2024 03:31
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @mikhail-zhadanov 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 10, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType\|TestAccAppFlowFlow_basic' PKG=appflow ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 2  -run=TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType\|TestAccAppFlowFlow_basic -timeout 360m
=== RUN   TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== RUN   TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
=== PAUSE TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
=== CONT  TestAccAppFlowFlow_basic
=== CONT  TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
--- PASS: TestAccAppFlowFlow_basic (31.63s)
--- PASS: TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType (43.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	49.963s

@ewbankkit
Copy link
Contributor

@mikhail-zhadanov Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ff2e1af into hashicorp:main Jan 10, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 10, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/appflow Issues and PRs that pertain to the appflow service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: An argument named "target_file_size" is not expected here.
2 participants