Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ebs_fast_snapshot_restore: new resource #35211

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Jan 9, 2024

Description

The aws_ebs_fast_snapshot_restore resource will allow practitioners to manage EBS fast snapshot restore configurations with Terraform.

Relations

Closes #10972

References

Output from Acceptance Testing

%make testacc PKG=ec2 TESTS=TestAccEC2EBSFastSnapshotRestore_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EBSFastSnapshotRestore_'  -timeout 360m

--- PASS: TestAccEC2EBSFastSnapshotRestore_disappears (107.35s)
--- PASS: TestAccEC2EBSFastSnapshotRestore_basic (109.30s)
--- PASS: TestAccEC2EBSFastSnapshotRestore_disappearsSnapshot (117.57s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        121.266s

Copy link

github-actions bot commented Jan 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. labels Jan 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 9, 2024
The `aws_ebs_fast_snapshot_restore` resource will allow practitioners to manage EBS fast snapshot restore configurations with Terraform.
@jar-b jar-b force-pushed the f-ebs_fast_snapshot_restore branch from 8c029a0 to d6137ed Compare January 9, 2024 20:31
@jar-b jar-b added the new-resource Introduces a new resource. label Jan 9, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2EBSFastSnapshotRestore_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccEC2EBSFastSnapshotRestore_ -timeout 360m
=== RUN   TestAccEC2EBSFastSnapshotRestore_basic
=== PAUSE TestAccEC2EBSFastSnapshotRestore_basic
=== RUN   TestAccEC2EBSFastSnapshotRestore_disappears
=== PAUSE TestAccEC2EBSFastSnapshotRestore_disappears
=== RUN   TestAccEC2EBSFastSnapshotRestore_disappearsSnapshot
=== PAUSE TestAccEC2EBSFastSnapshotRestore_disappearsSnapshot
=== CONT  TestAccEC2EBSFastSnapshotRestore_basic
=== CONT  TestAccEC2EBSFastSnapshotRestore_disappearsSnapshot
--- PASS: TestAccEC2EBSFastSnapshotRestore_disappearsSnapshot (113.00s)
=== CONT  TestAccEC2EBSFastSnapshotRestore_disappears
--- PASS: TestAccEC2EBSFastSnapshotRestore_basic (125.05s)
--- PASS: TestAccEC2EBSFastSnapshotRestore_disappears (111.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	229.999s

@jar-b jar-b merged commit 5475651 into main Jan 10, 2024
54 checks passed
@jar-b jar-b deleted the f-ebs_fast_snapshot_restore branch January 10, 2024 13:55
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 10, 2024
github-actions bot pushed a commit that referenced this pull request Jan 10, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon EBS Fast Snapshot Restore
2 participants