Fix: aws_synthetics_canary generate correct timeout_in_seconds if not set in run_config

[SebastianSlaby]

Description

Currently, if run_config is set but the value of timeout_in_seconds is not, it will default to 840. This causes issues when the rate is set to anything below 14 minutes, as the timeout can not be higher than the frequency of the synthetic canary.

This PR changes the behavior. so the value is computed by the AWS SDK based on the schedule.

relevant AWS SDK type

Relations

Closes #35176

References

Output from Acceptance Testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/synthetics/... -v -count 1 -parallel 20 -run='TestAccSyntheticsCanary'  -timeout 360m
=== RUN   TestAccSyntheticsCanary_basic
=== PAUSE TestAccSyntheticsCanary_basic
=== RUN   TestAccSyntheticsCanary_artifactEncryption
=== PAUSE TestAccSyntheticsCanary_artifactEncryption
=== RUN   TestAccSyntheticsCanary_runtimeVersion
=== PAUSE TestAccSyntheticsCanary_runtimeVersion
=== RUN   TestAccSyntheticsCanary_rate
=== PAUSE TestAccSyntheticsCanary_rate
=== RUN   TestAccSyntheticsCanary_startCanary
=== PAUSE TestAccSyntheticsCanary_startCanary
=== RUN   TestAccSyntheticsCanary_StartCanary_codeChanges
=== PAUSE TestAccSyntheticsCanary_StartCanary_codeChanges
=== RUN   TestAccSyntheticsCanary_s3
=== PAUSE TestAccSyntheticsCanary_s3
=== RUN   TestAccSyntheticsCanary_run
=== PAUSE TestAccSyntheticsCanary_run
=== RUN   TestAccSyntheticsCanary_runTracing
=== PAUSE TestAccSyntheticsCanary_runTracing
=== RUN   TestAccSyntheticsCanary_runEnvironmentVariables
=== PAUSE TestAccSyntheticsCanary_runEnvironmentVariables
=== RUN   TestAccSyntheticsCanary_vpc
=== PAUSE TestAccSyntheticsCanary_vpc
=== RUN   TestAccSyntheticsCanary_tags
=== PAUSE TestAccSyntheticsCanary_tags
=== RUN   TestAccSyntheticsCanary_disappears
=== PAUSE TestAccSyntheticsCanary_disappears
=== CONT  TestAccSyntheticsCanary_basic
=== CONT  TestAccSyntheticsCanary_run
=== CONT  TestAccSyntheticsCanary_vpc
=== CONT  TestAccSyntheticsCanary_runTracing
=== CONT  TestAccSyntheticsCanary_tags
=== CONT  TestAccSyntheticsCanary_disappears
=== CONT  TestAccSyntheticsCanary_startCanary
=== CONT  TestAccSyntheticsCanary_s3
=== CONT  TestAccSyntheticsCanary_StartCanary_codeChanges
=== CONT  TestAccSyntheticsCanary_runtimeVersion
=== CONT  TestAccSyntheticsCanary_artifactEncryption
=== CONT  TestAccSyntheticsCanary_rate
=== CONT  TestAccSyntheticsCanary_runEnvironmentVariables
--- PASS: TestAccSyntheticsCanary_s3 (85.64s)
=== NAME  TestAccSyntheticsCanary_startCanary
    canary_test.go:225: Step 2/4 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        - 	"status":                  "RUNNING",
        + 	"status":                  "STOPPED",
        - 	"timeline.0.last_stopped": "",
        + 	"timeline.0.last_stopped": "2024-01-07T23:21:01Z",
          }
=== NAME  TestAccSyntheticsCanary_StartCanary_codeChanges
    canary_test.go:274: Step 2/3 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        - 	"status":                  "RUNNING",
        + 	"status":                  "STOPPED",
        - 	"timeline.0.last_stopped": "",
        + 	"timeline.0.last_stopped": "2024-01-07T23:21:00Z",
          }
--- PASS: TestAccSyntheticsCanary_disappears (100.44s)
--- FAIL: TestAccSyntheticsCanary_StartCanary_codeChanges (103.86s)
--- FAIL: TestAccSyntheticsCanary_startCanary (107.47s)
--- PASS: TestAccSyntheticsCanary_runEnvironmentVariables (122.34s)
--- PASS: TestAccSyntheticsCanary_artifactEncryption (136.41s)
--- PASS: TestAccSyntheticsCanary_runtimeVersion (148.83s)
--- PASS: TestAccSyntheticsCanary_tags (152.20s)
--- PASS: TestAccSyntheticsCanary_basic (155.53s)
--- PASS: TestAccSyntheticsCanary_runTracing (160.07s)
--- PASS: TestAccSyntheticsCanary_run (170.39s)
--- PASS: TestAccSyntheticsCanary_rate (234.31s)


...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @SebastianSlaby 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[jar-b]

LGTM 🎉

% make testacc PKG=synthetics TESTS=TestAccSyntheticsCanary_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/synthetics/... -v -count 1 -parallel 20 -run='TestAccSyntheticsCanary_'  -timeout 360m

--- PASS: TestAccSyntheticsCanary_tags (88.14s)
--- PASS: TestAccSyntheticsCanary_runtimeVersion (133.21s)
--- PASS: TestAccSyntheticsCanary_run (168.45s)
--- PASS: TestAccSyntheticsCanary_artifactEncryption (181.53s)
--- PASS: TestAccSyntheticsCanary_startCanary (195.63s)
--- PASS: TestAccSyntheticsCanary_runTracing (220.42s)
--- PASS: TestAccSyntheticsCanary_runEnvironmentVariables (236.81s)
--- PASS: TestAccSyntheticsCanary_disappears (239.22s)
--- PASS: TestAccSyntheticsCanary_s3 (523.47s)
--- PASS: TestAccSyntheticsCanary_StartCanary_codeChanges (573.71s)
--- PASS: TestAccSyntheticsCanary_basic (579.43s)
--- PASS: TestAccSyntheticsCanary_rate (644.30s)
--- PASS: TestAccSyntheticsCanary_vpc (2152.74s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/synthetics 2158.743s

[jar-b]

Thanks for your contribution, @SebastianSlaby! 👍

[github-actions]

This functionality has been released in v5.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.