Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_imagebuilder_workflow: new resource #35097

Merged
merged 9 commits into from
Jan 3, 2024

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented Dec 30, 2023

Description

This PR adds a new aws_imagebuilder_workflow resource.

The corresponding data source and related enhancements to aws_imagebuilder_pipeline allowing to specify pipeline workflows will come in separate PRs.

Relations

Relates #35045.

References

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccImageBuilderWorkflow_" PKG=imagebuilder 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20  -run=TestAccImageBuilderWorkflow_ -timeout 360m
=== RUN   TestAccImageBuilderWorkflow_basic
=== PAUSE TestAccImageBuilderWorkflow_basic
=== RUN   TestAccImageBuilderWorkflow_disappears
=== PAUSE TestAccImageBuilderWorkflow_disappears
=== RUN   TestAccImageBuilderWorkflow_changeDescription
=== PAUSE TestAccImageBuilderWorkflow_changeDescription
=== RUN   TestAccImageBuilderWorkflow_description
=== PAUSE TestAccImageBuilderWorkflow_description
=== RUN   TestAccImageBuilderWorkflow_kmsKeyID
=== PAUSE TestAccImageBuilderWorkflow_kmsKeyID
=== RUN   TestAccImageBuilderWorkflow_tags
=== PAUSE TestAccImageBuilderWorkflow_tags
=== RUN   TestAccImageBuilderWorkflow_uri
=== PAUSE TestAccImageBuilderWorkflow_uri
=== CONT  TestAccImageBuilderWorkflow_basic
=== CONT  TestAccImageBuilderWorkflow_kmsKeyID
=== CONT  TestAccImageBuilderWorkflow_changeDescription
=== CONT  TestAccImageBuilderWorkflow_description
=== CONT  TestAccImageBuilderWorkflow_tags
=== CONT  TestAccImageBuilderWorkflow_uri
=== CONT  TestAccImageBuilderWorkflow_disappears
--- PASS: TestAccImageBuilderWorkflow_disappears (21.07s)
--- PASS: TestAccImageBuilderWorkflow_description (23.75s)
--- PASS: TestAccImageBuilderWorkflow_basic (23.82s)
--- PASS: TestAccImageBuilderWorkflow_changeDescription (24.48s)
--- PASS: TestAccImageBuilderWorkflow_kmsKeyID (26.25s)
--- PASS: TestAccImageBuilderWorkflow_uri (32.90s)
--- PASS: TestAccImageBuilderWorkflow_tags (45.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       47.861s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. generators Relates to code generators. labels Dec 30, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Dec 30, 2023
@kamilturek kamilturek marked this pull request as ready for review December 30, 2023 12:37
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 3, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccImageBuilderWorkflow_' PKG=imagebuilder ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 2  -run=TestAccImageBuilderWorkflow_ -timeout 360m
=== RUN   TestAccImageBuilderWorkflow_basic
=== PAUSE TestAccImageBuilderWorkflow_basic
=== RUN   TestAccImageBuilderWorkflow_disappears
=== PAUSE TestAccImageBuilderWorkflow_disappears
=== RUN   TestAccImageBuilderWorkflow_changeDescription
=== PAUSE TestAccImageBuilderWorkflow_changeDescription
=== RUN   TestAccImageBuilderWorkflow_description
=== PAUSE TestAccImageBuilderWorkflow_description
=== RUN   TestAccImageBuilderWorkflow_kmsKeyID
=== PAUSE TestAccImageBuilderWorkflow_kmsKeyID
=== RUN   TestAccImageBuilderWorkflow_tags
=== PAUSE TestAccImageBuilderWorkflow_tags
=== RUN   TestAccImageBuilderWorkflow_uri
=== PAUSE TestAccImageBuilderWorkflow_uri
=== CONT  TestAccImageBuilderWorkflow_basic
=== CONT  TestAccImageBuilderWorkflow_kmsKeyID
--- PASS: TestAccImageBuilderWorkflow_basic (23.49s)
=== CONT  TestAccImageBuilderWorkflow_changeDescription
--- PASS: TestAccImageBuilderWorkflow_kmsKeyID (23.90s)
=== CONT  TestAccImageBuilderWorkflow_description
--- PASS: TestAccImageBuilderWorkflow_changeDescription (22.54s)
=== CONT  TestAccImageBuilderWorkflow_disappears
--- PASS: TestAccImageBuilderWorkflow_description (22.78s)
=== CONT  TestAccImageBuilderWorkflow_uri
--- PASS: TestAccImageBuilderWorkflow_disappears (18.85s)
=== CONT  TestAccImageBuilderWorkflow_tags
--- PASS: TestAccImageBuilderWorkflow_uri (29.38s)
--- PASS: TestAccImageBuilderWorkflow_tags (46.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	116.727s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b7fe731 into hashicorp:main Jan 3, 2024
61 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 3, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
@kamilturek kamilturek deleted the f-aws-imagebuilder-workflow branch March 31, 2024 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants