-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_cloudwatch_log_group: Remove default value (STANDARD
) for log_group_class
argument and mark as Computed
#34812
Conversation
…g_group_class` argument and mark as Computed. This fixes `InvalidParameterException: Only Standard log class is supported` errors in AWS Regions other than AWS Commercial.
Community NoteVoting for Prioritization
For Submitters
|
547ade5
to
ec7025f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc TESTARGS='-run=TestAccLogsGroup_\|TestAccLogsGroupDataSource_' PKG=logs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 20 -run=TestAccLogsGroup_\|TestAccLogsGroupDataSource_ -timeout 360m
--- PASS: TestAccLogsGroup_skipDestroy (53.28s)
--- PASS: TestAccLogsGroup_logGroupClass (55.78s)
--- PASS: TestAccLogsGroup_disappears (57.11s)
--- PASS: TestAccLogsGroup_basic (59.83s)
--- PASS: TestAccLogsGroup_nameGenerate (60.35s)
--- PASS: TestAccLogsGroup_namePrefix (60.49s)
--- PASS: TestAccLogsGroup_multiple (61.68s)
--- PASS: TestAccLogsGroupDataSource_basic (71.37s)
--- PASS: TestAccLogsGroup_tags (96.51s)
--- PASS: TestAccLogsGroup_retentionPolicy (96.67s)
--- PASS: TestAccLogsGroup_kmsKey (122.83s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/logs 126.177s
👍 |
1 similar comment
👍🏽 |
An issue was discovered in the AWS terraform provider v5.30.0: hashicorp/terraform-provider-aws#34812 This reverts commit 0336066.
We really need this fixed ASAP. 👍 |
Yesterday and today we tried to deploy an ECS service on GovCloud and it failed with the following message: Prior to fail creating the service the following message was printed about the CloudWatch:
I'm confused, should it be |
An issue was discovered in the AWS terraform provider v5.30.0: hashicorp/terraform-provider-aws#34812 This reverts commit 0336066.
i am still seeing this as well |
We implemented a workaround for this bug. We hardcoded the Terraform version under the required_provider section. The last known stable version was 5.26.0:
Version 5.30.0 is still failing. |
This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Change
aws_cloudwatch_log_group.log_group_class
toComputed
as it's not (yet) supported in AWS GovCloud (US) or AWS China.Relations
Closes #34810.
Closes #34809.
Output from Acceptance Testing
AWS Commercial
AWS GovCloud (US)