-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_db_instance: Allow out-of-band Blue/Green update #34728
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=rds TESTS=TestAccRDSInstance_BlueGreenDeployment_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_BlueGreenDeployment_' -timeout 360m
--- PASS: TestAccRDSInstance_BlueGreenDeployment_passwordBypassesBlueGreen (1127.00s)
--- PASS: TestAccRDSInstance_BlueGreenDeployment_tags (1188.60s)
--- PASS: TestAccRDSInstance_BlueGreenDeployment_deletionProtectionBypassesBlueGreen (1194.40s)
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass (2741.22s)
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups (2763.45s)
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup (2768.12s)
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion (2805.29s)
--- PASS: TestAccRDSInstance_BlueGreenDeployment_outOfBand (2862.24s)
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection (3101.50s)
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica (3691.28s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 3694.654s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccRDSInstance_BlueGreenDeployment_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2 -run=TestAccRDSInstance_BlueGreenDeployment_ -timeout 720m
=== RUN TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
=== RUN TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup
=== RUN TestAccRDSInstance_BlueGreenDeployment_tags
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_tags
=== RUN TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass
=== RUN TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica
=== RUN TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups
=== RUN TestAccRDSInstance_BlueGreenDeployment_deletionProtectionBypassesBlueGreen
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_deletionProtectionBypassesBlueGreen
=== RUN TestAccRDSInstance_BlueGreenDeployment_passwordBypassesBlueGreen
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_passwordBypassesBlueGreen
=== RUN TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection
=== RUN TestAccRDSInstance_BlueGreenDeployment_outOfBand
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_outOfBand
=== CONT TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
=== CONT TestAccRDSInstance_BlueGreenDeployment_passwordBypassesBlueGreen
--- PASS: TestAccRDSInstance_BlueGreenDeployment_passwordBypassesBlueGreen (797.85s)
=== CONT TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion (2424.68s)
=== CONT TestAccRDSInstance_BlueGreenDeployment_deletionProtectionBypassesBlueGreen
--- PASS: TestAccRDSInstance_BlueGreenDeployment_deletionProtectionBypassesBlueGreen (821.90s)
=== CONT TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica (3501.41s)
=== CONT TestAccRDSInstance_BlueGreenDeployment_tags
--- PASS: TestAccRDSInstance_BlueGreenDeployment_tags (789.33s)
=== CONT TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups (2493.20s)
=== CONT TestAccRDSInstance_BlueGreenDeployment_outOfBand
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass (2754.50s)
=== CONT TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup
--- PASS: TestAccRDSInstance_BlueGreenDeployment_outOfBand (2260.13s)
=== CONT TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup (2243.14s)
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection (2622.01s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 10627.536s
…-check` Semgrep check
This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
If an
aws_db_instance
is updated manually using a Blue/Green Deployment, the provider would lose track of it. Allow the provider to keep it under management.Output from Acceptance Testing