Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_verifiedaccess_instance #33459

Merged
merged 12 commits into from
Sep 14, 2023

Conversation

GlennChia
Copy link
Collaborator

Description

New resource: aws_verifiedaccess_instance

Relations

Relates #29689

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccVerifiedAccessInstance' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVerifiedAccessInstance -timeout 180m
=== RUN   TestAccVerifiedAccessInstance_basic
=== PAUSE TestAccVerifiedAccessInstance_basic
=== RUN   TestAccVerifiedAccessInstance_description
=== PAUSE TestAccVerifiedAccessInstance_description
=== RUN   TestAccVerifiedAccessInstance_disappears
=== PAUSE TestAccVerifiedAccessInstance_disappears
=== RUN   TestAccVerifiedAccessInstance_tags
=== PAUSE TestAccVerifiedAccessInstance_tags
=== CONT  TestAccVerifiedAccessInstance_basic
=== CONT  TestAccVerifiedAccessInstance_disappears
--- PASS: TestAccVerifiedAccessInstance_disappears (27.66s)
=== CONT  TestAccVerifiedAccessInstance_tags
--- PASS: TestAccVerifiedAccessInstance_basic (36.32s)
=== CONT  TestAccVerifiedAccessInstance_description
--- PASS: TestAccVerifiedAccessInstance_description (57.00s)
--- PASS: TestAccVerifiedAccessInstance_tags (80.77s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        108.535s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. labels Sep 14, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Sep 14, 2023
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 14, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVerifiedAccessInstance_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVerifiedAccessInstance_ -timeout 180m
=== RUN   TestAccVerifiedAccessInstance_basic
=== PAUSE TestAccVerifiedAccessInstance_basic
=== RUN   TestAccVerifiedAccessInstance_description
=== PAUSE TestAccVerifiedAccessInstance_description
=== RUN   TestAccVerifiedAccessInstance_disappears
=== PAUSE TestAccVerifiedAccessInstance_disappears
=== RUN   TestAccVerifiedAccessInstance_tags
=== PAUSE TestAccVerifiedAccessInstance_tags
=== CONT  TestAccVerifiedAccessInstance_basic
=== CONT  TestAccVerifiedAccessInstance_disappears
--- PASS: TestAccVerifiedAccessInstance_disappears (20.30s)
=== CONT  TestAccVerifiedAccessInstance_description
--- PASS: TestAccVerifiedAccessInstance_basic (26.46s)
=== CONT  TestAccVerifiedAccessInstance_tags
--- PASS: TestAccVerifiedAccessInstance_description (40.96s)
--- PASS: TestAccVerifiedAccessInstance_tags (57.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	89.051s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit cb8c8ea into hashicorp:main Sep 14, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.17.0 milestone Sep 14, 2023
@github-actions
Copy link

This functionality has been released in v5.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. partner Contribution from a partner. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants