Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: additional attributes configurations for load balancer target groups (aws_lb_target_group) #33424

Closed
marcaurele opened this issue Sep 12, 2023 · 4 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/vpc Issues and PRs that pertain to the vpc service.

Comments

@marcaurele
Copy link

Description

Terraform does not currently provide a native way to change additional attributes for target groups of a network load balancer. By default target groups that are associated with a network load balancer have a whole list of extra configuration options:

image

One of the important option we are looking for is to configure the target_health_state.unhealthy.connection_termination.enabled. See key configuration options with the AWS CLI: aws elbv2 modify-target-group-attributes help

Affected Resource(s) and/or Data Source(s)

  • aws_lb_target_group

Potential Terraform Configuration

resource "aws_lb_target_group" "test" {
  name     = "tf-example-lb-tg"
  port     = 80
  protocol = "HTTP"
  vpc_id   = aws_vpc.main.id

  proxy_protocol_v2 = true
  deregistration_delay {
    connection_termination = false
  }
  target_health_state {
    unhealthy_connection_termination = false
  }
}

resource "aws_vpc" "main" {
  cidr_block = "10.0.0.0/16"
}

References

Would you like to implement a fix?

No

@marcaurele marcaurele added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 12, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/elbv2 Issues and PRs that pertain to the elbv2 service. service/vpc Issues and PRs that pertain to the vpc service. labels Sep 12, 2023
@marcaurele marcaurele changed the title [Enhancement]: additional attributes configurations for load balancer target groups [Enhancement]: additional attributes configurations for load balancer target groups (aws_lb_target_group) Sep 12, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 12, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 23, 2023
@acwwat
Copy link
Contributor

acwwat commented Sep 28, 2024

Looking at the latest aws_lb_target_group resource doc, it seems that all the requested features are now available. This issue can probably be closed.

@marcaurele
Copy link
Author

Looking at the latest aws_lb_target_group resource doc, it seems that all the requested features are now available. This issue can probably be closed.

Correct, I'm closing the ticket as implemented. Things were added in version 5.62.0, 5.59.0.

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/vpc Issues and PRs that pertain to the vpc service.
Projects
None yet
Development

No branches or pull requests

3 participants