-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pagination support to DescribeFileSystems in EFS #33336
Added pagination support to DescribeFileSystems in EFS #33336
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEFSFileSystemDataSource_\|TestAccEFSFileSystem_' PKG=efs ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 3 -run=TestAccEFSFileSystemDataSource_\|TestAccEFSFileSystem_ -timeout 180m
=== RUN TestAccEFSFileSystemDataSource_id
=== PAUSE TestAccEFSFileSystemDataSource_id
=== RUN TestAccEFSFileSystemDataSource_tags
=== PAUSE TestAccEFSFileSystemDataSource_tags
=== RUN TestAccEFSFileSystemDataSource_name
=== PAUSE TestAccEFSFileSystemDataSource_name
=== RUN TestAccEFSFileSystemDataSource_availabilityZone
=== PAUSE TestAccEFSFileSystemDataSource_availabilityZone
=== RUN TestAccEFSFileSystemDataSource_nonExistent_tags
=== PAUSE TestAccEFSFileSystemDataSource_nonExistent_tags
=== RUN TestAccEFSFileSystem_basic
=== PAUSE TestAccEFSFileSystem_basic
=== RUN TestAccEFSFileSystem_disappears
=== PAUSE TestAccEFSFileSystem_disappears
=== RUN TestAccEFSFileSystem_performanceMode
=== PAUSE TestAccEFSFileSystem_performanceMode
=== RUN TestAccEFSFileSystem_availabilityZoneName
=== PAUSE TestAccEFSFileSystem_availabilityZoneName
=== RUN TestAccEFSFileSystem_tags
=== PAUSE TestAccEFSFileSystem_tags
=== RUN TestAccEFSFileSystem_kmsKey
=== PAUSE TestAccEFSFileSystem_kmsKey
=== RUN TestAccEFSFileSystem_kmsWithoutEncryption
=== PAUSE TestAccEFSFileSystem_kmsWithoutEncryption
=== RUN TestAccEFSFileSystem_provisionedThroughputInMibps
=== PAUSE TestAccEFSFileSystem_provisionedThroughputInMibps
=== RUN TestAccEFSFileSystem_throughputMode
=== PAUSE TestAccEFSFileSystem_throughputMode
=== RUN TestAccEFSFileSystem_lifecyclePolicy
=== PAUSE TestAccEFSFileSystem_lifecyclePolicy
=== CONT TestAccEFSFileSystemDataSource_id
=== CONT TestAccEFSFileSystem_availabilityZoneName
=== CONT TestAccEFSFileSystemDataSource_nonExistent_tags
--- PASS: TestAccEFSFileSystemDataSource_id (34.59s)
=== CONT TestAccEFSFileSystemDataSource_name
--- PASS: TestAccEFSFileSystemDataSource_nonExistent_tags (36.06s)
=== CONT TestAccEFSFileSystemDataSource_availabilityZone
--- PASS: TestAccEFSFileSystem_availabilityZoneName (39.16s)
=== CONT TestAccEFSFileSystem_provisionedThroughputInMibps
--- PASS: TestAccEFSFileSystemDataSource_name (29.47s)
=== CONT TestAccEFSFileSystem_lifecyclePolicy
--- PASS: TestAccEFSFileSystemDataSource_availabilityZone (32.04s)
=== CONT TestAccEFSFileSystem_throughputMode
--- PASS: TestAccEFSFileSystem_provisionedThroughputInMibps (50.76s)
=== CONT TestAccEFSFileSystem_kmsKey
--- PASS: TestAccEFSFileSystem_throughputMode (52.34s)
=== CONT TestAccEFSFileSystem_kmsWithoutEncryption
--- PASS: TestAccEFSFileSystem_kmsKey (34.40s)
=== CONT TestAccEFSFileSystemDataSource_tags
--- PASS: TestAccEFSFileSystem_kmsWithoutEncryption (12.23s)
=== CONT TestAccEFSFileSystem_disappears
--- PASS: TestAccEFSFileSystem_lifecyclePolicy (84.74s)
=== CONT TestAccEFSFileSystem_performanceMode
--- PASS: TestAccEFSFileSystemDataSource_tags (29.72s)
=== CONT TestAccEFSFileSystem_tags
--- PASS: TestAccEFSFileSystem_disappears (25.79s)
=== CONT TestAccEFSFileSystem_basic
--- PASS: TestAccEFSFileSystem_performanceMode (28.69s)
--- PASS: TestAccEFSFileSystem_basic (31.07s)
--- PASS: TestAccEFSFileSystem_tags (92.39s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/efs 251.677s
@kuredev Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.16.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
When an AWS account has more than 101 EFS resources, If you specify the data source of aws_efs_file_system with a tag, pagination does not work and the resource cannot be found.
This PR changes the DescribeFileSystems used at that time to use pagination.
Steps to Reproduce
Before
After
Relations
Closes #26863
References
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/efs_file_system
https://docs.aws.amazon.com/sdk-for-go/api/service/efs/#EFS.DescribeFileSystemsPagesWithContext
Output from Acceptance Testing