Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support GlueCatalogGeneration in aws_dms_s3_endpoint #33202

Closed
gdowmont-gss opened this issue Aug 28, 2023 · 5 comments · Fixed by #33778
Closed

[Enhancement]: Support GlueCatalogGeneration in aws_dms_s3_endpoint #33202

gdowmont-gss opened this issue Aug 28, 2023 · 5 comments · Fixed by #33778
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dms Issues and PRs that pertain to the dms service.
Milestone

Comments

@gdowmont-gss
Copy link

Description

AWS already supports setting this parameter in go sdk,

Affected Resource(s) and/or Data Source(s)

aws_dms_s3_endpoint

Potential Terraform Configuration

resource "aws_dms_s3_endpoint" "example" {
  endpoint_id             = "donnedtipi"
  endpoint_type           = "target"
  bucket_name             = "beckut_name"
  service_access_role_arn = aws_iam_role.example.arn
  glue_catalog_generation = true
}

References

https://docs.aws.amazon.com/sdk-for-go/api/service/databasemigrationservice/#CreateEndpointInput

Would you like to implement a fix?

None

@gdowmont-gss gdowmont-gss added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 28, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/dms Issues and PRs that pertain to the dms service. label Aug 28, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 28, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 30, 2023
@nikoshet
Copy link
Contributor

nikoshet commented Oct 5, 2023

Hello @gdowmont-gss, I have opend a relative PR regarding the above issue. 😃

@github-actions github-actions bot added this to the v5.21.0 milestone Oct 9, 2023
@github-actions
Copy link

This functionality has been released in v5.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@dabbeg
Copy link

dabbeg commented Oct 16, 2023

Hello,

This new feature does not work:

Error: updating AWS DMS (Database Migration) S3 Endpoint (my-bucket): InvalidParameterCombinationException: GlueCatalogGeneration feature is not available for S3 source endpoint
│ 	status code: 400, request id: d675b669-0d3f-44a8-ab7d-91159e307503
│
│   with module.dms.aws_dms_s3_endpoint.target,
│   on ../../modules/dms/main.tf line 132, in resource "aws_dms_s3_endpoint" "target":
│  132: resource "aws_dms_s3_endpoint" "target" {

Code:

resource "aws_dms_s3_endpoint" "target" {
  endpoint_id             = "s3-dms-endpoint"
  endpoint_type           = "target"
  bucket_name             = "my-bucket"
  service_access_role_arn = aws_iam_role.s3_endpoint.arn

  glue_catalog_generation  = true
  include_op_for_full_load = true

  depends_on = [aws_iam_role.s3_endpoint]
}

Even though the endpoint is configured to be of type target the error indicates that it's of type source.

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dms Issues and PRs that pertain to the dms service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants