Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: typo in Quicksight InsightConfiguration Flattener ('computations" -> "computation") #32788

Closed
MichaelYoung0705 opened this issue Aug 1, 2023 · 4 comments · Fixed by #32791
Labels
bug Addresses a defect in current functionality. service/quicksight Issues and PRs that pertain to the quicksight service.
Milestone

Comments

@MichaelYoung0705
Copy link

MichaelYoung0705 commented Aug 1, 2023

Terraform Core Version

1.5.3

AWS Provider Version

5.10.0

Affected Resource(s)

aws_quicksight_dashboard

Expected Behavior

State written to storage

Actual Behavior

Error when writing state to storage

Relevant Error/Panic Output Snippet

Error: setting definition: Invalid address to set: []string{"definition", "0", "sheets", "6", "visuals", "0", "insight_visual", "0", "insight_configuration", "0", "computations"}

Terraform Configuration Files

resource "aws_quicksight_dashboard" "example" {
dashboard_id = "example"
name = "example"
version_description = "1"
source_entity {
source_template {
arn = "arn:aws:quicksight:us-east-1:1111111111111:template/test/version/1"
data_set_references {
data_set_arn = "arn:aws:quicksight:us-east-1:1111111111111:dataset/test"
data_set_placeholder = "example_placeholder"
}
}
}
}

Steps to Reproduce

Plan and Apply a dashboard resource with visual with the insight visual configuration object.

Debug Output

In the current 5.10.0, the bug is in visual_insight.go on line 749, method flattenInsightConfiguration(). Compared to the sister method, expandInsightConfiguration() and the schema in insightVisualSchema(), "computations" should be "computation".

Panic Output

Error: setting definition: Invalid address to set: []string{"definition", "0", "sheets", "6", "visuals", "0", "insight_visual", "0", "insight_configuration", "0", "computations"}

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

@MichaelYoung0705 MichaelYoung0705 added the bug Addresses a defect in current functionality. label Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/quicksight Issues and PRs that pertain to the quicksight service. needs-triage Waiting for first response or review from a maintainer. labels Aug 1, 2023
@justinretzolk
Copy link
Member

Hey @MichaelYoung0705 👋 Thank you very much for taking the time to report this! I've opened a pull request aimed at correcting this.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 1, 2023
@github-actions github-actions bot added this to the v5.11.0 milestone Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/quicksight Issues and PRs that pertain to the quicksight service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants