-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Properly set DMS Replication Instance data source private/public IPs, VPC security group IDs #32551
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
$ make testacc TESTARGS='-run=TestAccDMSReplicationInstanceDataSource_' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run=TestAccDMSReplicationInstanceDataSource_ -timeout 180m
--- PASS: TestAccDMSReplicationInstanceDataSource_basic (845.90s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 849.080s
This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR updates the
aws_dms_replication_instance
data source to properly set thevpc_security_group_ids
,replication_instance_private_ips
andreplication_instance_public_ips
values. While these attributes were in the schema, they were previously not being set once read.In updating these, I've also removed the
allow_major_version_upgrade
andapply_immediately
attributes, as these are not returned from the SDK (this appears to have been a case of copying over the resource schema to the data source, as they were also not actually being set by the read function).The documentation for the data source has also been updated, as it was mostly a copy from the resource of the same name. The resource-oriented notes have been removed.
Relations
Relates #15406
Closes #32533
References
dms.DescribeReplicationInstances
returns a slice ofdms.ReplicationInstance
Output from Acceptance Testing
While I updated the acceptance test, I'm not able to run it due to what appears to be a permissions issue.