Bug: Properly set DMS Replication Instance data source private/public IPs, VPC security group IDs

[justinretzolk]

Description

This PR updates the aws_dms_replication_instance data source to properly set the vpc_security_group_ids, replication_instance_private_ips and replication_instance_public_ips values. While these attributes were in the schema, they were previously not being set once read.

In updating these, I've also removed the allow_major_version_upgrade and apply_immediately attributes, as these are not returned from the SDK (this appears to have been a case of copying over the resource schema to the data source, as they were also not actually being set by the read function).

The documentation for the data source has also been updated, as it was mostly a copy from the resource of the same name. The resource-oriented notes have been removed.

Relations

Relates #15406
Closes #32533

References

• dms.DescribeReplicationInstances returns a slice of dms.ReplicationInstance

Output from Acceptance Testing

While I updated the acceptance test, I'm not able to run it due to what appears to be a permissions issue.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[johnsonaj]

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccDMSReplicationInstanceDataSource_' PKG=dms

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSReplicationInstanceDataSource_ -timeout 180m
--- PASS: TestAccDMSReplicationInstanceDataSource_basic (845.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	849.080s

[github-actions]

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.