Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_opensearchserverless_vpc_endpoint data source #32276

Conversation

joshjluo
Copy link
Contributor

@joshjluo joshjluo commented Jun 29, 2023

Description

  • Adding new data source for OpenSearch Serverless VPC Endpoint

Relations

Closes #28468
Closes #28313

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccOpenSearchServerlessVPCEndpointDataSource PKG=opensearchserverless
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20 -run='TestAccOpenSearchServerlessVPCEndpointDataSource'  -timeout 180m
=== RUN   TestAccOpenSearchServerlessVPCEndpointDataSource_basic
=== PAUSE TestAccOpenSearchServerlessVPCEndpointDataSource_basic
=== CONT  TestAccOpenSearchServerlessVPCEndpointDataSource_basic
--- PASS: TestAccOpenSearchServerlessVPCEndpointDataSource_basic (351.05s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless       354.509s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. partner Contribution from a partner. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 29, 2023
@johnsonaj johnsonaj self-assigned this Jun 30, 2023
@johnsonaj johnsonaj added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 30, 2023
@joshjluo joshjluo force-pushed the f-aws_opensearchserverless_vpc_endpoint-data-source branch 3 times, most recently from 2588b3c to 97b6cee Compare June 30, 2023 21:27
@joshjluo joshjluo force-pushed the f-aws_opensearchserverless_vpc_endpoint-data-source branch from 97b6cee to 10adf75 Compare June 30, 2023 21:43
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccOpenSearchServerlessVPCEndpointDataSource_' PKG=opensearchserverless

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20  -run=TestAccOpenSearchServerlessVPCEndpointDataSource_ -timeout 180m
--- PASS: TestAccOpenSearchServerlessVPCEndpointDataSource_basic (343.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless	346.950s

@johnsonaj
Copy link
Contributor

@joshjluo thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 33634e4 into hashicorp:main Jul 3, 2023
@github-actions github-actions bot added this to the v5.7.0 milestone Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This functionality has been released in v5.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. partner Contribution from a partner. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: OpenSearch Serverless VPC Endpoint [New Service]: opensearchserverless
2 participants