Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_route53_vpc_association_authorization: Fix ConcurrentModification error #31588

Merged
merged 3 commits into from
May 29, 2023

Conversation

gdavison
Copy link
Contributor

Description

Retries creation and deletion of aws_route53_vpc_association_authorization when a ConcurrentModification error is received.

Relations

Closes #15762

Output from Acceptance Testing

This error is very rare. The best way to confirm that it is working is to generate a debug log and verifying that the ConcurrentModification error is received and retried.

$ make testacc PKG=route53 TESTS=TestAccRoute53VPCAssociationAuthorization_

--- PASS: TestAccRoute53VPCAssociationAuthorization_disappears (87.28s)
--- PASS: TestAccRoute53VPCAssociationAuthorization_concurrent (93.15s)
--- PASS: TestAccRoute53VPCAssociationAuthorization_basic (97.26s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/route53 Issues and PRs that pertain to the route53 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels May 26, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=route53 TESTS=TestAccRoute53VPCAssociationAuthorization_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53VPCAssociationAuthorization_'  -timeout 180m

--- PASS: TestAccRoute53VPCAssociationAuthorization_basic (77.18s)
--- PASS: TestAccRoute53VPCAssociationAuthorization_concurrent (78.97s)
--- PASS: TestAccRoute53VPCAssociationAuthorization_disappears (85.16s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    88.562s

@gdavison gdavison merged commit 5e55d7b into main May 29, 2023
@gdavison gdavison deleted the b-concurrent-r53-assoc branch May 29, 2023 20:28
@github-actions github-actions bot added this to the v5.1.0 milestone May 29, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_route53_vpc_association_authorization Destroys with Errors when Multiple VPCs are Associated
2 participants