Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSx ONTAP volume - ontap_volume_type shouldn't be computed #31544

Merged

Conversation

sdevope
Copy link
Contributor

@sdevope sdevope commented May 23, 2023

Description

FSx ONTAP volume - ontap_volume_type shouldn't be computed.

Relations

Closes #29456

References

AWS:FSx:Volume OntapConfiguration:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-fsx-volume-ontapconfiguration.html#cfn-fsx-volume-ontapconfiguration-ontapvolumetype

AWS SDK for Go; dedicated code:
https://github.com/aws/aws-sdk-go/blob/main/service/fsx/api.go#L22872

Output from Acceptance Testing

$ make testacc TESTS=TestAccFSxOntapVolume PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOntapVolume'  -timeout 180m
=== RUN   TestAccFSxOntapVolume_basic
=== PAUSE TestAccFSxOntapVolume_basic
=== RUN   TestAccFSxOntapVolume_disappears
=== PAUSE TestAccFSxOntapVolume_disappears
=== RUN   TestAccFSxOntapVolume_name
=== PAUSE TestAccFSxOntapVolume_name
=== RUN   TestAccFSxOntapVolume_junctionPath
=== PAUSE TestAccFSxOntapVolume_junctionPath
=== RUN   TestAccFSxOntapVolume_securityStyle
=== PAUSE TestAccFSxOntapVolume_securityStyle
=== RUN   TestAccFSxOntapVolume_size
=== PAUSE TestAccFSxOntapVolume_size
=== RUN   TestAccFSxOntapVolume_storageEfficiency
=== PAUSE TestAccFSxOntapVolume_storageEfficiency
=== RUN   TestAccFSxOntapVolume_tags
=== PAUSE TestAccFSxOntapVolume_tags
=== RUN   TestAccFSxOntapVolume_tieringPolicy
=== PAUSE TestAccFSxOntapVolume_tieringPolicy
=== CONT  TestAccFSxOntapVolume_basic
=== CONT  TestAccFSxOntapVolume_size
=== CONT  TestAccFSxOntapVolume_tieringPolicy
=== CONT  TestAccFSxOntapVolume_junctionPath
=== CONT  TestAccFSxOntapVolume_storageEfficiency
=== CONT  TestAccFSxOntapVolume_securityStyle
=== CONT  TestAccFSxOntapVolume_name
=== CONT  TestAccFSxOntapVolume_disappears
=== CONT  TestAccFSxOntapVolume_tags
--- PASS: TestAccFSxOntapVolume_disappears (2803.68s)
--- PASS: TestAccFSxOntapVolume_basic (2839.57s)
--- PASS: TestAccFSxOntapVolume_junctionPath (3151.69s)
--- PASS: TestAccFSxOntapVolume_securityStyle (3166.83s)
--- PASS: TestAccFSxOntapVolume_storageEfficiency (3208.81s)
--- PASS: TestAccFSxOntapVolume_tags (3290.51s)
--- PASS: TestAccFSxOntapVolume_size (3332.52s)
--- PASS: TestAccFSxOntapVolume_tieringPolicy (3418.50s)
--- PASS: TestAccFSxOntapVolume_name (3508.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	3513.193s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/fsx Issues and PRs that pertain to the fsx service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels May 23, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @sdevope 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 24, 2023
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels May 30, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccFSxOntapVolume_' PKG=fsx ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 3  -run=TestAccFSxOntapVolume_ -timeout 180m
=== RUN   TestAccFSxOntapVolume_basic
=== PAUSE TestAccFSxOntapVolume_basic
=== RUN   TestAccFSxOntapVolume_disappears
=== PAUSE TestAccFSxOntapVolume_disappears
=== RUN   TestAccFSxOntapVolume_name
=== PAUSE TestAccFSxOntapVolume_name
=== RUN   TestAccFSxOntapVolume_junctionPath
=== PAUSE TestAccFSxOntapVolume_junctionPath
=== RUN   TestAccFSxOntapVolume_ontapVolumeType
=== PAUSE TestAccFSxOntapVolume_ontapVolumeType
=== RUN   TestAccFSxOntapVolume_securityStyle
=== PAUSE TestAccFSxOntapVolume_securityStyle
=== RUN   TestAccFSxOntapVolume_size
=== PAUSE TestAccFSxOntapVolume_size
=== RUN   TestAccFSxOntapVolume_storageEfficiency
=== PAUSE TestAccFSxOntapVolume_storageEfficiency
=== RUN   TestAccFSxOntapVolume_tags
=== PAUSE TestAccFSxOntapVolume_tags
=== RUN   TestAccFSxOntapVolume_tieringPolicy
=== PAUSE TestAccFSxOntapVolume_tieringPolicy
=== CONT  TestAccFSxOntapVolume_basic
=== CONT  TestAccFSxOntapVolume_securityStyle
=== CONT  TestAccFSxOntapVolume_tags
--- PASS: TestAccFSxOntapVolume_tags (2950.61s)
=== CONT  TestAccFSxOntapVolume_tieringPolicy
--- PASS: TestAccFSxOntapVolume_basic (2971.49s)
=== CONT  TestAccFSxOntapVolume_storageEfficiency
--- PASS: TestAccFSxOntapVolume_securityStyle (3365.86s)
=== CONT  TestAccFSxOntapVolume_junctionPath
--- PASS: TestAccFSxOntapVolume_storageEfficiency (2941.02s)
=== CONT  TestAccFSxOntapVolume_ontapVolumeType
--- PASS: TestAccFSxOntapVolume_tieringPolicy (3541.02s)
=== CONT  TestAccFSxOntapVolume_name
--- PASS: TestAccFSxOntapVolume_junctionPath (3131.74s)
=== CONT  TestAccFSxOntapVolume_disappears
--- PASS: TestAccFSxOntapVolume_ontapVolumeType (2793.20s)
=== CONT  TestAccFSxOntapVolume_size
--- PASS: TestAccFSxOntapVolume_disappears (2850.96s)
--- PASS: TestAccFSxOntapVolume_name (3637.75s)
--- PASS: TestAccFSxOntapVolume_size (3196.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	3246.786s

@ewbankkit
Copy link
Contributor

@sdevope Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit fe4e3c9 into hashicorp:main May 30, 2023
@github-actions github-actions bot added this to the v5.1.0 milestone May 30, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: specify "DP" as the input volume type while using aws_fsx_ontap_volume resource
3 participants