Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: resourcegroups_resources #31285

Closed
silvaalbert opened this issue May 9, 2023 · 3 comments · Fixed by #31430
Closed

[New Resource]: resourcegroups_resources #31285

silvaalbert opened this issue May 9, 2023 · 3 comments · Fixed by #31430
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/resourcegroups Issues and PRs that pertain to the resourcegroups service.
Milestone

Comments

@silvaalbert
Copy link
Contributor

silvaalbert commented May 9, 2023

Description

Add a resource that would allow resources to be added to a resource group

Affected Resource(s) and/or Data Source(s)

  • aws_resourcegroups_group

Potential Terraform Configuration

resource "aws_resourcegroups_group" "test" {
  name = "test-group"

  resource_query {
    query = <<JSON
{
  "ResourceTypeFilters": [
    "AWS::EC2::Instance"
  ],
  "TagFilters": [
    {
      "Key": "Stage",
      "Values": ["Test"]
    }
  ]
}
JSON
  }

resource "aws_resourcegroups_resources" "test" {
  group = aws_resourcegroups_group.test.arn
  resource_arns = ["xxx", "zzz"]
}

References

https://docs.aws.amazon.com/ARG/latest/APIReference/API_GroupResources.html

Would you like to implement a fix?

Yes

@silvaalbert silvaalbert added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/resourcegroups Issues and PRs that pertain to the resourcegroups service. label May 9, 2023
@silvaalbert silvaalbert changed the title [Enhancement]: Support resource_arns in resourcegroups_group resource [New Resource]: resourcegroups_resources May 9, 2023
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 9, 2023
@github-actions github-actions bot added this to the v5.1.0 milestone May 30, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/resourcegroups Issues and PRs that pertain to the resourcegroups service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants