Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_db_snapshot_copy support for sharing snapshots #31212

Closed
michemache opened this issue May 5, 2023 · 5 comments · Fixed by #34843 · May be fixed by OpenGLShaders/terraform-provider-aws#1
Closed

[Enhancement]: aws_db_snapshot_copy support for sharing snapshots #31212

michemache opened this issue May 5, 2023 · 5 comments · Fixed by #34843 · May be fixed by OpenGLShaders/terraform-provider-aws#1
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@michemache
Copy link

michemache commented May 5, 2023

Description

The aws_db_snapshot resource supports snapshot sharing with the shared_accounts argument since release v4.58.0. Would be very helpful if aws_db_snapshot_copy got this feature too.

Affected Resource(s) and/or Data Source(s)

  • aws_db_snapshot_copy

Potential Terraform Configuration

resource "aws_db_snapshot_copy" "example" {
  source_db_snapshot_identifier = "arn:aws:rds:..."
  target_db_snapshot_identifier = "copy-snapshot"
  shared_accounts               = ["111122223333", "444455556666"]
}

References

Similar to the implementation for aws_db_snapshot here: #28424
A related issue: #14600

Would you like to implement a fix?

None

@michemache michemache added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels May 5, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/rds Issues and PRs that pertain to the rds service. label May 5, 2023
@bschaatsbergen
Copy link
Member

Thanks for raising this issue @michemache, I'm happy to take a stab at it.

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

Copy link

This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
3 participants