Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_acmpca_certificate_authority: Remove status attribute #31084

Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented May 1, 2023

Description

Removes the deprecated status attribute.

Relations

Closes #17832.
Relates #22878.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccACMPCACertificateAuthorityDataSource_basic$$\|TestAccACMPCACertificateAuthority_basic$$' PKG=acmpca
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acmpca/... -v -count 1 -parallel 20  -run=TestAccACMPCACertificateAuthorityDataSource_basic$\|TestAccACMPCACertificateAuthority_basic$ -timeout 180m
=== RUN   TestAccACMPCACertificateAuthorityDataSource_basic
=== PAUSE TestAccACMPCACertificateAuthorityDataSource_basic
=== RUN   TestAccACMPCACertificateAuthority_basic
=== PAUSE TestAccACMPCACertificateAuthority_basic
=== CONT  TestAccACMPCACertificateAuthorityDataSource_basic
=== CONT  TestAccACMPCACertificateAuthority_basic
--- PASS: TestAccACMPCACertificateAuthority_basic (21.87s)
--- PASS: TestAccACMPCACertificateAuthorityDataSource_basic (22.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acmpca	28.324s

@ewbankkit ewbankkit added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label May 1, 2023
@ewbankkit ewbankkit added this to the v5.0.0 milestone May 1, 2023
@github-actions
Copy link

github-actions bot commented May 1, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/acmpca Issues and PRs that pertain to the acmpca service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 1, 2023
@ewbankkit ewbankkit merged commit 5e64cca into prerelease/5.x May 1, 2023
@ewbankkit ewbankkit deleted the f-aws_acmpca_certificate_authority.status-remove branch May 1, 2023 13:07
github-actions bot pushed a commit that referenced this pull request May 1, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/acmpca Issues and PRs that pertain to the acmpca service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant