Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_api_gateway_rest_api: Make minimum_compression_size Computed #30844

Closed
ewbankkit opened this issue Apr 20, 2023 · 4 comments
Closed

r/aws_api_gateway_rest_api: Make minimum_compression_size Computed #30844

ewbankkit opened this issue Apr 20, 2023 · 4 comments
Assignees
@jar-b
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service.
Milestone
v5.0.0

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Apr 20, 2023 •
edited
Loading

A comment from #17099 in internal/service/apigateway/rest_api_test.go:

TODO: The attribute type must be changed to NullableTypeInt so it can be Computed properly.

Customers have reported this as a problem.

We can make the change at v5.0.0.
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ewbankkit ewbankkit changed the title r/aws_api_gateway_rest_api: Make 'minimum_compression_size' Computed r/aws_api_gateway_rest_api: Make minimum_compression_size Computed Apr 20, 2023
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service. labels Apr 20, 2023
@ewbankkit ewbankkit added this to the v5.0.0 milestone Apr 20, 2023
@jar-b jar-b self-assigned this Apr 25, 2023
@jar-b jar-b mentioned this issue Apr 25, 2023
Merged
@jar-b jar-b added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Apr 26, 2023
@jar-b
Copy link
Member

jar-b commented May 23, 2023

Closed by #30969, merged to main in #31392

@jar-b jar-b closed this as completed May 23, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jar-b jar-b

Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service.
Projects
None yet
Milestone
v5.0.0
Development

No branches or pull requests
2 participants
@ewbankkit @jar-b