-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow suppressed_reasons to be an empty list in order to disable the suppression list for a configuration set #29671
Allow suppressed_reasons to be an empty list in order to disable the suppression list for a configuration set #29671
Conversation
Community NoteVoting for Prioritization
For Submitters
|
b9351ea
to
a36e400
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @F21 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
a36e400
to
38231d3
Compare
38231d3
to
379fa18
Compare
379fa18
to
6c5b171
Compare
6c5b171
to
27ef4be
Compare
I want this!!! |
…suppression list for a configuration set
27ef4be
to
43b9eb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSESV2ConfigurationSet_' PKG=sesv2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/sesv2/... -v -count 1 -parallel 3 -run=TestAccSESV2ConfigurationSet_ -timeout 360m
=== RUN TestAccSESV2ConfigurationSet_basic
=== PAUSE TestAccSESV2ConfigurationSet_basic
=== RUN TestAccSESV2ConfigurationSet_disappears
=== PAUSE TestAccSESV2ConfigurationSet_disappears
=== RUN TestAccSESV2ConfigurationSet_tlsPolicy
=== PAUSE TestAccSESV2ConfigurationSet_tlsPolicy
=== RUN TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== RUN TestAccSESV2ConfigurationSet_sendingEnabled
=== PAUSE TestAccSESV2ConfigurationSet_sendingEnabled
=== RUN TestAccSESV2ConfigurationSet_suppressedReasons
=== PAUSE TestAccSESV2ConfigurationSet_suppressedReasons
=== RUN TestAccSESV2ConfigurationSet_suppressedReasonsEmpty
=== PAUSE TestAccSESV2ConfigurationSet_suppressedReasonsEmpty
=== RUN TestAccSESV2ConfigurationSet_engagementMetrics
=== PAUSE TestAccSESV2ConfigurationSet_engagementMetrics
=== RUN TestAccSESV2ConfigurationSet_optimizedSharedDelivery
=== PAUSE TestAccSESV2ConfigurationSet_optimizedSharedDelivery
=== RUN TestAccSESV2ConfigurationSet_tags
=== PAUSE TestAccSESV2ConfigurationSet_tags
=== CONT TestAccSESV2ConfigurationSet_basic
=== CONT TestAccSESV2ConfigurationSet_suppressedReasons
=== CONT TestAccSESV2ConfigurationSet_optimizedSharedDelivery
--- PASS: TestAccSESV2ConfigurationSet_basic (14.33s)
=== CONT TestAccSESV2ConfigurationSet_tags
--- PASS: TestAccSESV2ConfigurationSet_optimizedSharedDelivery (22.39s)
=== CONT TestAccSESV2ConfigurationSet_reputationMetricsEnabled
--- PASS: TestAccSESV2ConfigurationSet_suppressedReasons (22.42s)
=== CONT TestAccSESV2ConfigurationSet_sendingEnabled
--- PASS: TestAccSESV2ConfigurationSet_tags (28.56s)
=== CONT TestAccSESV2ConfigurationSet_tlsPolicy
--- PASS: TestAccSESV2ConfigurationSet_reputationMetricsEnabled (20.85s)
=== CONT TestAccSESV2ConfigurationSet_disappears
--- PASS: TestAccSESV2ConfigurationSet_sendingEnabled (20.84s)
=== CONT TestAccSESV2ConfigurationSet_engagementMetrics
--- PASS: TestAccSESV2ConfigurationSet_disappears (10.66s)
=== CONT TestAccSESV2ConfigurationSet_suppressedReasonsEmpty
--- PASS: TestAccSESV2ConfigurationSet_tlsPolicy (20.79s)
--- PASS: TestAccSESV2ConfigurationSet_engagementMetrics (21.11s)
--- PASS: TestAccSESV2ConfigurationSet_suppressedReasonsEmpty (13.27s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sesv2 72.071s
@F21 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This change fixes the bug reported in #28669 where it is not possible to set
sesv2_configuration_set
'ssuppression_options.suppressed_reasons
to an empty array to disable the suppression list for the configuration set.Relations
Supersedes #28670
Closes #28669
References
See #28669 (comment)
Output from Acceptance Testing