Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow suppressed_reasons to be an empty list in order to disable the suppression list for a configuration set #29671

Merged
merged 8 commits into from
Sep 11, 2024

Conversation

F21
Copy link
Contributor

@F21 F21 commented Feb 27, 2023

Description

This change fixes the bug reported in #28669 where it is not possible to set sesv2_configuration_set's suppression_options.suppressed_reasons to an empty array to disable the suppression list for the configuration set.

Relations

Supersedes #28670
Closes #28669

References

See #28669 (comment)

Output from Acceptance Testing

$  make testacc TESTS=TestAccSESV2ConfigurationSet_suppressedReasonsEmpty PKG=sesv2
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2ConfigurationSet_suppressedReasonsEmpty'  -timeout 180m
=== RUN   TestAccSESV2ConfigurationSet_suppressedReasonsEmpty
=== PAUSE TestAccSESV2ConfigurationSet_suppressedReasonsEmpty
=== CONT  TestAccSESV2ConfigurationSet_suppressedReasonsEmpty
--- PASS: TestAccSESV2ConfigurationSet_suppressedReasonsEmpty (22.90s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      22.960s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/sesv2 Issues and PRs that pertain to the sesv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Feb 27, 2023
@F21 F21 force-pushed the b-allow_suppression_reasons_to_be_zero branch from b9351ea to a36e400 Compare February 27, 2023 02:17
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @F21 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@F21 F21 force-pushed the b-allow_suppression_reasons_to_be_zero branch from a36e400 to 38231d3 Compare March 5, 2023 21:47
@breathingdust breathingdust added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 6, 2023
@F21 F21 force-pushed the b-allow_suppression_reasons_to_be_zero branch from 38231d3 to 379fa18 Compare September 7, 2023 22:39
@F21 F21 force-pushed the b-allow_suppression_reasons_to_be_zero branch from 379fa18 to 6c5b171 Compare September 20, 2023 21:59
@F21 F21 force-pushed the b-allow_suppression_reasons_to_be_zero branch from 6c5b171 to 27ef4be Compare October 17, 2023 22:40
@YukiTsuchida
Copy link

I want this!!!

@F21 F21 force-pushed the b-allow_suppression_reasons_to_be_zero branch from 27ef4be to 43b9eb9 Compare March 11, 2024 00:45
@ewbankkit ewbankkit requested a review from a team as a code owner September 11, 2024 16:14
@ewbankkit ewbankkit self-assigned this Sep 11, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 11, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSESV2ConfigurationSet_' PKG=sesv2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/sesv2/... -v -count 1 -parallel 3  -run=TestAccSESV2ConfigurationSet_ -timeout 360m
=== RUN   TestAccSESV2ConfigurationSet_basic
=== PAUSE TestAccSESV2ConfigurationSet_basic
=== RUN   TestAccSESV2ConfigurationSet_disappears
=== PAUSE TestAccSESV2ConfigurationSet_disappears
=== RUN   TestAccSESV2ConfigurationSet_tlsPolicy
=== PAUSE TestAccSESV2ConfigurationSet_tlsPolicy
=== RUN   TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== RUN   TestAccSESV2ConfigurationSet_sendingEnabled
=== PAUSE TestAccSESV2ConfigurationSet_sendingEnabled
=== RUN   TestAccSESV2ConfigurationSet_suppressedReasons
=== PAUSE TestAccSESV2ConfigurationSet_suppressedReasons
=== RUN   TestAccSESV2ConfigurationSet_suppressedReasonsEmpty
=== PAUSE TestAccSESV2ConfigurationSet_suppressedReasonsEmpty
=== RUN   TestAccSESV2ConfigurationSet_engagementMetrics
=== PAUSE TestAccSESV2ConfigurationSet_engagementMetrics
=== RUN   TestAccSESV2ConfigurationSet_optimizedSharedDelivery
=== PAUSE TestAccSESV2ConfigurationSet_optimizedSharedDelivery
=== RUN   TestAccSESV2ConfigurationSet_tags
=== PAUSE TestAccSESV2ConfigurationSet_tags
=== CONT  TestAccSESV2ConfigurationSet_basic
=== CONT  TestAccSESV2ConfigurationSet_suppressedReasons
=== CONT  TestAccSESV2ConfigurationSet_optimizedSharedDelivery
--- PASS: TestAccSESV2ConfigurationSet_basic (14.33s)
=== CONT  TestAccSESV2ConfigurationSet_tags
--- PASS: TestAccSESV2ConfigurationSet_optimizedSharedDelivery (22.39s)
=== CONT  TestAccSESV2ConfigurationSet_reputationMetricsEnabled
--- PASS: TestAccSESV2ConfigurationSet_suppressedReasons (22.42s)
=== CONT  TestAccSESV2ConfigurationSet_sendingEnabled
--- PASS: TestAccSESV2ConfigurationSet_tags (28.56s)
=== CONT  TestAccSESV2ConfigurationSet_tlsPolicy
--- PASS: TestAccSESV2ConfigurationSet_reputationMetricsEnabled (20.85s)
=== CONT  TestAccSESV2ConfigurationSet_disappears
--- PASS: TestAccSESV2ConfigurationSet_sendingEnabled (20.84s)
=== CONT  TestAccSESV2ConfigurationSet_engagementMetrics
--- PASS: TestAccSESV2ConfigurationSet_disappears (10.66s)
=== CONT  TestAccSESV2ConfigurationSet_suppressedReasonsEmpty
--- PASS: TestAccSESV2ConfigurationSet_tlsPolicy (20.79s)
--- PASS: TestAccSESV2ConfigurationSet_engagementMetrics (21.11s)
--- PASS: TestAccSESV2ConfigurationSet_suppressedReasonsEmpty (13.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	72.071s

@ewbankkit
Copy link
Contributor

@F21 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 184cee7 into hashicorp:main Sep 11, 2024
33 checks passed
@github-actions github-actions bot added this to the v5.67.0 milestone Sep 11, 2024
@F21 F21 deleted the b-allow_suppression_reasons_to_be_zero branch September 11, 2024 20:58
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 13, 2024
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
4 participants