fix: add XNotImplemented error handling in resourceBucketRead

[fgouteroux]

Hello,

The following patch third party S3 who does not support some bucket features like accelerate configuration.

Example of error message:

Error: getting S3 Bucket (my-bucket) accelerate configuration: XNotImplemented: The request you provided implies functionality that is not implemented.

Error: getting S3 Bucket request payment: XNotImplemented: The request you provided implies functionality that is not implemented.

Error: getting S3 Bucket logging: XNotImplemented: The request you provided implies functionality that is not implemented.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

$ make testacc PKG=s3 TESTS=TestAccS3Bucket_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3Bucket_'  -timeout 180m
--- PASS: TestAccS3Bucket_Duplicate_UsEast1 (13.44s)
=== CONT  TestAccS3Bucket_Web_redirect
=== CONT  TestAccS3Bucket_Web_simple
--- PASS: TestAccS3Bucket_Duplicate_basic (18.71s)
--- PASS: TestAccS3Bucket_disappears (23.03s)
=== CONT  TestAccS3Bucket_Security_policy
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (31.29s)
=== CONT  TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled
--- PASS: TestAccS3Bucket_Security_corsDelete (31.89s)
=== CONT  TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed
--- PASS: TestAccS3Bucket_Basic_basic (32.21s)
=== CONT  TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical
--- PASS: TestAccS3Bucket_Basic_keyEnabled (38.22s)
=== CONT  TestAccS3Bucket_Security_logging
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (39.29s)
=== CONT  TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin
--- PASS: TestAccS3Bucket_Tags_basic (39.28s)
=== CONT  TestAccS3Bucket_Basic_acceleration
--- PASS: TestAccS3Bucket_Replication_twoDestination (39.97s)
=== CONT  TestAccS3Bucket_Security_corsEmptyOrigin
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (41.20s)
=== CONT  TestAccS3Bucket_Manage_objectLockWithVersioning
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (50.45s)
=== CONT  TestAccS3Bucket_Replication_basic
--- PASS: TestAccS3Bucket_Tags_ignoreTags (53.06s)
=== CONT  TestAccS3Bucket_Manage_versioningAndMFADeleteDisabled
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (53.91s)
=== CONT  TestAccS3Bucket_Manage_MFADeleteDisabled
--- PASS: TestAccS3Bucket_Basic_requestPayer (54.57s)
=== CONT  TestAccS3Bucket_Manage_versioningDisabled
--- PASS: TestAccS3Bucket_Web_routingRules (54.52s)
=== CONT  TestAccS3Bucket_Manage_versioning
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (62.68s)
=== CONT  TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (32.08s)
=== CONT  TestAccS3Bucket_Security_updateACL
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (64.60s)
=== CONT  TestAccS3Bucket_Security_corsUpdate
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (33.73s)
=== CONT  TestAccS3Bucket_Security_grantToACL
--- PASS: TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin (32.21s)
=== CONT  TestAccS3Bucket_Security_aclToGrant
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (33.44s)
=== CONT  TestAccS3Bucket_Security_updateGrant
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning (33.91s)
=== CONT  TestAccS3Bucket_Manage_objectLock
--- PASS: TestAccS3Bucket_Security_logging (36.99s)
=== CONT  TestAccS3Bucket_Manage_objectLock_migrate
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (51.53s)
=== CONT  TestAccS3Bucket_Manage_objectLock_deprecatedEnabled
--- PASS: TestAccS3Bucket_Manage_versioningAndMFADeleteDisabled (31.53s)
=== CONT  TestAccS3Bucket_Basic_namePrefix
--- PASS: TestAccS3Bucket_Manage_MFADeleteDisabled (31.56s)
=== CONT  TestAccS3Bucket_Basic_forceDestroy
--- PASS: TestAccS3Bucket_Web_redirect (73.02s)
=== CONT  TestAccS3Bucket_Replication_schemaV2
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (33.20s)
=== CONT  TestAccS3Bucket_Replication_RTC_valid
--- PASS: TestAccS3Bucket_Web_simple (73.43s)
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
--- PASS: TestAccS3Bucket_Security_policy (71.41s)
=== CONT  TestAccS3Bucket_Replication_schemaV2SameRegion
--- PASS: TestAccS3Bucket_Basic_acceleration (56.88s)
=== CONT  TestAccS3Bucket_Basic_emptyString
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled (38.52s)
=== CONT  TestAccS3Bucket_Replication_withoutPrefix
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (104.67s)
=== CONT  TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration
--- PASS: TestAccS3Bucket_Basic_forceDestroy (29.43s)
=== CONT  TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock
--- PASS: TestAccS3Bucket_Manage_objectLock_migrate (40.14s)
=== CONT  TestAccS3Bucket_Manage_lifecycleRemove
--- PASS: TestAccS3Bucket_Manage_objectLock_deprecatedEnabled (32.74s)
=== CONT  TestAccS3Bucket_Basic_generatedName
--- PASS: TestAccS3Bucket_Basic_namePrefix (31.84s)
=== CONT  TestAccS3Bucket_Replication_expectVersioningValidationError
--- PASS: TestAccS3Bucket_Security_grantToACL (50.53s)
=== CONT  TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter
--- PASS: TestAccS3Bucket_Manage_versioning (62.25s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (48.61s)
--- PASS: TestAccS3Bucket_Security_updateACL (57.33s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (31.37s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (59.40s)
--- PASS: TestAccS3Bucket_Basic_emptyString (32.57s)
--- PASS: TestAccS3Bucket_Manage_objectLock (54.99s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (14.88s)
--- PASS: TestAccS3Bucket_Replication_basic (81.56s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (37.67s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (32.70s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (30.54s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (23.16s)
--- PASS: TestAccS3Bucket_Basic_generatedName (26.07s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (26.75s)
--- PASS: TestAccS3Bucket_Security_updateGrant (71.28s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRemove (33.44s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (150.30s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (73.68s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (89.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 180.775s

[jar-b]

Thanks for your contribution, @fgouteroux! 👏

[github-actions]

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.