-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_apprunner_service: Support for runtime_environment_secrets #28871
r/aws_apprunner_service: Support for runtime_environment_secrets #28871
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAppRunnerService_' PKG=apprunner ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 3 -run=TestAccAppRunnerService_ -timeout 180m
=== RUN TestAccAppRunnerService_ImageRepository_basic
=== PAUSE TestAccAppRunnerService_ImageRepository_basic
=== RUN TestAccAppRunnerService_ImageRepository_autoScaling
=== PAUSE TestAccAppRunnerService_ImageRepository_autoScaling
=== RUN TestAccAppRunnerService_ImageRepository_encryption
=== PAUSE TestAccAppRunnerService_ImageRepository_encryption
=== RUN TestAccAppRunnerService_ImageRepository_healthCheck
=== PAUSE TestAccAppRunnerService_ImageRepository_healthCheck
=== RUN TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole
=== PAUSE TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole
=== RUN TestAccAppRunnerService_ImageRepository_instance_Update
=== PAUSE TestAccAppRunnerService_ImageRepository_instance_Update
=== RUN TestAccAppRunnerService_ImageRepository_networkConfiguration
=== PAUSE TestAccAppRunnerService_ImageRepository_networkConfiguration
=== RUN TestAccAppRunnerService_ImageRepository_observabilityConfiguration
=== PAUSE TestAccAppRunnerService_ImageRepository_observabilityConfiguration
=== RUN TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars
=== PAUSE TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars
=== RUN TestAccAppRunnerService_ImageRepository_runtimeEnvironmentSecrets
=== PAUSE TestAccAppRunnerService_ImageRepository_runtimeEnvironmentSecrets
=== RUN TestAccAppRunnerService_disappears
=== PAUSE TestAccAppRunnerService_disappears
=== RUN TestAccAppRunnerService_tags
=== PAUSE TestAccAppRunnerService_tags
=== CONT TestAccAppRunnerService_ImageRepository_basic
=== CONT TestAccAppRunnerService_ImageRepository_networkConfiguration
=== CONT TestAccAppRunnerService_ImageRepository_runtimeEnvironmentSecrets
--- PASS: TestAccAppRunnerService_ImageRepository_runtimeEnvironmentSecrets (310.17s)
=== CONT TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars
--- PASS: TestAccAppRunnerService_ImageRepository_basic (329.10s)
=== CONT TestAccAppRunnerService_tags
--- PASS: TestAccAppRunnerService_ImageRepository_networkConfiguration (410.89s)
=== CONT TestAccAppRunnerService_ImageRepository_healthCheck
--- PASS: TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars (287.09s)
=== CONT TestAccAppRunnerService_ImageRepository_instance_Update
--- PASS: TestAccAppRunnerService_tags (287.83s)
=== CONT TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole
--- PASS: TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole (296.70s)
=== CONT TestAccAppRunnerService_ImageRepository_encryption
--- PASS: TestAccAppRunnerService_ImageRepository_healthCheck (551.76s)
=== CONT TestAccAppRunnerService_disappears
--- PASS: TestAccAppRunnerService_ImageRepository_instance_Update (479.08s)
=== CONT TestAccAppRunnerService_ImageRepository_autoScaling
--- PASS: TestAccAppRunnerService_disappears (251.63s)
=== CONT TestAccAppRunnerService_ImageRepository_observabilityConfiguration
--- PASS: TestAccAppRunnerService_ImageRepository_encryption (530.59s)
--- PASS: TestAccAppRunnerService_ImageRepository_autoScaling (443.45s)
--- PASS: TestAccAppRunnerService_ImageRepository_observabilityConfiguration (589.55s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/apprunner 1809.002s
@niallthomson Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
AWS App Runner now supports retrieving secrets and configuration data stored in AWS Secrets Manager and AWS Systems Manager Parameter Store in an App Runner service as runtime environment variables.
This PR introduces a
runtime_environment_secrets
parameter toaws_apprunner_service
which takes a map of strings.Example:
Relations
Closes #28849
References
Announcement
Launch blog
Output from Acceptance Testing