-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align aws_ecs_service security_connect_configuration schema with API #28813
Align aws_ecs_service security_connect_configuration schema with API #28813
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (52.08s)
--- PASS: TestAccECSService_Tags_managed (92.78s)
--- PASS: TestAccECSService_clusterName (92.84s)
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (93.80s)
--- PASS: TestAccECSService_Alarms (93.84s)
--- PASS: TestAccECSService_DeploymentValues_basic (93.87s)
--- PASS: TestAccECSService_deploymentCircuitBreaker (94.09s)
--- PASS: TestAccECSService_replicaSchedulingStrategy (94.34s)
--- PASS: TestAccECSService_executeCommand (101.18s)
--- PASS: TestAccECSService_Tags_propagate (107.36s)
--- PASS: TestAccECSService_forceNewDeploymentTriggers (108.90s)
--- PASS: TestAccECSService_forceNewDeployment (109.17s)
--- PASS: TestAccECSService_basic (109.24s)
--- PASS: TestAccECSService_PlacementConstraints_basic (119.39s)
--- PASS: TestAccECSService_Tags_basic (130.01s)
--- PASS: TestAccECSService_DeploymentControllerType_external (52.53s)
--- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (159.89s)
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (165.03s)
--- PASS: TestAccECSService_familyAndRevision (88.78s)
--- PASS: TestAccECSService_PlacementStrategy_missing (1.08s)
--- PASS: TestAccECSService_renamedCluster (77.11s)
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (24.06s)
--- PASS: TestAccECSService_loadBalancerChanges (197.64s)
--- PASS: TestAccECSService_ServiceConnect_remove (178.31s)
--- PASS: TestAccECSService_CapacityProviderStrategy_multiple (111.41s)
--- PASS: TestAccECSService_LaunchTypeEC2_network (81.19s)
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (56.33s)
--- PASS: TestAccECSService_alb (245.65s)
--- PASS: TestAccECSService_multipleTargetGroups (246.87s)
--- PASS: TestAccECSService_LaunchTypeFargate_basic (138.24s)
--- PASS: TestAccECSService_ServiceConnect_full (159.78s)
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (110.71s)
--- PASS: TestAccECSService_ServiceConnect_basic (167.44s)
--- PASS: TestAccECSService_PlacementStrategy_basic (90.47s)
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (68.04s)
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (190.38s)
--- PASS: TestAccECSService_ServiceRegistries_changes (249.50s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (248.93s)
--- PASS: TestAccECSService_healthCheckGracePeriodSeconds (239.31s)
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (164.72s)
--- PASS: TestAccECSService_iamRole (263.48s)
--- PASS: TestAccECSService_CapacityProviderStrategy_update (242.19s)
--- PASS: TestAccECSService_ServiceRegistries_basic (137.14s)
--- PASS: TestAccECSService_disappears (187.41s)
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (157.23s)
--- PASS: TestAccECSService_ServiceRegistries_container (157.58s)
--- PASS: TestAccECSService_basicImport (181.35s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (393.17s)
This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Various elements of the aws_ecs_service relating to service_connect_configuration didn't match up with the documented API at https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_ServiceConnectConfiguration.html and https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_ServiceConnectService.html
Relations
Closes #28754
References
Output from Acceptance Testing