Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Nonexistent resource type referenced in aws_dx_macsec_key_association #28587

Closed
ddericco opened this issue Dec 27, 2022 · 3 comments · Fixed by #28588
Closed

[Docs]: Nonexistent resource type referenced in aws_dx_macsec_key_association #28587

ddericco opened this issue Dec 27, 2022 · 3 comments · Fixed by #28588
Labels
documentation Introduces or discusses updates to documentation. service/directconnect Issues and PRs that pertain to the directconnect service.
Milestone

Comments

@ddericco
Copy link
Contributor

ddericco commented Dec 27, 2022

Documentation Link

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/dx_macsec_key_association

Description

The second Note block on the aws_dx_macsec_key_association resource page states "You cannot associate a Secrets Manager secret created outside of the aws_dx_macsec_key resource."

This is incorrect as there is no aws_dx_macsec_key resource - instead this should refer to the aws_dx_macsec_key_association resource.

References

Original PR with correct resources: #26274

Would you like to implement a fix?

Yes

@ddericco ddericco added documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. labels Dec 27, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ewbankkit ewbankkit added service/directconnect Issues and PRs that pertain to the directconnect service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 3, 2023
@github-actions github-actions bot added this to the v4.49.0 milestone Jan 3, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/directconnect Issues and PRs that pertain to the directconnect service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants