Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_auditmanager_framework #28257

Merged
merged 4 commits into from
Dec 9, 2022
Merged

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Dec 8, 2022

Description

aws_auditmanager_framework will allow practitioners to manage custom assessment frameworks.

Relations

Relates #17981

Output from Acceptance Testing

$ make testacc PKG=auditmanager TESTS=TestAccAuditManagerFramework_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/auditmanager/... -v -count 1 -parallel 20 -run='TestAccAuditManagerFramework_'  -timeout 180m
=== RUN   TestAccAuditManagerFramework_basic
=== PAUSE TestAccAuditManagerFramework_basic
=== RUN   TestAccAuditManagerFramework_disappears
=== PAUSE TestAccAuditManagerFramework_disappears
=== RUN   TestAccAuditManagerFramework_tags
=== PAUSE TestAccAuditManagerFramework_tags
=== RUN   TestAccAuditManagerFramework_optional
=== PAUSE TestAccAuditManagerFramework_optional
=== CONT  TestAccAuditManagerFramework_basic
=== CONT  TestAccAuditManagerFramework_tags
=== CONT  TestAccAuditManagerFramework_optional
=== CONT  TestAccAuditManagerFramework_disappears
--- PASS: TestAccAuditManagerFramework_disappears (24.78s)
--- PASS: TestAccAuditManagerFramework_basic (29.73s)
--- PASS: TestAccAuditManagerFramework_optional (43.80s)
--- PASS: TestAccAuditManagerFramework_tags (52.65s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/auditmanager       56.359s

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/auditmanager Issues and PRs that pertain to the auditmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/auditmanager Issues and PRs that pertain to the auditmanager service. labels Dec 8, 2022
@jar-b jar-b force-pushed the f-aws_auditmanager_framework branch from b6b8838 to 25e5fab Compare December 8, 2022 18:50
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/auditmanager Issues and PRs that pertain to the auditmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/auditmanager Issues and PRs that pertain to the auditmanager service. labels Dec 8, 2022
@jar-b jar-b marked this pull request as ready for review December 8, 2022 19:20
@jar-b jar-b mentioned this pull request Dec 8, 2022
13 tasks
@jar-b jar-b added service/auditmanager Issues and PRs that pertain to the auditmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Dec 8, 2022
@jar-b jar-b merged commit f14cf17 into main Dec 9, 2022
@jar-b jar-b deleted the f-aws_auditmanager_framework branch December 9, 2022 15:14
@github-actions github-actions bot added this to the v4.47.0 milestone Dec 9, 2022
@github-actions
Copy link

This functionality has been released in v4.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/auditmanager Issues and PRs that pertain to the auditmanager service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant