Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws secret manager rotation rules - schedule expression #28016

Closed
Jmyn opened this issue Nov 25, 2022 · 4 comments · Fixed by #30425
Closed

[Enhancement]: aws secret manager rotation rules - schedule expression #28016

Jmyn opened this issue Nov 25, 2022 · 4 comments · Fixed by #30425
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/secretsmanager Issues and PRs that pertain to the secretsmanager service.
Milestone

Comments

@Jmyn
Copy link

Jmyn commented Nov 25, 2022

Description

Seems like current secret rotation rules configuration only allow for auto rotation schedule in unit of days. Would be good if the resource is enhanced to allow users to set their own schedule expression as per aws api using cron/rate

rotation_rules
automatically_after_days - (Required) Specifies the number of days between automatic scheduled rotations of the secret.

Affected Resource(s) and/or Data Source(s)

aws_secretsmanager_secret_rotation

Potential Terraform Configuration

Add two missing attributes to rotation_rules block. schedule_expression and automatically_after_days are conflicting attributes.

rotation_rules {
    duration = "2h"
    schedule_expression = "cron(0 1 * * ? *)"
  }

References

References:
Aws API
CloudFormation

Would you like to implement a fix?

No response

@Jmyn Jmyn added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Nov 25, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@Jmyn Jmyn changed the title [Enhancement]: [Enhancement]: aws secret manager rotation rules Nov 25, 2022
@Jmyn Jmyn changed the title [Enhancement]: aws secret manager rotation rules [Enhancement]: aws secret manager rotation rules - scheduled expression Nov 25, 2022
@Jmyn Jmyn changed the title [Enhancement]: aws secret manager rotation rules - scheduled expression [Enhancement]: aws secret manager rotation rules - schedule expression Nov 25, 2022
@breathingdust breathingdust added service/secretsmanager Issues and PRs that pertain to the secretsmanager service. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 25, 2022
@silvaalbert
Copy link
Contributor

Thanks for submitting this @Jmyn - I ran into this doing some stuff over the weekend. I will work on the implementation.

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/secretsmanager Issues and PRs that pertain to the secretsmanager service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants