Add the option to preserve the source data type for S3 output format…

[kristofmartens]

APPFLOW: Add support for preserving source data types in S3 outputs for Parquet file types

Enhancement resolving (#26372)

Description

Add preserve_source_data_typing parameter in the s3_output_format_config option block that was missing in the current implementation.

Relations

Closes #26372

Output from Acceptance Testing

❯ make testacc TESTS=TestAccAppFlowFlow PKG=appflow
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20 -run='TestAccAppFlowFlow'  -timeout 180m
=== RUN   TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== RUN   TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== RUN   TestAccAppFlowFlow_TaskProperties
=== PAUSE TestAccAppFlowFlow_TaskProperties
=== RUN   TestAccAppFlowFlow_tags
=== PAUSE TestAccAppFlowFlow_tags
=== RUN   TestAccAppFlowFlow_disappears
=== PAUSE TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowFlow_basic
=== CONT  TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowFlow_tags
=== CONT  TestAccAppFlowFlow_TaskProperties
=== CONT  TestAccAppFlowFlow_update
--- PASS: TestAccAppFlowFlow_disappears (47.72s)
--- PASS: TestAccAppFlowFlow_TaskProperties (48.29s)
--- PASS: TestAccAppFlowFlow_basic (54.83s)
--- PASS: TestAccAppFlowFlow_update (88.06s)
--- PASS: TestAccAppFlowFlow_tags (128.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	145.714s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

[github-actions]

Welcome @kristofmartens 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[kristofmartens]

Any idea when this PR could be reviewed/merged/released?

[rpawlaszek]

Any idea when this PR could be reviewed/merged/released?

Is there an ETA on this PR?

[dernat71]

That'd be awesome to merge this PR as we need it in my team!

[rpawlaszek]

@YakDriver, is there any prioritization process for the PRs that we could use to bring this PR up in the chain?

[kristofmartens]

Guess this PR is here to die as long as there does not seem to be a way to get their attention... I rather have the devs decline it...

[HannesDS]

• 1

[kristofmartens]

@justinretzolk, you were the last one to touch this PR. You have any idea how to get this PR merged somehow? Are there still any remarks or changes you would like to see? No problem to close or reject this PR, having an update though would be appreciated.

[johnsonaj]

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccAppFlowFlow_' PKG=appflow

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20  -run=TestAccAppFlowFlow_ -timeout 180m
--- PASS: TestAccAppFlowFlow_disappears (18.06s)
--- PASS: TestAccAppFlowFlow_TaskProperties (18.67s)
--- PASS: TestAccAppFlowFlow_basic (20.96s)
--- PASS: TestAccAppFlowFlow_update (30.93s)
--- PASS: TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType (32.91s)
--- PASS: TestAccAppFlowFlow_tags (47.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	50.402s

[johnsonaj]

@kristofmartens thank you for the contribution! 🎉

[github-actions]

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.